summaryrefslogtreecommitdiffstats
path: root/source/printing
Commit message (Collapse)AuthorAgeFilesLines
...
* Changes from APPLIANCE_HEAD:David O'Neill2001-01-192-20/+45
| | | | | | | | | | | | | | | | | | source/printing/nt_printing.c - use se_create_child_secdesc() to create appropriate security descriptor when performing print job admin security checks. source/printing/printing.c - Use JOB_ACCESS_ADMINISTER instead of PRINTER_ACCESS_ADMINISTER in print_job_{delete,pause,resume}() - If stat'ing the job file fails, delete the job from printing.tdb - In print_job_end() check lpq cache time and do a print_queue_update() This prevents printing.tdb from growing when using NT/2K clients, and there isn't someone pressing F5 in a port monitor window. - In print_queue_resume() check lpq cache time and do a print_queue_update() Probably should do it for print_job_resume() too.
* Changes from APPLIANCE_HEAD:David O'Neill2001-01-174-8/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | source/rpc_server/srv_spoolss_nt.c - Unrolled construct_notify_jobs_info() loop to only fetch printer info_2 structure once rather than num_print_jobs times. - convert command to unix codepage. - remove lp_remove_service() call as it prevents lp_killservice() from working. - Modified some DEBUG and DEBUGADD statements. source/param/loadparm.c source/param/params.c - change printer, preload, auto services to FLAG_DOS_STRING, reverted earlier changes to szPrintername et al, add comments. source/printing/load.c - fix bug with lp_auto_services() and strtok() source/printing/nt_printing.c source/printing/printing.c - remove redundant test that used SERVICE(snum) source/printing/pcap.c - add unix_to_dos() calls, add notes wrt FIXMEs for xxx_printer_fn() functions. source/web/swat.c - added FIXME comment. source/smbd/service.c - added comment re: dos codepage
* Changes from APPLIANCE_HEAD:David O'Neill2001-01-112-19/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | testsuite/printing/psec.c - Use lock directory from smb.conf parameter when peeking at the ntdrivers.tdb file. source/rpc_parse/parse_sec.c - fix typo in debug message source/script/installbin.sh - create private directory as part of 'make install'. source/nsswitch/winbindd_cache.c source/nsswitch/winbindd_idmap.c source/passdb/secrets.c source/smbd/connection.c - always convert tdb key to unix code-page when generating. source/printing/nt_printing.c - always convert tdb key to unix code-page when generating. - don't prepend path to a filename that is NULL in add_a_printer_driver_3(). source/rpc_server/srv_spoolss_nt.c - always convert tdb key to unix code-page when generating. - don't prepend server name to a path/filename that is NULL in the fill_printer_driver_info functions. source/printing/printing.c - always convert tdb key to unix code-page when generating. - move access check for print_queue_purge() outside of job delete loop. source/smbd/unix_acls.c - fix for setting ACLs (this got missed earlier) source/lib/messages.c - trivial sync with appliance_head
* Changes merged from APPLIANCE_HEAD:David O'Neill2001-01-081-3/+4
| | | | | | source/printing/printing.c source/rpc_server/srv_spoolss_nt.c - convert args for print command to unix codepage.
* Changes from APPLIANCE_HEAD:David O'Neill2001-01-042-75/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | source/Makefile.in - changes to ctags and etags rules that somehow got lost along the way. source/include/proto.h - make proto source/smbd/sec_ctx.c source/smbd/password.c - merge debugs for debugging user groups and NT token stuff. source/lib/util_str.c - capitalise domain name returned from parse_domain_user() source/nsswitch/wb_client.c - fix broken conditional in debug statement. source/include/rpc_secdes.h source/include/rpc_spoolss.h source/printing/nt_printing.c source/lib/util_seaccess.c - fix printer permission bugs related to ACE masks for printers. This adds mapping of generic access rights to object specific rights for NT printers. Still need to work out whether or not to ignore ACEs with certain flags set, though. See comments in util_seaccess.c:check_ace() for details. source/printing/nt_printing.c source/printing/printing.c - use PRINTER_ACCESS_ADMINISTER instead of JOB_ACCESS_ADMINISTER until we sort out printer/printjob permission stuff.
* merge from appliance headGerald Carter2000-12-211-0/+5
|
* Merged Tim's fixes from appliance-head.Jeremy Allison2000-12-181-4/+8
| | | | Jeremy.
* Fixed memory leaks in lsa_XX calls. Fixed memory leaks in smbcacls. MergedJeremy Allison2000-12-151-8/+8
| | | | | | in fixes from appliance-head and 2.2. Fixed multiple connection.tdb open problem. Jeremy.
* Changes from APPLIANCE_HEAD:David O'Neill2000-12-131-14/+19
| | | | | | | | | - trivial typo in definition of enum_printing[] (source/param/loadparm.c) - fixed printer status display bug. When no jobs existed in queue, the clients were not properly notified of printer status. This caused native tools for pausing/unpausing a print queue to not work. (source/printing/printing.c)
* Added proto definition for new RPC calls.Jeremy Allison2000-12-131-32/+15
| | | | | Added printing fix from appliance-head. Jeremy.
* Adding in debug for SD's.Jeremy Allison2000-12-111-0/+17
| | | | Jeremy.
* file_lines_load/file_lines_pload can now optionally convert unix_to_dos()Jeremy Allison2000-12-073-5/+5
| | | | | on read. Jeremy.
* Sync-up with appliance-head printing code.Jeremy Allison2000-12-062-50/+46
| | | | Jeremy.
* c++ style comments are NOT allowedAndrew Tridgell2000-12-041-1/+0
|
* no longer pass the type to make_sec_desc(), instead the type isAndrew Tridgell2000-12-041-4/+0
| | | | derived from the other arguments
* passdb/secrets.c passdb/smbpassfile.c smbd/server.c : Actually *use* the codeJeremy Allison2000-11-271-1/+10
| | | | | | | written to transition from an old DOMAIN.MACHINE.MAC file to secrets.tdb. printing/nt_printing.c: Fix case insensitive name lookups for driver files. John - this should fix the Win9x/WinME problem correctly. Jeremy.
* Fix for updating of print queues changed from a local box. Essentially,Jeremy Allison2000-11-211-15/+43
| | | | | | this makes sure that the change messages sent to ourselves are handled synchronously w.r.t. other smb packets incoming. Jeremy.
* Fix for memory leak when adding driver.Jeremy Allison2000-11-171-6/+7
| | | | Jeremy.
* Fix for incorrect break using wrong offset when updating a form.Jeremy Allison2000-11-171-6/+4
| | | | Jeremy.
* Fix for a problem with the new messaging system. If a sender is using theJeremy Allison2000-11-161-14/+7
| | | | | | | | | | | | | | messaging system as a notification mechanism, and the speed of notification greatly exceeds the speed of message recovery, then you get a massively (>75Mb) growing tdb. If the message is a simple notification, then the message is static, and you only need one of them in transit to a target process at any one time. This patch adds a BOOL "allow_duplicates" to the message_send_XX primitives. If set to False, then before sending a message the sender checks the existing message queue for a target pid for a duplicate of this message, and doesn't add to it if one already exists. Also added code into msgtest.c to test this. Jeremy.
* Uninitialized memory read fixes.Jeremy Allison2000-11-151-3/+7
| | | | | open_file_shared takes a DOS pathname, not a UNIX one. Jeremy.
* Tuyrn debug timestamps on by default.Jeremy Allison2000-11-151-4/+16
| | | | | Add Tim's lpq race fix. Jeremy.
* Merge from appliance head of JR's changes for driver versioning.Jeremy Allison2000-11-142-183/+698
| | | | Jeremy.
* Changes from APPLIANCE_HEAD:David O'Neill2000-11-141-0/+51
| | | | | | | | | - merged Tim's vlp (virtual lp) test program. Enable it with -DDEVELOPER or by using ./configure.developer (source/include/smb.h source/configure.developer source/printing/lpq_parse.c source/param/loadparm.c testsuite/printing/.cvsignore testsuite/printing/Makefile.vlp testsuite/printing/vlp.c)
* printing/nt_printing.c: After long soul searching and making both Andrew and myJeremy Allison2000-11-141-2/+4
| | | | | | | | life a misery, here is the only possible null driver fix we have found. This *SUCKS*. rpc_server/srv_spoolss_nt.c: Correct printername search. Correct portname reply Correct attributes reply. Removal of unused temp variable. Jeremy.
* Large commit which restructures the local password storage API.Gerald Carter2000-11-131-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently the only backend which works is smbpasswd (tdb, LDAP, and NIS+) are broken, but they were somewhat broken before. :) The following functions implement the storage manipulation interface /*The following definitions come from passdb/pdb_smbpasswd.c */ BOOL pdb_setsampwent (BOOL update); void pdb_endsampwent (void); SAM_ACCOUNT* pdb_getsampwent (void); SAM_ACCOUNT* pdb_getsampwnam (char *username); SAM_ACCOUNT* pdb_getsampwuid (uid_t uid); SAM_ACCOUNT* pdb_getsampwrid (uint32 rid); BOOL pdb_add_sam_account (SAM_ACCOUNT *sampass); BOOL pdb_update_sam_account (SAM_ACCOUNT *sampass, BOOL override); BOOL pdb_delete_sam_account (char* username); There is also a host of pdb_set..() and pdb_get..() functions for manipulating SAM_ACCOUNT struct members. Note that the struct passdb_ops {} has gone away. Also notice that struct smb_passwd (formally in smb.h) has been moved to passdb/pdb_smbpasswd.c and is not accessed outisde of static internal functions in this file. All local password searches should make use of the the SAM_ACCOUNT struct and the previously mentioned functions. I'll write some documentation for this later. The next step is to fix the TDB passdb backend, then work on spliting the backends out into share libraries, and finally get the LDAP backend going. What works and may not: o domain logons from Win9x works o domain logons from WinNT 4 works o user and group enumeration as implemented by Tim works o file and print access works o changing password from Win9x & NT ummm...i'll fix this tonight :) If I broke anything else, just yell and I'll fix it. I think it should be fairly quite. -- jerry
* Added Tim's changes to lock DB during update.Jeremy Allison2000-11-101-3/+18
| | | | Jeremy.
* printing/nt_printing.c: use getpwuid not smbgetpwuid. Canonicalize printernames.Jeremy Allison2000-11-102-7/+19
| | | | | | | | printing/printing.c: Insure fix for malloc of zero. rpc_parse/parse_misc.c: Enusre UNISTR's are zero filled. rpc_parse/parse_spoolss.c: Correct INFO_6 - differs between pre-releases of W2K and shipping build. rpc_server/srv_spoolss_nt.c: Canonicalize printernames. Jeremy.
* an attempt to get the handling of fields in printer info structuresAndrew Tridgell2000-11-081-5/+6
| | | | | consistent. Still working with Jeremy on this, there is probably more to be done
* Merge of latest round of printing fixes from appliance branch.Tim Potter2000-11-071-30/+69
|
* Merge of printer security descriptor, info level and printerdataTim Potter2000-11-071-58/+2
| | | | comparison changes from appliance branch.
* Merge from Tim - don't reinsert UNIX job if already exists.Jeremy Allison2000-11-041-0/+8
| | | | Jeremy.
* Merge of printing improvements/fixes from appliance branch.Tim Potter2000-11-041-1/+60
|
* Sync up with Tim's changes in applience-head for SACLs.Jeremy Allison2000-11-041-49/+44
| | | | Jeremy.
* Added John Reillys patch for error code returns from ↵Jeremy Allison2000-10-261-5/+7
| | | | | | | clean_up_printer_driver_strunct() calls. Jeremy.
* Sorry JF - no billable hours :-). I fixed the "stream of events" problemJeremy Allison2000-10-261-14/+42
| | | | | | | | | with PCL drivers. The problem was we were updating the changeid on every SETPRINTERDATA/DELETEPRINTERDATA call. We should not do this, we should just update the 'setprinter' called count. We update the changeid on calls to SETPRINTER/ADDPRINTER/ADDPRINTEREX etc. Also fixed the correct returning of the create time on printers. Jeremy.
* We already have a perfectly good next_token() function we should be usingJeremy Allison2000-10-251-6/+3
| | | | | | | instead of strtok - this fixes a bug with NT users with spaces in their names when using winbindd. Needs to be added to the other parse_lpXX functions (currently only added to lprng parsing code). Jeremy.
* John Reilly @ HP (who is a wonderful human being and *definately* needsJeremy Allison2000-10-251-54/+161
| | | | | | | | CVS commit access :-) has written a simple routine that peeks inside the MS PE printer driver file format and can tell if a driver is W2K or NT4.x. So we can now correctly return the driver version number. Hurrah ! JF - this is the code you always wanted ..... :-) :-). Jeremy.
* Removed null user checks to enable lanman print queue pausing and print jobTim Potter2000-10-181-4/+0
| | | | deleting.
* Fix for growing printing.tdb by adding check on job creation.Jeremy Allison2000-10-111-17/+50
| | | | | This also updates the printing.tdb db version to 2. Jeremy.
* Remove lpq as root fix - do this in print_job_start insteadJeremy Allison2000-10-111-28/+0
| | | | | as part of print queue length processing. Jeremy.
* Fixes to periodically scan printing.tdb in idle time and occasionallyJeremy Allison2000-10-101-1/+42
| | | | | | | on exit. Needed to fix printing.tdb from groving to 300Mb+ if being driven by smbclient clients that never ask for status... (effective DOS attack :-). Jeremy.
* Fixed Realloc memory fragmentation problems.Jeremy Allison2000-10-101-17/+57
| | | | Jeremy.
* got rid of tdb_writelock() and instead lock a chain. tdb_writelock()Andrew Tridgell2000-10-102-11/+14
| | | | is conceptually flawed
* Integrated support for NT and OS/2 lpq parsing. Code fromJeremy Allison2000-10-071-0/+163
| | | | | | | | | Jim McDonough Infoprint Manager Development Linux Technology Center IBM Boulder Jeremy.
* Restructuring of vfs layer to include a "this" pointer - can be an fsp orJeremy Allison2000-10-061-4/+4
| | | | | | | | | | | | | | | a conn struct depending on the call. We need this to have a clean NT ACL call interface. This will break any existing VFS libraries (that's why this is pre-release code). Andrew gets credit for this one :-) :-). In addition - added Herb's WITH_PROFILE changes - Herb - please examine the changes I've made to the smbd/reply.c code you added. The original code was very ugly and I have replaced it with a START_PROFILE(x)/END_PROFILE(x) pair using the preprocessor. Please check this compiles ok with the --with-profile switch. Jeremy.
* utils/smbcontrol.c: Fixes from Herb for interactive use.Jeremy Allison2000-09-291-1/+1
| | | | | printing/nt_printing.c: No C++ comments please :-). Jeremy.
* Fix from John Reilly for forms ordering problems.Jeremy Allison2000-09-281-12/+19
| | | | Jeremy.
* fix for IRIX 6.2 compiler errorHerb Lewis2000-09-261-1/+1
|
* Move towards getting W2k p&p to upload NT4.x drivers. Still doesn't work -Jeremy Allison2000-09-151-2/+67
| | | | | | | not sure why (JF - a glance at this would be appreciated). Removed code that JF objected to with enumprinterdata. Added translations to/from level 6 - but Win2k still not happy... hmmm... Jeremy.