summaryrefslogtreecommitdiffstats
path: root/source/passdb
Commit message (Collapse)AuthorAgeFilesLines
* r17161: sync files from SAMBA_3_0_23 branchGerald Carter2006-07-203-11/+52
|
* r16915: grab vl's fix for BUG 3915Gerald Carter2006-07-102-2/+7
|
* r16674: After removing each individual post-3.0.23rc3 change:Gerald Carter2006-06-292-3/+9
| | | | | | | | | | | | | | This pulls is what I considered safe fixes from SAMBA_3_0. This boiled down to either Klocwork fixes or obvious compiler warning fixes. I did not include any changes to fnuction signatures not the version change to the passdb API. Also pulled in the 3 nmbd fixes requested by Jeremy and the wildcard delete fix. This code will sit for a few days in the cooker and then become 3.0.23 if nothing blows up. I don't care how many more compile warning fixes people throw into SAMBA_3_0.
* r16438: sync up to r16433Gerald Carter2006-06-211-0/+13
|
* r16418: Pull in more Klocwork fixes (up to r16415)Gerald Carter2006-06-204-150/+23
|
* r16348: * merging changes from SAMBA_3_0 r16346Gerald Carter2006-06-191-4/+49
| | | | * updating release notes to match
* r16254: pulling klocwork fixes for 3.0.23rc3 (current up to r16251)Gerald Carter2006-06-154-474/+158
|
* r16175: sync up with SAMBA_3_0 to release (r16156)Gerald Carter2006-06-131-1/+1
|
* r16124: catch a couple of fixes from GuentherGerald Carter2006-06-091-2/+9
|
* r16104: Set version to 3.0.23rc2Gerald Carter2006-06-085-12/+45
| | | | | Bring release tree up to current 3.0 tree (svn merge -r15845:16103 $SVNURL/branches/SAMBA_3_0)
* r15837: starting sync up for 3.0.23rc1 (in sync with SAMBA_3_0 r15822)Gerald Carter2006-05-236-47/+57
|
* r15101: Little step towards getting Samba4 tdb into 3: tdb_lock_bystring ↵Volker Lendecke2006-04-172-5/+5
| | | | | | | | | does not have the timeout argument in Samba4. Add a new routine tdb_lock_bystring_with_timeout. Volker
* r15009: Add a check for NULLVolker Lendecke2006-04-091-0/+3
|
* r14868: I will not write code when changing to Daylight Savings Time.Gerald Carter2006-04-021-5/+10
| | | | | | | | | | | | | | | | I will not write code when changing to Daylight Savings Time. I will not write code when changing to Daylight Savings Time. I will not write code when changing to Daylight Savings Time. I will not write code when changing to Daylight Savings Time. I will not write code when changing to Daylight Savings Time. I will not write code when changing to Daylight Savings Time. I will not write code when changing to Daylight Savings Time. I will not write code when changing to Daylight Savings Time. ... Fix my brain dead inverted logic for turning winbindd on and off when run on a DC or when calling pdb functions from within winbindd.
* r14855: Various fixes:Gerald Carter2006-04-021-10/+8
| | | | | | | | * depreacte 'acl group control' after discussion with Jeremy and implement functionality as part of 'dos filemode' * fix winbindd on a non-member server to expand local groups * prevent code previously only used by smbd from blindly turning _NO_WINBINDD back on
* r14780: Fix coverity bug #272, null deref.Jeremy Allison2006-03-291-0/+8
| | | | Jeremy.
* r14758: Fix broken LDAP search filter.Günther Deschner2006-03-291-1/+1
| | | | Guenther
* r14756: Make smbpasswd -a root work for eDirectory where there is no "account"Günther Deschner2006-03-291-5/+18
| | | | | | structural objectclass. Guenther
* r14696: make pdb_find_backend_entry public (for use by an external "multi" ↵Jelmer Vernooij2006-03-241-3/+1
| | | | pdb backend)
* r14634: Many bug fixes thanks to train rides and overnight stays in airportsGerald Carter2006-03-222-22/+84
| | | | | | | | | | | | | | | | | | * Finally fix parsing idmap uid/gid ranges not to break with spaces surrounding the '-' * Allow local groups to renamed by adding info level 2 to _samr_set_aliasinfo() * Fix parsing bug in _samr_del_dom_alias() reply * Prevent root from being deleted via Samba * Prevent builting groups from being renamed or deleted * Fix bug in pdb_tdb that broke renaming user accounts * Make sure winbindd is running when trying to create the Administrators and Users BUILTIN groups automatically from smbd (and not just check the winbind nexted groups parameter value). * Have the top level rid allocator verify that the RID it is about to grant is not already assigned in our own SAM (retries up to 250 times). This fixes passdb with existing SIDs assigned to users from the RID algorithm but not monotonically allocating the RIDs from passdb.
* r14577: BUG Fixes:Gerald Carter2006-03-202-11/+9
| | | | | | * Add back in the import/export support to pdbedit * Fix segv in pam_smbpass * Cleanup some error paths in pdb_tdb and pdb_interface
* r14457: Add a few more special cases for RID 513 in the samr code.Gerald Carter2006-03-152-2/+32
| | | | | | Now that I know what all the requirements for this group are I can generalize the code some more and make it cleaner. But at least this is working with lusrmgr.msc on XP and 2k now.
* r14452: Sorry. Need more coffee....Gerald Carter2006-03-151-1/+1
| | | | * Fix sprintf() args when createing the group search filter.
* r14451: In order to get pdb_ldap searching for SID_NAME_ALIASGerald Carter2006-03-151-42/+16
| | | | | | | | | | | | | | groups in the ${MACHINESID} and S_1-5-32 domains correctly, I had to add a substr search on sambaSID. * add substr matching rule to OpenLDAP schema (we need to update the other schema as will since this is a pretty important change). Sites will need to - install the new schema - add 'indea sambaSID sub' to slapd.conf - run slapindex * remove uses of SID_NAME_WKN_GRP in pdb_ldap.c
* r14403: * modifies create_local_nt_token() to create a BUILTIN\AdministratorsGerald Carter2006-03-152-15/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | group IFF sid_to_gid(S-1-5-32-544) fails and 'winbind nested groups = yes' * Add a SID domain to the group mapping enumeration passdb call to fix the checks for local and builtin groups. The SID can be NULL if you want the old semantics for internal maintenance. I only updated the tdb group mapping code. * remove any group mapping from the tdb that have a gid of -1 for better consistency with pdb_ldap.c. The fixes the problem with calling add_group_map() in the tdb code for unmapped groups which might have had a record present. * Ensure that we distinguish between groups in the BUILTIN and local machine domains via getgrnam() Other wise BUILTIN\Administrators & SERVER\Administrators would resolve to the same gid. * Doesn't strip the global_sam_name() from groups in the local machine's domain (this is required to work with 'winbind default domain' code) Still todo. * Fix fallback Administrators membership for root and domain Admins if nested groups = no or winbindd is not running * issues with "su - user -c 'groups'" command * There are a few outstanding issues with BUILTIN\Users that Windows apparently tends to assume. I worked around this presently with a manual group mapping but I do not think this is a good solution. So I'll probably add some similar as I did for Administrators.
* r14103: Fix a memleak found by valgrind (!!)Volker Lendecke2006-03-091-0/+1
|
* r14102: Fix Coverity bug # 70Volker Lendecke2006-03-091-0/+4
|
* r14088: Fix Coverity bug #20. Don't deref possible null.Jeremy Allison2006-03-091-6/+9
| | | | Jeremy.
* r13979: We've dereferenced my_methods already, so there's no point in ↵Volker Lendecke2006-03-071-1/+1
| | | | | | | | checking for != NULL. Coverity #149. Volker
* r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison2006-03-071-7/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy.
* r13843: Merge in net sam provision and some pdb_ldap fixesSimo Sorce2006-03-051-82/+130
|
* r13791: Having S-1-1-0 show up in winbind lookupsid does not really make sense.Volker Lendecke2006-03-022-3/+18
| | | | Volker
* r13776: Merge in the editposix ldapsam optimizationSimo Sorce2006-03-012-109/+892
|
* r13765: Fix bug reported by jra. Don't check for a group SID when storingGerald Carter2006-03-011-0/+2
| | | | a user since we no longer pay any attention to the value.
* r13756: use samu_new() rather than calling talloc() directly.Gerald Carter2006-02-281-1/+1
|
* r13747: Fix the reference count for tdbsam_open() - on anJeremy Allison2006-02-281-5/+9
| | | | | | | | | upgrade it calls tdbsam_convert() which calls tdbsam_open() deep inside the init_sam_from_buffer_vX call. If the ref count hasn't been set yet then we will close the tdbsam reference in tdbsam_getsampwsid(). smbpasswd -a was core-dumping again :-). Jeremy
* r13729: Fix smbpasswd -xVolker Lendecke2006-02-271-13/+6
|
* r13728: No, we have not talked about this on irc less than 24h ago... ;-)Volker Lendecke2006-02-271-2/+2
|
* r13727: Fix a segfaultVolker Lendecke2006-02-271-1/+5
|
* r13711: * Correctly handle acb_info/acct_flags as uint32 not as uint16. Günther Deschner2006-02-276-40/+275
| | | | | | | | * Fix a couple of related parsing issues. * in the info3 reply in a samlogon, return the ACB-flags (instead of returning zero) Guenther
* r13704: Janitor for tpot.Jeremy Allison2006-02-271-50/+55
| | | | | | | | Jeremy ------------- Slightly smaller version of pdb_get_methods() patch. Turns out that callers to initialize_password_db() use the reload parameter so this has turned in to a smaller cleanup than I thought.
* r13693: More Solaris/LDAP fixes from Bjoern <bjoern@j3e.de>Volker Lendecke2006-02-261-1/+1
|
* r13683: Fix the 'valid users = +users' problem I introduced.Volker Lendecke2006-02-241-0/+19
| | | | Volker
* r13679: Commiting the rm_primary_group.patch posted on samba-technicalGerald Carter2006-02-247-330/+243
| | | | | | | | | | * ignore the primary group SID attribute from struct samu* * generate the primary group SID strictlky from the Unix primary group when dealing with passdb users * Fix memory leak in original patch caused by failing to free a talloc * * add wrapper around samu_set_unix() to prevent exposing the create BOOL to callers. Wrappers are samu_set_unix() and samu-allic_rid_unix()
* r13678: Remove unneeded bracesVolker Lendecke2006-02-241-5/+3
|
* r13622: Allow to rename machine accounts in a Samba Domain. This still uses theGünther Deschner2006-02-223-8/+14
| | | | | | | "rename user script" to do the rename of the posix machine account (this might be changed later). Fixes #2331. Guenther
* r13601: * Remove unused code from pdb_ldap.cGerald Carter2006-02-213-94/+11
| | | | | | | | | * Add a 'struct passwd *' to the struct samu for later reference (I know this may be controversial but its easily reverted which is is why I'm checking this is as a seaparate patch before I get too deep). * Remove unix_homedir from struct samu {} and update the pdb wrapper functions associated with it.
* r13600: Move functions local to tdbsam to pdb_tdb.cGerald Carter2006-02-212-391/+406
|
* r13593: consolidate pdb_set_sam_sids() into samu_set_unix() whichGerald Carter2006-02-211-116/+84
| | | | was the only place it was called from.
* r13590: * replace all pdb_init_sam[_talloc]() calls with samu_new()Gerald Carter2006-02-214-126/+54
| | | | * replace all pdb_{init,fill}_sam_pw() calls with samu_set_unix()