| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
Remove some useless arguments
|
|
|
|
| |
some double options and broke some parameters.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Make a new macro to help in this situation, and add memcpy() parinoia
Andrew Bartlett
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch enables the compile-time checking of strings assable by means of
sizeof(). (Original code had the configure check reversed).
This is extended to all safe_strcpy() users, push_string and pull_string,
as well as the cli and srv derivitives. There is an attempt to cap strings
at the end of the cli buffer, and clobber_region() of the speified length
(when not -1 :-).
Becouse of the way they are declared, the 'overmalloc a string' users of
safe_strcpy() have been changed to use overmalloc_safe_strcpy() (which skips
some of the checks).
This whole ball of mud worked fine, until I pulled out my 'fix' for our
statcache. When jeremy fixes that, we should be able to get back to testing
this stuff.
This patch also includes a 'marker' of the last caller to clobber_region (ie,
the function that called pstrcpy() that called clobber_region) to assist in
debugging problems that may have smashed the stack. This is printed at
smb_panic() time. (Original idea and patch by metze).
It also removes some unsused functions, and #if 0's some others that are
unused but probably should be used in the near future.
For now, this patch gives us some confidence on one class of trivial parsing
error in our code.
Andrew Bartlett
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
reason, during a Win2003 installation, when you select 'domain join' it sends
one machine name in the name exchange, and litraly 'machinename' during the
NTLMSSP login.
Also fix up winbindd's logfile handling, so that it matches smbd and nmbd.
(This helps me, by seperating the logs by pid).
Andrew Bartlett
|
|
|
|
|
|
|
| |
all perfectly legit - the region is an fstring in length, but might not
always be, and it is the last peice of code to fail my automated test.
Andrew Bartlett
|
|
|
|
|
|
| |
name being truncated... (either way, it's the correct thing to do).
Andrew Bartlett
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch makes Samba compile cleanly with -Wwrite-strings.
- That is, all string literals are marked as 'const'. These strings are
always read only, this just marks them as such for passing to other functions.
What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables). The rest
is just adding a lot of 'const'.
As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).
Andrew Bartlett
|
|
|
|
|
| |
named. Ensure we can query them.
Jeremy.
|
|
|
|
|
| |
these.
Jeremy.
|
| |
|
|
|
|
|
|
| |
can't create the socket.
Andrew Bartlett
|
|
|
|
|
| |
Found via a post from Arcady Chernyak <Arcady.Chernyak@efi.com>.
Jeremy.
|
|
|
|
|
| |
release.
Jeremy.
|
|
|
|
|
|
| |
dashes of const. This is a rather large check-in, some things may break.
It does compile though :-).
Jeremy.
|
|
|
|
|
|
|
|
| |
append writes.
(blessed by jra)
Andrew Bartlett
|
| |
|
|
|
|
|
|
|
|
|
| |
-V Version information
-n Set netbios name
-l Set directory to store log files in
-d Set debuglevel
-s Load specified configuration file
-O Set socket options
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
|
| |
in C
please note that:
if (! a & b)
is not the same as:
if (! (a & b))
|
|
|
|
|
| |
return empty NetServerEnum2 on port 445, but not on port 139.
Jeremy.
|
| |
|
|
|
|
| |
with non-const values - strsep not defined
|
|
|
|
|
| |
it inside an #ifdef HAVE_ADS to avoid the warning and breaking the
build. (-:
|
| |
|
|
|
|
|
|
| |
the new accessor functions.
Andrew Bartlett
|
|
|
|
| |
if you have an ADS DC.
|
| |
|
|
|
|
|
|
| |
when a PDC. The fix does not iterate over all WINS tags, which it
should do, but after having looked at doing that it gets *very* messy
to do with our current code base.
|
|
|
|
| |
samba-patches 898
|
|
|
|
| |
samba-patches 959
|
|
|
|
|
|
| |
(but assumes that 'myip' is indeed our local IP...)
Andrew Bartlett
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
server. The real problem is all the special cases we had for when we
are a wins server as opposed to when we are using a 'real' wins
server.
This patch removes the special cases. We now accept non-broadcast
packets from ourselves and we use ourselves as a wins server when we
are one. This gets rid of the special cases and simplifies things
quite a bit.
It all seems to work, but there are bound to be problems found later.
|
|
|
|
| |
server. We were rejecting them, leaving the name unregistered!
|
|
|
|
| |
(ie. check for lp_dns_proxy())
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now cope wiith multiple WINS groups and multiple failover servers
for release and refresh as well as registration. We also do the regitrations
in the same fashion as W2K does, where we don't try to register the next
IP in the list for a name until the WINS server has acked the previos IP.
This prevents us flooding the WINS server and also seems to make for much
more reliable multi-homed registration.
I also changed the dead WINS server code to mark pairs of IPs dead,
not individual IPs. The idea is that a WINS server might be dead from
the point of view of one of our interfaces, but not another, so we
need to keep talking to it on one while moving onto a failover WINS
server on the other interface. This copes much better with partial
LAN outages and weird routing tables.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
accept an extended syntax for 'wins server' like this:
wins server = group1:192.168.2.10 group2:192.168.3.99 group1:192.168.0.1
The tags before the IPs don't mean anything, they are just a way of
grouping IPs together. If you use the old syntax (ie. no ':') then
an implicit group name of '*' is used. In general I'd recommend people
use interface names for the group names, but it doesn't matter much.
When we register in nmbd we try to register all our IPs with each group
of WINS servers. We keep trying until all of them are registered with
every group, falling back to the failover WINS servers for each group
as we go.
When we do a WINS lookup we try each of the WINS servers for each group.
If a WINS server for a group gives a negative answer then we give up
on that group and move to the next group. If it times out then
we move to the next failover wins server in the group.
In either case, if a WINS server doesn't respond then we mark it dead
for 10 minutes, to prevent lengthy waits for dead servers.
|
|
|
|
|
|
| |
unicast subnet, so remove that parameter. That frees up userdata so I
can start using it to indicate which wins server tag we are
registering (more about wins 'tags' later ...)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gives us a good grounding to properly support multiple wins servers
for different interfaces (which will be coming soon ...)
- fixed our wins registration failover code to actually do failover!
We were not trying to register with a secondary wins server at all
when the primary was down. We now fallback correctly.
- fixed the multi-homed name registration packets so that they work
even in a non-connected network (ie. when one of our interfaces is not
routable from the wins server. Yes, this really happens in the real
world).
|
|
|
|
|
| |
interfaces yet. Instead of giving up, nmbd will now wait for some
interfaces to appear
|
| |
|