| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
daemon. Re-write core of POSIX locking logic. Jeremy.
(cherry picked from commit faf7197b3b4ac9fefeb0fca31a888c9e84bed92f)
|
|
|
|
| |
(cherry picked from commit a0e9521b306a7e83d09de4616a66b49d259f0bbc)
|
|
|
|
| |
(cherry picked from commit 4955e1610af3086cc7e8d0344313a124b23a4e31)
|
|
|
|
|
|
|
|
| |
To me "fill_share_mode_lock failed" is a "can't happen" alert. There is
however a perfectly valid case in get_file_infos() when the file is not open.
Change the corresponding debug message to level 10 and explain more.
(cherry picked from commit 74efc72bca5707ff35df9282c843d62c4cf331c3)
|
|
|
|
|
| |
Jeremy.
(cherry picked from commit ddaa1bae7567c81fb8e478c439bb970edab2f9c3)
|
|
|
|
|
| |
Jeremy.
(cherry picked from commit 44ab658b6d80c66f20d80aede7fc7cd2b9a941b1)
|
|
|
|
|
| |
Jeremy.
(cherry picked from commit da1852f65188efc559738c2e5da295b702ad4619)
|
|
|
|
|
|
| |
This second patch cleans up by removing all of the code that is made
obsolete by the first patch. It should cause no functional changes.
(cherry picked from commit c39c35f3e67a726c6464c1497e46fe7a2eb3dc77)
|
|
|
|
|
| |
Jeremy.
(cherry picked from commit 7150f8e89c93be7d122e19f650522be591544611)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ok, here's the fix for the write times breakage
with the new tests in S4 smbtorture.
The key is keeping in the share mode struct
the "old_file_time" as the real write time,
set by all the write and allocation calls,
and the "changed_write_time" as the "sticky"
write time - set by the SET_FILE_TIME calls.
We can set them independently (although I
kept the optimization of not setting the
"old_file_time" is a "changed_write_time"
was already set, as we'll never see it.
This allows us to update the write time
immediately on the SMBwrite truncate case,
SET_END_OF_FILE and SET_ALLOCATION_SIZE calls,
whilst still have the 2 second delay on the
"normal" SMBwrite, SMBwriteX calls.
I think in a subsequent patch I'd like to
change the name of these from "old_file_time"
to "write_time" and "changed_write_time" to
"sticky_write_time" to make this clearer.
I think I also fixed a bug in Metze's original
code in that once a write timestamp had been
set from a "normal" SMBwriteX call the fsp->update_write_time_triggered
variable was set and then never reset - thus
meaning the write timestamp would never get
updated again on subsequent SMBwriteX's.
The new code checks the update_write_time_event
event instead, and doesn't update is there's
an event already scheduled.
Metze especially, please check this over for
your understanding.
Jeremy.
(cherry picked from commit aff490ef3b32b3bb2c11cf35ed3fa0272178da3f)
|
|
|
|
|
| |
Patch successfully tested by Christoph Kaegi <kaph@zhaw.ch>, thanks.
(cherry picked from commit 9f8df16f476c49da85000b7365c8a6e33b8b71fc)
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
| |
being (correctly) used in the can_read/can_write checks for hide unreadable/unwritable
and this is more properly done using the functions in smbd/file_access.c.
Preparing to do NT access checks on all file access.
Jeremy.
|
|
|
|
|
|
| |
Wrap lines and remove trailing space.
Michael
|
|
|
|
|
|
| |
The errno is handed up through the VFS layer to the callers.
Michael
|
|
|
|
|
|
|
|
| |
Now that it is inside the vfs layer, this function should
not alter the fsp (i.e. set fsp->fh->fd = -1) anymore.
That belongs above the vfs layer.
Michael
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This hides the pending close fds from the outside. Call order
of SMB_VFS_CLOSE is reversed. Originally, it was:
fd_close -> fd_close_posix -> SMB_VFS_CLOSE -> close
And now it is:
fd_close -> SMB_VFS_CLOSE -> fd_close_posix -> close
This is in preparation of removing the fd parameter
from the SMB_VFS_CLOSE function. But it is also the right
place for the pending close calls anyways.
Michael
|
|
|
|
|
| |
seem to be valid (vl - feel free to confirm).
Jeremy.
|
|
|
|
|
|
|
|
| |
get_file_infos()
This means we need to fetch the record only once.
metze
|
|
|
|
|
|
|
|
|
| |
This is needed to implement the strange write time update
logic later. We need to store 2 time timestamps to
distinguish between the time the file system had before
the first client opened the file and a forced timestamp update.
metze
|
| |
|
| |
|
|
|
|
|
| |
(http://samba.org/~tridge/3_0-ctdb)
Signed-off-by: Alexander Bokovoy <ab@samba.org>
|
|
|
|
| |
We now refer directly to the file name in the tdb data, so don't delete it.
|
| |
|
| |
|
| |
|
|
|
|
| |
Michael
|
| |
|
|
|
|
| |
Michael
|
| |
|
|
|
|
| |
Michael
|
| |
|
|
|
|
|
|
| |
locking.c:open_read_only was unused
don't export the silly boolean flag locking_init(bool read_only)
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
| |
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
|
|
|
|
| |
This removes file_id_string_static and file_id_string_static2
|
|
|
|
| |
Patch from Ofir Azoulay <Ofir.Azoulay@expand.com> -- thanks
|
|
|
|
| |
This has been superseded by the "tdb_hashsize:<tdbname>" parameter
|
|
|
|
|
|
| |
by hand
metze
|
| |
|
|
|
|
|
|
|
|
| |
fixed a bug with dead share mode entries
jra: please tell me if it's ok to merge this to 3_2_0.
metze
|
|
|
|
|
|
| |
POSIX locking. We can't do lock counts with POSIX,
so stop counting if we get a POSIX lock request.
Jeremy.
|
| |
|
| |
|
| |
|