summaryrefslogtreecommitdiffstats
path: root/source/locking
Commit message (Collapse)AuthorAgeFilesLines
* r22650: sync up with SMABA_3_0_25 as of svn r22649Gerald Carter2007-05-032-4/+9
|
* r21889: * Pull from SAMBA-3_0_25 svn r21888Gerald Carter2007-03-202-7/+47
| | | | * Set version to 3.0.25pre2
* r21585: Start syncing the monster that will become 3.0.25pre1Gerald Carter2007-02-283-1009/+1126
| | | | | | | | Still todo: * release notes * few minor outstanding patches * additional idmap man pages
* r17094: merge fixes for 3.0.23aGerald Carter2006-07-171-10/+9
|
* r16674: After removing each individual post-3.0.23rc3 change:Gerald Carter2006-06-291-1/+1
| | | | | | | | | | | | | | This pulls is what I considered safe fixes from SAMBA_3_0. This boiled down to either Klocwork fixes or obvious compiler warning fixes. I did not include any changes to fnuction signatures not the version change to the passdb API. Also pulled in the 3 nmbd fixes requested by Jeremy and the wildcard delete fix. This code will sit for a few days in the cooker and then become 3.0.23 if nothing blows up. I don't care how many more compile warning fixes people throw into SAMBA_3_0.
* r16472: final pass for 3.0.23rc3 I think. Current with SAMBA_3_0 r16471Gerald Carter2006-06-221-9/+14
|
* r16348: * merging changes from SAMBA_3_0 r16346Gerald Carter2006-06-192-4/+3
| | | | * updating release notes to match
* r16104: Set version to 3.0.23rc2Gerald Carter2006-06-081-1/+1
| | | | | Bring release tree up to current 3.0 tree (svn merge -r15845:16103 $SVNURL/branches/SAMBA_3_0)
* r15837: starting sync up for 3.0.23rc1 (in sync with SAMBA_3_0 r15822)Gerald Carter2006-05-232-20/+113
|
* r15083: Using talloc with destructors is nice and all, but in thisJeremy Allison2006-04-132-21/+17
| | | | | | | case it's in a performace critical path and it *hurts* us. Go back to plain malloc/free with an explicit destructor call. Jeremy.
* r15060: The brlock code gets called a lot. Ensure we keep theJeremy Allison2006-04-121-29/+13
| | | | | | key around while we're using it - saves many calls to locking_key() (now deleted). Jeremy.
* r15026: Fix warning until POSIX locking finished.Jeremy Allison2006-04-101-2/+1
| | | | Jeremy.
* r15018: Merge Volker's ipc/trans2/nttrans changes overJeremy Allison2006-04-103-449/+1247
| | | | | | | | into 3.0. Also merge the new POSIX lock code - this is not enabled unless -DDEVELOPER is defined. This doesn't yet map onto underlying system POSIX locks. Updates vfs to allow lock queries. Jeremy.
* r14763: Add a new tuning parameter, open files database hash size,Jeremy Allison2006-03-292-3/+6
| | | | | | | | | this allows us to experiment with ensuring the tdb hash size for our open files and locking db are appropriately sized. Make the hash size larger by default (10007 instead of 1049) and make the locking db hash size the same as the open file db hash size. Jeremy.
* r14703: Clarify the return codes for the POSIX locking case. ThisJeremy Allison2006-03-251-2/+6
| | | | | was confusing. Jeremy.
* r14428: Call fill_share_mode_entry with NO_OPLOCK instead of 0.James Peach2006-03-151-3/+3
|
* r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison2006-03-072-16/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy.
* r13571: Replace all calls to talloc_free() with thye TALLOC_FREE()Gerald Carter2006-02-201-7/+7
| | | | macro which sets the freed pointer to NULL.
* r13412: Don't use arbitrary uint32 size for uid and gid storage. UseJeremy Allison2006-02-091-23/+22
| | | | | | correct system size. Fixed a bug that was accidentally introduced by use of uint32 - uid was stored twice, not uid and gid. Jeremy.
* r13329: Fix libsmbsharemodes.so to work with the stored delete token.Jeremy Allison2006-02-041-18/+0
| | | | | | Less trouble than I thought plus it didn't need an interface change (thank goodness !). Jeremy.
* r13294: Fix basic delete on close tests - don't forget to tellJeremy Allison2006-02-021-5/+10
| | | | | the data struct how big the token is... :-). Jeremy.
* r13293: Rather a big patch I'm afraid, but this should fix bug #3347Jeremy Allison2006-02-021-15/+142
| | | | | | | | by saving the UNIX token used to set a delete on close flag, and using it when doing the delete. libsmbsharemodes.so still needs updating to cope with this change. Samba4 torture tests to follow. Jeremy.
* r13274: Fix for bug #3467. Not a show stopper.Jeremy Allison2006-02-011-3/+17
| | | | | | jason qian <jason@infrant.com> was a *fantastic* help in tracking this down. Jeremy.
* r13198: Fix issues exposed by Jerry's testing on 64-bit SolarisJeremy Allison2006-01-271-22/+0
| | | | | (I hope). Separate 3.0.21b patch sent to Jerry. Jeremy.
* r13194: Don't do extra memcpy's unless we're asked to.Jeremy Allison2006-01-271-1/+5
| | | | Jeremy.
* r13192: Fix up alignment issues when printing share modeJeremy Allison2006-01-271-4/+8
| | | | | | entries. Add paranioa to debug so we know when an entry is unused. Jeremy.
* r13110: remove an invalid debug message about call get_share_mode_lock() ↵Gerald Carter2006-01-241-1/+0
| | | | with a NULL service path and fname (we do it all the time internally)
* r12877: Stop passing structs around in smb messages, insteadJeremy Allison2006-01-121-7/+10
| | | | | | | | | always linearize into little-endian. Should fix all Solaris issues with this, plus provide a cleaner base moving forward for cluster-aware Samba where smbd's can communicate across different compilers/architectures (eventually these message will have to go cross-machine). Jeremy.
* r12234: Reduce the race condition for renames by holding the lockJeremy Allison2005-12-141-1/+5
| | | | | | longer. Instigated by complaints on the fix for #3303 from SATOH Fumiyasu <fumiyas@miraclelinux.com>. Jeremy.
* r12221: Fix error code paths that can potentially leave a dangling lock.Jeremy Allison2005-12-141-2/+13
| | | | Jeremy.
* r12213: Final fix for #3303 - send rename messages to smbd'sJeremy Allison2005-12-131-3/+53
| | | | | | | | that have open file handles to allow them to correctly implement delete on close. There is a further correctness fix I'm intending to add to this to cope with different share paths, but not right now... Jeremy.
* r12203: Add the share path into the sharemode db. This involvesJeremy Allison2005-12-121-18/+66
| | | | | | | | | | revving the minor version number for libsmbsharemodes (we now have a new _ex interface that takes the share path as well as the filename). Needed for #3303. Some code written by SATOH Fumiyasu <fumiya@samba.gr.jp> included in the changes to locking/locking.c. The smbstatus output is a bit of a mess and needs overhauling... Jeremy.
* r11435: Allow the hash size of the tdb open (locking) databaseJeremy Allison2005-11-011-3/+3
| | | | | | | | to be set in local.h. Change from the default (131) to another prime (1049). Should this be an smb.conf tunable parameter based on the number of open file descriptors available ? If so what scaling factor ? More tests to follow. Jeremy.
* r11341: Put directory opens into the share mode db so weJeremy Allison2005-10-271-1/+2
| | | | | | | | can treat them similarly to file opens (delete on close, share mode violations etc.). This fixes bug #3216 I will up the default hash size on the locking db in a later commit as this means more entries. Jeremy.
* r10656: BIG merge from trunk. Features not copied overGerald Carter2005-09-302-761/+467
| | | | | | | * \PIPE\unixinfo * winbindd's {group,alias}membership new functions * winbindd's lookupsids() functionality * swat (trunk changes to be reverted as per discussion with Deryck)
* r8219: Merge the new open code from HEAD to 3.0. Haven't yet run the tortureJeremy Allison2005-07-082-68/+90
| | | | | | | | | tests on this as it's very late NY time (just wanted to get this work into the tree). I'll test this over the weekend.... Jerry - in looking at the difference between the two trees there seem to be some printing/ntprinting.c and registry changes we might want to examine to try keep in sync. Jeremy.
* r7975: One more tidyup to ensure we're using "struct posix_lock".Jeremy Allison2005-06-281-1/+2
| | | | Jeremy.
* r7972: Tidy up the posix locking in memory db code whilst I'm waiting for jhtJeremy Allison2005-06-281-20/+21
| | | | | to get back to me with a backtrace. Jeremy.
* r6594: Fix silly typo causing tdb to be freed twice.Jeremy Allison2005-05-031-1/+1
| | | | Jeremy.
* r6543: Fix EDEADLCK problem with deferred open calls. Problem found byJeremy Allison2005-05-011-13/+33
| | | | | "Hu, David J" <david.hu@hp.com> Jeremy.
* r6502: add LOCKING debug class - pull PRINTINGDB class definition from trunkHerb Lewis2005-04-273-0/+9
| | | | so our numbers don't get out of sync
* r5634: Fix 64-bit overflow problems found by BlueArc torture tester.Jeremy Allison2005-03-031-9/+0
| | | | | | We still have a few strange bugs with 64-bit locking values. I will get traces. Jeremy.
* r5625: Reformat (tidy).Jeremy Allison2005-03-021-4/+4
|
* r4143: Make strict locking an enum. Auto means use oplock optimization.Jeremy Allison2004-12-111-9/+16
| | | | Jeremy.
* r4121: Optimisation from Nadav Danieli <nadavd@exanet.com>. If we're oplocked,Jeremy Allison2004-12-091-1/+9
| | | | | short circuit some is_locked() tests. Jeremy.
* r4108: As check_self is *always* False in every invokation, remove theJeremy Allison2004-12-092-16/+8
| | | | | logic for it. We still pass Samba4 RAW-LOCK test. Jeremy.
* r4088: Get medieval on our ass about malloc.... :-). Take control of all our ↵Jeremy Allison2004-12-073-11/+10
| | | | | | | | | allocation functions so we can funnel through some well known functions. Should help greatly with malloc checking. HEAD patch to follow. Jeremy.
* r3120: Fix bug #1955 reported by Love <lha@stacken.kth.se>. Inconsistent ↵Jeremy Allison2004-10-211-3/+3
| | | | | | error return. Jeremy.
* r3050: Steal from Samba4 :-). Make us pass most of the new lock tests ↵Jeremy Allison2004-10-181-17/+56
| | | | | | | (except for the cancel lock which I have to add). Jeremy.
* r3008: when checking for the existance of a lock we are only doing a singleAndrew Tridgell2004-10-171-3/+0
| | | | | tdb call, so there is no need to get the chainlock. This reduces the number of tdb locking calls made on file IO
generated by cgit (git 2.34.1) at 2025-09-25 10:53:06 +0000