| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
* Set VERSION to 3.0.25rc1
* Update release notes.
|
|
|
|
| |
* Set version to 3.0.25pre2
|
|
|
|
|
| |
for 3.0.25pre1 unless something blows up)
* Update release notes some more
|
|
|
|
|
|
|
|
| |
Still todo:
* release notes
* few minor outstanding patches
* additional idmap man pages
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
to warrant one)
|
| |
|
|
|
|
|
|
| |
* internal_resolve_name() fix
* time fixes
* NULL deref fixes
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
more
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pulls is what I considered safe fixes from SAMBA_3_0.
This boiled down to either Klocwork fixes or obvious compiler
warning fixes. I did not include any changes to fnuction
signatures not the version change to the passdb API.
Also pulled in the 3 nmbd fixes requested by Jeremy
and the wildcard delete fix.
This code will sit for a few days in the cooker and then
become 3.0.23 if nothing blows up. I don't care how many
more compile warning fixes people throw into SAMBA_3_0.
|
| |
|
|
|
|
|
|
|
| |
svn merge -r16435:16458 $SVNURL/branches/SAMBA_3_0
* note that I've skipped jra's change to the share_mode_entry
since it si not critical for release. Maybe for 3.0.23a
|
| |
|
|
|
|
| |
* updating release notes to match
|
| |
|
| |
|
|
|
|
|
| |
Bring release tree up to current 3.0 tree
(svn merge -r15845:16103 $SVNURL/branches/SAMBA_3_0)
|
| |
|
| |
|
|
|
|
|
|
| |
With this change (and setting lanman auth = no in smb.conf)
we have *identical* NTLMSSP flags to W2K3 in SPNEGO auth.
Jeremy
|
|
|
|
|
| |
call.
Jeremy.
|
|
|
|
|
|
|
|
| |
into 3.0. Also merge the new POSIX lock code - this
is not enabled unless -DDEVELOPER is defined.
This doesn't yet map onto underlying system POSIX
locks. Updates vfs to allow lock queries.
Jeremy.
|
|
|
|
|
|
|
|
| |
Implement enhancement request 3505. Two additional features are added here.
There is now a method of saving an opaque user data handle in the smbc_
context, and there is now a way to request that the context be passed to the
authentication function. See examples/libsmbclient/testbrowse.c for an example
of using these features.
|
|
|
|
| |
Guenther
|
|
|
|
|
|
| |
Might need to rework prs_dcerpc_status().
Guenther
|
|
|
|
|
|
| |
kerberos_kinit_password_ext provides access to more options.
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
|
| |
implicit function contract explicit.
Jeremy.
|
|
|
|
|
|
| |
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
|
|
|
|
|
| |
Free grp_sid and owner_sid before returning. Also, only allow one group
or owner.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
their existence
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Thanks,
Volker
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
|