| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
The translate_name() used by cli_session_setup_spnego() cann rely
Winbindd since it is needed by the join process (and hence before
Winbind can be run).
|
| |
|
|
| |
3.2.0pre1
|
| |
|
|
|
|
| |
Also add dns query functions to find GCs and DCs by GUID.
Guenther
|
| |
|
|
|
|
| |
NTSTATUS.
Guenther
|
| | |
|
| |
|
|
| |
Jeremy.
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
the stored client sitename with the sitename from each sucessfull CLDAP
connection.
Guenther
|
| |
|
|
|
|
| |
for a PDC.
Guenther
|
| |
|
|
|
|
|
|
|
| |
site support in a network where many DC's are down.
I heard via Volker there is still a bug w.r.t the
wrong site being chosen with trusted domains but
we'll have to layer that fix on top of this.
Gd - complain if this doesn't work for you.
Jeremy.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
* When using a krb5 session setup, we don't fill in the server_name
string the clis_state struct. So call saf_store() after we
have the short domain name in the lsa_query_inof_policy code.
* Remove unused server string in saf_delete()
|
| |
|
|
|
|
|
| |
Merge back the winbindd changes from SAMBA_3_0
to a release branch. This compiles, but hasn't
been valgrinded or tested. That will come...
Jeremy.
|
| |
|
|
| |
Guenther
|
| |
|
|
|
|
|
| |
context was created but never destroyed. Jerry,
you might want to grab this for 3.0.23c. Wonder
why none of the static checkers picked this up.
Jeremy.
|
| |
|
|
|
| |
do what it's supposed to.
Jeremy.
|
| |
|
|
|
|
|
| |
error. Fix our DNS SRV lookup code to deal with multi-homed hosts.
We were noly remembering one IP address per host from the Additional
records section in the SRV response which could have been an unreachable
address.
|
| |
|
|
| |
use the generic IP list sort in get_sorted_dc_list().
|
| |
|
|
|
|
|
|
|
|
| |
Original message :
fixed a bug which caused resolve_ads() to spin forever if one of the
DCs isn't resolvable in DNS. The fix is to leave that DC out of the
returned list of DCs. I think the original code intended that anyway,
just didn't quite get it right ('i' wasn't incremented in that code
path, so the loop didn't terminate)
|
| | |
|
| |
|
|
|
|
| |
Thanks,
Volker
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
|
| |
|
|
|
| |
think is a direct bug, but some code that needs clarification :-).
Jeremy.
|
| |
|
|
| |
Jeremy.
|
| |
|
|
| |
Jeremy.
|
| | |
|
| |
|
|
|
|
| |
safe for using our headers and linking with C++ modules. Stops us
from using C++ reserved keywords in our code.
Jeremy
|
| |
|
|
|
|
|
|
|
| |
allocation
functions so we can funnel through some well known functions. Should help greatly with
malloc checking.
HEAD patch to follow.
Jeremy.
|
| |
|
|
|
|
|
|
| |
simultaeneously to all
DCs found. The first one to reply wins.
Volker
|
| |
|
|
| |
really didn't
|
| |
|
|
| |
Volker
|
| | |
|
| |
|
|
| |
reuse when filling in the spolss replies (also gets rid of get_called_name()
|
| |
|
|
|
|
| |
Meadows" <jameadows@webopolis.com>.
Jeremy.
|
| | |
|
|
|
metze
|
