summaryrefslogtreecommitdiffstats
path: root/source/libsmb/libsmbclient.c
Commit message (Collapse)AuthorAgeFilesLines
* r24980: - Use the formal syntax for calling functions through pointers. ↵Derrell Lipman2007-09-061-52/+56
| | | | | | | | | I've wanted to make this change for ages, but now with the issue of "open" requiring it, this is the time to just do all of them. Derrell
* r24968: Fwd port "open" patchSimo Sorce2007-09-051-2/+2
|
* r24865: - Correct failure of libsmbclient against a version of Windows found ↵Derrell Lipman2007-09-011-24/+2
| | | | | | | | | | | | | | | | | | | | on a NAS device. The device resets a NBT connection on port 139 when it receives a NetBIOS keepalive request. That request should be supported when NetBIOS is in use; Windows is behaving badly. libsmbclient needs a way to determine if a connection is still alive, and was using a NetBIOS keepalive request if port 139 was in use (on the assumption that it was probably NBT), and getpeername() when port 139 was not being used (assuming naked transport). This patch simplifies the code by exclusively using getpeername() to check whether a connection is still alive. The NetBIOS keepalive request is optional anyway (with preference being given to using TCP mechanisms for the same purpose), so this should be both simpler and more reliable. Derrell
* r24750: Fix one more caller of name_resolve_bcast().Michael Adam2007-08-281-1/+3
| | | | Michael
* r24544: Apply missing portion of correction for bug 4750Derrell Lipman2007-08-181-0/+5
|
* r24465: - Sort ACEs according to http://support.microsoft.com/kb/269175 so thatDerrell Lipman2007-08-151-10/+72
| | | | | | | Windows Explorer doesn't complain about the order (and so that they get interpreted properly). Derrell
* r24460: - Removing all ACEs was causing removal of the DACL entirely. ↵Derrell Lipman2007-08-151-4/+0
| | | | | | | | | | | | | | | Win2000 ignored the request, presumably due to the PROTECTED flag not being set. Setting that flag (in make_sec_desc()) has much wider implications than just to libsmbclient, so instead of modifying that, we'll remove security descriptors by setting the number of ACEs to zero. At some point, we might want to look into whether we should actually be setting the PROTECTED flag in the DACL. Reference http://www.microsoft.com/technet/prodtechnol/windows2000serv/reskit/distrib/dsce_ctl_qxju.mspx?mfr=true Derrell
* r24411: - I got tricked by function naming. Contrary to what seemed obvious ↵Derrell Lipman2007-08-141-4/+0
| | | | | | | | | | | | | to me, prs_mem_free() is not the function to be called to free memory allocated by prs_alloc_mem(). I've added a comment so others may not get bitten too. - Remove incorrect memory free calls added yesterday to replace SAFE_FREE. The memory is actually now on a talloc context, so gets freed by the caller when that context is freed. We don't need to free it iternally. Derrell
* r24389: - ACL retrieval provided incomplete information because the buffer ↵Derrell Lipman2007-08-141-9/+22
| | | | | | | | | | | | | | | | | | | | | | | pointer was incremented too far in some circumstances. In these cases, only the first of multiple concatenated strings would be seen. - Working on bug 4649 pertaining to delete an ACL, this fixes the reported crash. It appears to have been an incomplete switchover from malloc to talloc, as the memory was still being freed with SAFE_FREE. Deleting ACLs still doesn't work. Although a valid request is sent to the server and a SUCCESS response is returned, the method that's used in libsmbclient for deleting ACLs seems to be incorrect. In looking at the samba4 torture tests, it appears that we should be turning on the INHERIT flag if we want to delete the ACL. (I could use some assistance on the proper flags to send, from anyone familiar with this stuff.) - Apply patch from SATOH Fumiyasu to fix bug 4750. smbc_telldir_ctx() was not returning a value useful to smbc_lseekdir_ctx(). Derrell
* r23784: use the GPLv3 boilerplate as recommended by the FSF and the license textAndrew Tridgell2007-07-101-2/+1
|
* r23780: Find and fix more GPL2 -> GPL3.Jeremy Allison2007-07-091-1/+1
| | | | Jeremy.
* r23627: Allow to pass down the lookup-level to rpccli_lsa_lookup_names().Günther Deschner2007-06-271-1/+1
| | | | Guenther
* r23554: Fix bug #4711 by makeing cli_connect return an NTSTATUS.Jeremy Allison2007-06-201-8/+11
| | | | | Long overdue fix.... Jeremy.
* r23003: - Fix but #4634. Type of the size parameter to getpeername was wrong.Derrell Lipman2007-05-181-1/+1
|
* r22917: - Fixes bug 4599. A missing <code>if</code> statement forced ↵Derrell Lipman2007-05-151-4/+8
| | | | | | | | | | | | subseqeuent attempts to set attributes to fail. - I also noticed that missing attributes were setting an invalid return string by getxattr(), e.g. if there was not group, the return string had "GROUP:;" instead of excluding the GROUP attribute entirely as it should. The big problem with the way it was, is that the string could not then be passed to setxattr() and parsed.
* r22851: - Fixes bug 4601. smbc_getxattr() would not, in one case, properly ↵Derrell Lipman2007-05-141-1/+1
| | | | | | return the required size of a buffer needed to contain the extended attributes.
* r21937: Merge in changes from SAMBA_3_0 that should haveJeremy Allison2007-03-221-9/+38
| | | | | | been done for 3.0.25 pre-release. Janitor for libsmbclient maintainer :-(. Jeremy.
* r21768: Fix the client dfs code such that smbclient canJeremy Allison2007-03-081-15/+0
| | | | | | | | | process deep dfs links (ie. links that go to non root parts of a share). Make the directory handling conanonical in POSIX and Windows pathname processing. dfs should not be fully working in client tools. Please bug me if not. Jeremy.
* r21420: Looks big, but isn't really. Move internal namesJeremy Allison2007-02-181-41/+41
| | | | | | | | | of SEC_DESC over from grp_owner -> group_owner, ace -> aces and info.mask -> mask. Makes it *much* easier to move code within branches as they're now referring to the same names for the same things (which is what the NDR code also uses). Jeremy.
* r20426: Janitor for Volker....Jeremy Allison2006-12-311-5/+8
| | | | | | Jeremy. "Fix a couple of Coverity errors in one run, this was a potential NULL dereference"
* r20267: fix more no previous prototype warningsHerb Lewis2006-12-201-0/+3
|
* r19814: Fix 'make everything build'Gerald Carter2006-11-211-47/+56
| | | | | | | The only major remaining pieces that are not being merged are: * The IDL work * The security descriptor merge.
* r19810: more merge work....does not compile currently. Working on smbd mergeGerald Carter2006-11-211-189/+204
|
* r19806: merge time.c changesGerald Carter2006-11-201-146/+464
|
* r19517: Fix libsmbclient bug with Konqueror and NetApp filersJeremy Allison2006-10-311-1/+9
| | | | | | that need a leading / in OpenAndX calls. Should be in 3.0.23d (got missed). Jeremy.
* r17761: Handle times consistently across all client utils.Jeremy Allison2006-08-231-2/+2
| | | | | Fixes bugs reported in libsmbclient. Jeremy.
* r16418: Pull in more Klocwork fixes (up to r16415)Gerald Carter2006-06-201-1/+3
|
* r16348: * merging changes from SAMBA_3_0 r16346Gerald Carter2006-06-191-0/+4
| | | | * updating release notes to match
* r14664: r13868@cabra: derrell | 2006-03-22 17:04:30 -0500Derrell Lipman2006-03-221-14/+89
| | | | | | | | Implement enhancement request 3505. Two additional features are added here. There is now a method of saving an opaque user data handle in the smbc_ context, and there is now a way to request that the context be passed to the authentication function. See examples/libsmbclient/testbrowse.c for an example of using these features.
* r14418: Try and fix Coverity #39 and #40 by making theJeremy Allison2006-03-151-2/+10
| | | | | implicit function contract explicit. Jeremy.
* r14279: Fix coverity #86, 87, 88, 89: Jim McDonough2006-03-131-10/+27
| | | | | Free grp_sid and owner_sid before returning. Also, only allow one group or owner.
* r14241: Fix Coverity bug # 146Volker Lendecke2006-03-121-1/+3
|
* r14236: Fix Coverity bug # 90Volker Lendecke2006-03-121-0/+1
|
* r14235: Fix Coverity bug # 91Volker Lendecke2006-03-121-0/+12
|
* r14234: Fix Coverity bug # 93Volker Lendecke2006-03-121-0/+1
|
* r14158: Fix coverity CID #147 -- do not dereference pointers before checking ↵Alexander Bokovoy2006-03-101-2/+4
| | | | their existence
* r13571: Replace all calls to talloc_free() with thye TALLOC_FREE()Gerald Carter2006-02-201-1/+1
| | | | macro which sets the freed pointer to NULL.
* r13495: Derell, I'm removing that double setup_logging(), just a typo.Günther Deschner2006-02-141-1/+0
| | | | Guenther
* r13316: Let the carnage begin....Gerald Carter2006-02-031-10/+3
| | | | Sync with trunk as off r13315
* r13216: r12422@cabra: derrell | 2006-01-28 23:57:35 -0500Derrell Lipman2006-01-291-33/+0
| | | | | | | Fix cli_setpathinfo() to actually do what it's supposed to. Also, get rid of some apparently drug-induced code to deal with create time which isn't being manipulated anyway.
* r13214: r12420@cabra: derrell | 2006-01-28 19:10:58 -0500Derrell Lipman2006-01-291-44/+57
| | | | | | | | | | | This should fix bug #3446. - The authentication domain provided an an SMB URL was being ignored. This patch fixes that. - There were a number of places where string copies were not being confirmed to be properly null-terminated. Now, all string copies in libsmbclient.c are properly null-terminated.
* r13212: r12414@cabra: derrell | 2006-01-28 17:52:17 -0500Derrell Lipman2006-01-281-3/+3
| | | | | | | | | | | | lp_load() could not be called multiple times to modify parameter settings based on reading from multiple configuration settings. Each time, it initialized all of the settings back to their defaults before reading the specified configuration file. This patch adds a parameter to lp_load() specifying whether the settings should be initialized. It does, however, still force the settings to be initialized the first time, even if the request was to not initialize them. (Not doing so could wreak havoc due to uninitialized values.)
* r12579: r12122@cabra: derrell | 2005-12-29 12:03:00 -0500Derrell Lipman2005-12-291-1/+9
| | | | allow for arbitrary option value types
* r12576: r12115@cabra: derrell | 2005-12-29 11:16:03 -0500Derrell Lipman2005-12-291-2/+28
| | | | bug (enhancement) #2651: add option to log debug messages to stderr instead of stdout
* r12570: r12084@cabra: derrell | 2005-12-29 10:05:16 -0500Derrell Lipman2005-12-291-25/+56
| | | | do not open connection when only looking for cached connection; also, fix crash caused by missing initialization following recent locale changes
* r12569: r12083@cabra: derrell | 2005-12-29 09:39:45 -0500Derrell Lipman2005-12-291-255/+526
| | | | fix line length and make formatting/indentation more consistent
* r12485: r12044@cabra: derrell | 2005-12-25 16:46:47 -0500Derrell Lipman2005-12-251-73/+87
| | | | | | | | | When enumerating what could be a server name or a workgroup name, first check for an existing server structure. If none exists, then go through the previous determination of whether it's a serrver or a workgroup. This should avoid doing a NetBIOS name query each time, if we've already connected to the specified server. (While we're at it, clean up indenting and line length in this area of code.)
* r12472: r12040@cabra: derrell | 2005-12-24 23:26:55 -0500Derrell Lipman2005-12-251-7/+2
| | | | revert immediately previous change and fix problem correctly. Interfaces were being loaded before all configuration files had been read. *This* should fix byg 3336.
* r12471: r12038@cabra: derrell | 2005-12-24 23:17:16 -0500Derrell Lipman2005-12-251-0/+5
| | | | libsmbclient was not loading the global configuration file. This should fix 3336.
* r12466: r12028@cabra: derrell | 2005-12-24 20:25:38 -0500Derrell Lipman2005-12-251-2/+4
| | | | parse dates correctly. w_time and m_time were reversed.