| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
I've wanted
to make this change for ages, but now with the issue of "open" requiring it,
this is the time to just do all of them.
Derrell
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on a NAS
device. The device resets a NBT connection on port 139 when it receives a
NetBIOS keepalive request. That request should be supported when NetBIOS is
in use; Windows is behaving badly.
libsmbclient needs a way to determine if a connection is still alive, and
was using a NetBIOS keepalive request if port 139 was in use (on the
assumption that it was probably NBT), and getpeername() when port 139 was
not being used (assuming naked transport).
This patch simplifies the code by exclusively using getpeername() to check
whether a connection is still alive. The NetBIOS keepalive request is
optional anyway (with preference being given to using TCP mechanisms for the
same purpose), so this should be both simpler and more reliable.
Derrell
|
|
|
|
| |
Michael
|
| |
|
|
|
|
|
|
|
| |
Windows Explorer doesn't complain about the order (and so that they get
interpreted properly).
Derrell
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Win2000 ignored
the request, presumably due to the PROTECTED flag not being set. Setting
that flag (in make_sec_desc()) has much wider implications than just to
libsmbclient, so instead of modifying that, we'll remove security
descriptors by setting the number of ACEs to zero. At some point, we might
want to look into whether we should actually be setting the PROTECTED flag
in the DACL.
Reference http://www.microsoft.com/technet/prodtechnol/windows2000serv/reskit/distrib/dsce_ctl_qxju.mspx?mfr=true
Derrell
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to me,
prs_mem_free() is not the function to be called to free memory allocated by
prs_alloc_mem(). I've added a comment so others may not get bitten too.
- Remove incorrect memory free calls added yesterday to replace SAFE_FREE.
The memory is actually now on a talloc context, so gets freed by the caller
when that context is freed. We don't need to free it iternally.
Derrell
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pointer was
incremented too far in some circumstances. In these cases, only the first
of multiple concatenated strings would be seen.
- Working on bug 4649 pertaining to delete an ACL, this fixes the reported
crash. It appears to have been an incomplete switchover from malloc to
talloc, as the memory was still being freed with SAFE_FREE.
Deleting ACLs still doesn't work. Although a valid request is sent to the
server and a SUCCESS response is returned, the method that's used in
libsmbclient for deleting ACLs seems to be incorrect. In looking at the
samba4 torture tests, it appears that we should be turning on the INHERIT
flag if we want to delete the ACL. (I could use some assistance on the
proper flags to send, from anyone familiar with this stuff.)
- Apply patch from SATOH Fumiyasu to fix bug 4750. smbc_telldir_ctx() was not
returning a value useful to smbc_lseekdir_ctx().
Derrell
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Guenther
|
|
|
|
|
| |
Long overdue fix....
Jeremy.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
subseqeuent
attempts to set attributes to fail.
- I also noticed that missing attributes were setting an invalid return string
by getxattr(), e.g. if there was not group, the return string had "GROUP:;"
instead of excluding the GROUP attribute entirely as it should. The big
problem with the way it was, is that the string could not then be passed to
setxattr() and parsed.
|
|
|
|
|
|
| |
return the
required size of a buffer needed to contain the extended attributes.
|
|
|
|
|
|
| |
been done for 3.0.25 pre-release. Janitor for
libsmbclient maintainer :-(.
Jeremy.
|
|
|
|
|
|
|
|
|
| |
process deep dfs links (ie. links that go to non root
parts of a share). Make the directory handling conanonical
in POSIX and Windows pathname processing.
dfs should not be fully working in client tools. Please
bug me if not.
Jeremy.
|
|
|
|
|
|
|
|
|
| |
of SEC_DESC over from grp_owner -> group_owner,
ace -> aces and info.mask -> mask. Makes it *much*
easier to move code within branches as they're now
referring to the same names for the same things
(which is what the NDR code also uses).
Jeremy.
|
|
|
|
|
|
| |
Jeremy.
"Fix a couple of Coverity errors in one run, this was a potential NULL
dereference"
|
| |
|
|
|
|
|
|
|
| |
The only major remaining pieces that are not being merged are:
* The IDL work
* The security descriptor merge.
|
| |
|
| |
|
|
|
|
|
|
| |
that need a leading / in OpenAndX calls. Should be in
3.0.23d (got missed).
Jeremy.
|
|
|
|
|
| |
Fixes bugs reported in libsmbclient.
Jeremy.
|
| |
|
|
|
|
| |
* updating release notes to match
|
|
|
|
|
|
|
|
| |
Implement enhancement request 3505. Two additional features are added here.
There is now a method of saving an opaque user data handle in the smbc_
context, and there is now a way to request that the context be passed to the
authentication function. See examples/libsmbclient/testbrowse.c for an example
of using these features.
|
|
|
|
|
| |
implicit function contract explicit.
Jeremy.
|
|
|
|
|
| |
Free grp_sid and owner_sid before returning. Also, only allow one group
or owner.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
their existence
|
|
|
|
| |
macro which sets the freed pointer to NULL.
|
|
|
|
| |
Guenther
|
|
|
|
| |
Sync with trunk as off r13315
|
|
|
|
|
|
|
| |
Fix cli_setpathinfo() to actually do what it's supposed to.
Also, get rid of some apparently drug-induced code to deal with create time
which isn't being manipulated anyway.
|
|
|
|
|
|
|
|
|
|
|
| |
This should fix bug #3446.
- The authentication domain provided an an SMB URL was being ignored. This
patch fixes that.
- There were a number of places where string copies were not being confirmed to
be properly null-terminated. Now, all string copies in libsmbclient.c are
properly null-terminated.
|
|
|
|
|
|
|
|
|
|
|
|
| |
lp_load() could not be called multiple times to modify parameter settings based
on reading from multiple configuration settings. Each time, it initialized all
of the settings back to their defaults before reading the specified
configuration file.
This patch adds a parameter to lp_load() specifying whether the settings should
be initialized. It does, however, still force the settings to be initialized
the first time, even if the request was to not initialize them. (Not doing so
could wreak havoc due to uninitialized values.)
|
|
|
|
| |
allow for arbitrary option value types
|
|
|
|
| |
bug (enhancement) #2651: add option to log debug messages to stderr instead of stdout
|
|
|
|
| |
do not open connection when only looking for cached connection; also, fix crash caused by missing initialization following recent locale changes
|
|
|
|
| |
fix line length and make formatting/indentation more consistent
|
|
|
|
|
|
|
|
|
| |
When enumerating what could be a server name or a workgroup name, first
check for an existing server structure. If none exists, then go through
the previous determination of whether it's a serrver or a workgroup. This
should avoid doing a NetBIOS name query each time, if we've already
connected to the specified server. (While we're at it, clean up indenting
and line length in this area of code.)
|
|
|
|
| |
revert immediately previous change and fix problem correctly. Interfaces were being loaded before all configuration files had been read. *This* should fix byg 3336.
|
|
|
|
| |
libsmbclient was not loading the global configuration file. This should fix 3336.
|
|
|
|
| |
parse dates correctly. w_time and m_time were reversed.
|