| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
as proposed by James Peach.
Jeremy.
|
|
|
|
|
|
| |
buffers for large read/write - make sure we take account of the large
read/write SMB headers as well as the buffer space.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Win2008 domain (merged from v3-0-test).
commit 8dc4e979776aae0ecaa74b51dc1eac78a7631405
Author: Steven Danneman <sdanneman@isilon.com>
Date: Wed May 7 13:34:26 2008 -0700
spnego SPN fix when contacting trusted domains
cli_session_setup_spnego() was not taking into consideration the situation
where we're connecting to a trusted domain, specifically one (like W2K8)
which doesn't return a SPN in the NegTokenInit.
This caused two problems:
1) When guessing the SPN using kerberos_get_default_realm_from_ccache() we
were always using our default realm, not the realm of the domain we're
connecting to.
2) When falling back on NTLMSSP for authentication we were passing the name
of the domain we're connecting to for use in our credentials when we should be
passing our own workgroup name.
The fix for both was to split the single "domain" parameter into
"user_domain" and "dest_realm" parameters. We use the "user_domain"
parameter to pass into the NTLM call, and we used "dest_realm" to create an SPN
if none was returned in the NegTokenInit2 packet. If no "dest_realm" is
provided we assume we're connecting to our own domain and use the credentials
cache to build the SPN.
Since we have a reasonable guess at the SPN, I removed the check that defaults
us directly to NTLM when negHint is empty.
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
| |
|
|
|
|
|
|
| |
This allows to switch on the cli->fallback_after_kerberos switch.
Guenther
|
| |
|
|
|
|
|
|
|
|
|
| |
the space taken by the unicode password to be one byte too
long (as we're on an odd byte boundary here). Reduce the
count by 1 to cope with this. Fixes smbclient against NetApp
servers which can't cope. Fix from
bryan.kolodziej@allenlund.com in bug #3840.
Jeremy.
|
|
|
|
|
|
| |
Not that I think it is of any importance...
Guenther
|
|
|
|
| |
Guenther
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
If I'm not completely blind, we should return here. Not doing it here seems not
to be a major flaw, as far as I can see we're only missing the error code. This
might account for some of the very unhelpful NT_STATUS_UNSUCCESSFUL error
messages people see during joins.
All with stake in Samba client, please check!
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
| |
During 'net ads join' the cli->desthost is a hostname (e.g.
rupert.galaxy.site). Check if we have a hostname and use only the
first part, the machine name, of the string.
|
|
|
|
|
| |
negotiation works.
Jeremy.
|
|
|
|
| |
Guenther
|
|
|
|
|
| |
When warning that "client plaintext auth" is not enabled where the server
requested them we should not talk about "client use plaintext auth"
|
|
|
|
|
|
| |
to cause us to behave like Vista when looking for remote
machine principal. Modified by me.
Jeremy.
|
|
|
|
|
|
|
| |
for a server. We should have been doing this for a while,
but it's more critical with IPv6.
Original patch fixed up by James.
Jeremy.
|
|
|
|
|
|
| |
Remove all vestiges of pstring (except for smbctool as noted
in previous commit).
Jeremy
|
|
|
|
|
|
|
| |
Remove pstring from libsmb/clidfs.c except for a nasty
hack (that will be removed when pstrings are gone from
client/).
Jeremy.
|
|
|
|
|
|
| |
Make us very explicit about how long a talloc ctx
should last.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
| |
I'm not sure why this used to be static, to me it seems that every time this
variable is overwritten. I just don't see how name_status_find() could return
true and not overwrite name. Can someone please review this and potentially
check it in?
Thanks,
Volker
|
|
|
|
| |
This is better done with a 'lp_do_parameter(-1, "socket options", ..);
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
it with accessor functions. "One global or pstring a day...." :-).
Jeremy.
|
|
|
|
|
|
|
|
| |
zero_addr(&ss). All current uses were always of the
AF_INET form, so simplify the call. If in the future
we need to zero an addr to AF_INET6 this can be
done separately.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to struct sockaddr_storage in most places that matter (ie.
not the nmbd and NetBIOS lookups). This passes make test
on an IPv4 box, but I'll have to do more work/testing on
IPv6 enabled boxes. This should now give us a framework
for testing and finishing the IPv6 migration. It's at
the state where someone with a working IPv6 setup should
(theorecically) be able to type :
smbclient //ipv6-address/share
and have it work.
Jeremy.
|
|
|
|
|
|
|
| |
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
|
|
|
|
|
|
|
|
|
|
| |
IPv6 in winbindd, but moves most of the socket functions that were
wrongly in lib/util.c into lib/util_sock.c and provides generic
IPv4/6 independent versions of most things. Still lots of work
to do, but now I can see how I'll fix the access check code.
Nasty part that remains is the name resolution code which is
used to returning arrays of in_addr structs.
Jeremy.
|
| |
|
|
|
|
|
|
| |
The translate_name() used by cli_session_setup_spnego() cann rely
Winbindd since it is needed by the join process (and hence before
Winbind can be run).
|
|
|
|
| |
and client fixes. Patch from Todd Stetcher <todd.stetcher@isilon.com>.
|
|
|
|
|
|
| |
NTSTATUS.
Guenther
|
|
|
|
|
|
|
|
|
|
| |
left as nonzero as returned by the failed cli_session_setup_spnego. When we then try
to authenticate as the user in cli_session_setup this returns an
error "Bad userid" (as seen in wireshark).
"We should only leave cli->vuid != 0 on success. Looks like it's
getting set in the cli_session_setup_blob_receive() call and not
cleared again on error."
Jeremy.
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
Long overdue fix....
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Attempt to fix some build farm failures: On port 139 the first
successful packet gives len==0 from the server, so the = in
if (len <= 0) {
in line 136 of clientgen.c throws a failure."
The irritating thing is that I already had it correct in
SAMBA_3_0_26 and forgot to merge the change across.
len == 0 is a valid return - I messed that up when
converting client_receive_smb() to return a length
rather than a BOOL.
Doh !
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
successful packet gives len==0 from the server, so the = in
if (len <= 0) {
in line 136 of clientgen.c throws a failure.
Jeremy, please fix this properly, I'm not merging this to 3_0_26 so that
you can filter it when you merge.
Volker
|
|
|
|
| |
replace all data_blob(NULL, 0) calls.
|
|
|
|
| |
Guenther
|
|
|
|
|
|
|
| |
to all callers of smb_setlen (via set_message()
calls). This will allow the server to reflect back
the correct encryption context.
Jeremy.
|
|
|
|
|
|
| |
the extended 7 word response for tconX rather than the
3 word one we supported previously.
Jeremy.
|
|
|
|
|
|
|
|
|
| |
not specific for NTLMSSP
- it's possible that the server sends a mechOID and authdata
if negResult != SPNEGO_NEG_RESULT_INCOMPLETE, but we still
force the mechOID to be present if negResult == SPNEGO_NEG_RESULT_INCOMPLETE
metze
|
|
|
|
|
|
| |
we're encrypted. This will make further changes and
spec much more clear.
Jeremy.
|