summaryrefslogtreecommitdiffstats
path: root/source/libads
Commit message (Collapse)AuthorAgeFilesLines
* Add comment explaining the previous fix.Jeremy Allison2009-04-221-0/+6
| | | | Jeremy.
* Fix bug #6279 - winbindd crash. Cope with LDAP libraries returning ↵Jeremy Allison2009-04-221-0/+4
| | | | | | LDAP_SUCCESS but not returning a result. Jeremy
* s3-krb5: Fix Coverity #762 (REVERSE_INULL).Günther Deschner2009-03-201-6/+6
| | | | | | Guenther (cherry picked from commit 97190ae184dff6450b1390c854f7426e2ee3f980) (cherry picked from commit 0f7757e94bfa35d22a7349d78578685c0dba22d7)
* fix build on old Heimdal based systemsBjörn Jacke2009-03-191-5/+3
| | | | | Signed-off-by: Günther Deschner <gd@samba.org> (cherry picked from commit 011ad7245d53a716c4c766f5ef8d317bb3a53d0f)
* Fix bug #6098 - When the DNS server is invalid, the ads_find_dc() does not ↵Yasuma Takeda2009-02-111-2/+2
| | | | | | | | | | | work correctly with "security = domain" 1. If DNS server is invalid, the get_sorted_dc_list() is called with realm(FQDN) and it fails. 2. On the next step, the get_sorted_dc_list() is called with realm(FQDN) again. I think "again" is wrong place. On the 2nd step, get_sorted_dc_list() should be called with realm(WORKGROUP).
* s3-spoolss: fix memleak in get_remote_printer_publishing_data().Günther Deschner2009-02-101-2/+8
| | | | | Guenther (cherry picked from commit 97f1514ce95800f1296b1979f1b34dcc5d56a376)
* s3:libads/ldap.c: store the dc name in the saf cache as in all other placesStefan Metzmacher2008-12-131-3/+2
| | | | | | | | | | metze Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Günther Deschner <gd@samba.org> (cherry picked from commit 543fa85a711337e979c7b631bda5db95d109ef59) (cherry picked from commit 17efebde11eafd065c2cac39cdbe55b8d40d40be) (cherry picked from commit 9e78bfdbe107519f2ddfa4d532771945a7691b46)
* s3:libads/ldap.c: if the client belongs to no site at all any dc is the closestStefan Metzmacher2008-12-131-0/+5
| | | | | | | | | | metze Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Günther Deschner <gd@samba.org> (cherry picked from commit f86ef9b53a903485deba94febf90dd4e657cc02b) (cherry picked from commit a8040d59659e58c5cb92c1107a7ff012eff12729) (cherry picked from commit 7baceea20252dec6b64e86ec8b5a73b62b373758)
* s3:libads/ldap.c: pass the real workgroup name to get_dc_name()Stefan Metzmacher2008-12-131-1/+10
| | | | | | | | | | metze Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Günther Deschner <gd@samba.org> (cherry picked from commit c2d4a84abe1b6cbf68d6e9f1bb1f8974d0b628fc) (cherry picked from commit 2f27ffc4a2ba745341a5961b8f04e62da3fb089a) (cherry picked from commit 132911954715bfa6df8566c0fb382ef07a7da96e)
* s3: libads: use get_dc_name() instead of get_sorted_dc_list() in the LDAP caseStefan Metzmacher2008-12-131-1/+25
| | | | | | | | | | | | | | | We use get_dc_name() for LDAP because it generates the selfwritten krb5.conf with the correct kdc addresses and sets KRB5_CONFIG. For CLDAP we need to use get_sorted_dc_list() to avoid recursion. metze Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Günther Deschner <gd@samba.org> (cherry picked from commit d2f7f81f4d61bae9c4be65cbc1bf962b6c24a31f) (cherry picked from commit 7f779450cb0b0d9f36665c56c4acd0950daaeab2) (cherry picked from commit 95c9a0272a72c029d75c3ffd1b5fad360b30f139)
* s3: correctly detect if the current dc is the closest oneStefan Metzmacher2008-12-131-1/+0
| | | | | | | | | | | | ads->config.tried_closest_dc was never set. metze Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Günther Deschner <gd@samba.org> (cherry picked from commit dfe5b00db35e1e7c7bb3ba36729fc3f97eb48db3) (cherry picked from commit 588f5aae669910fee6da7f807f330163496b4170) (cherry picked from commit b609f41baa035a15dafb18b2ec569a2b96968b17)
* Change sockaddr util function names for consistency and to eliminate name ↵Tim Prouty2008-12-031-3/+3
| | | | conflicts
* libads/ldap.c: return an error instead of crashing when no realm is givenStefan Metzmacher2008-11-241-4/+4
| | | | | | | | | | The bug was triggered by "net ads info -S 127.8.7.6" (where 127.8.7.6 doesn't exist) and "disable netbios = yes". metze Signed-off-by: Michael Adam <obnox@samba.org> (cherry picked from commit e2a60d2e1fd7455f08e73f8d1c513ca240c0f0af)
* Fix extended DN parse error when AD object does not have a SID.Steven Danneman2008-11-181-24/+38
| | | | | | | | | | | Some AD objects, like Exchange Public Folders, can be members of Security Groups but do not have a SID attribute. This patch adds more granular return errors to ads_get_sid_from_extended_dn(). Callers can now determine if a parse error occured because of bad input, or the DN was valid but contained no SID. I updated all callers to ignore SIDless objects when appropriate. Also did some cleanup to the out paths of lookup_usergroups_memberof()
* Whitespace and >80 column cleanups.Steven Danneman2008-11-181-12/+12
|
* Fix an unlikely memleak found by the IBM checkerVolker Lendecke2008-10-041-0/+2
|
* Fix an uninitialized variable found by the IBM CheckerVolker Lendecke2008-10-041-0/+1
|
* kerberos: fix indent of enc type lines in generated krb5.conf files.Günther Deschner2008-09-041-3/+3
| | | | | Guenther (cherry picked from commit 18a26f08b6fab4119a1421a7ca59c32dde8bb8cb)
* Fix uninitialized variable.Jeremy Allison2008-07-301-0/+1
| | | | Jeremy.
* Return NULL in sitename_fetch() if gencache_init() fails. Not falseGerald W. Carter2008-06-281-1/+1
| | | | (cherry picked from commit 9e9bab2dd859c7bb8082b4c932f1a95adf1895c6)
* Revert "Fix a memleak in ads_find_dc() in case get_sorted_dc_list() fails"Volker Lendecke2008-06-171-1/+0
| | | | This reverts commit 6bcfa82ff15531c64e0db27dcc58e5847c513aa6.
* mailslot: always pull a command 25 type reply.Günther Deschner2008-06-051-0/+1
| | | | | Guenther (cherry picked from commit 1ce726b951621cb4b34069c31d1318fc04ad2389)
* Fix a memleak in ads_find_dc() in case get_sorted_dc_list() failsVolker Lendecke2008-06-051-0/+1
| | | | | This is really not a proper place to fix this, but as get_gc_list() and friends are about to be replaced anyway, just work around the broken existing API
* Tiny memory leakMarc VanHeyningen2008-05-291-0/+2
|
* Memory leak fixes from Chere Zhou <czhou@isilon.com>.Jeremy Allison2008-05-271-0/+4
| | | | Jeremy.
* libads/cldap: store client sitename also keyed by dns domain name.Günther Deschner2008-05-261-0/+1
| | | | | Guenther (cherry picked from commit 0388b2f0cc4d14b005c5b42f2c17ddcbc8bef12a)
* dsgetdcname: make use of nbt_cldap_netlogon_15.Günther Deschner2008-05-261-1/+1
| | | | | Guenther (cherry picked from commit 5b0eda98f3d127399770f7a037ad3277dbe23393)
* cldap: move out cldap object to fix the build.Günther Deschner2008-05-261-0/+84
| | | | | Guenther (cherry picked from commit 56be9c98d24e64bf855439df21766d30f448f407)
* cldap: let ads_cldap_netlogon() return all possible cldap replies.Günther Deschner2008-05-262-15/+56
| | | | | Guenther (cherry picked from commit 6f9d5e1cc94bc90685b54c04622b8f3357bd2f69)
* mailslot/cldap: use nt_version bits in queries.Günther Deschner2008-05-261-1/+2
| | | | | Guenther (cherry picked from commit b261f063125f8454d8f4e8f6b6f8aa5bc393ea34)
* Fix Bug #5465 (joining with createcomputer=ou1/ou2/ou3).Günther Deschner2008-05-141-5/+5
| | | | | Guenther (cherry picked from commit f3251ba03a69c2fd0335861177159a32b2bc9477)
* BUG 5107: Fix handling of large DNS replies on AIX and Solaris.Gerald W. Carter2008-04-301-6/+32
| | | | | | | | | On AIX, Solaris, and possibly some older glibc systems (e.g. SLES8) truncated replies never give back a resp_len > buflen which ends up causing DNS resolve failures on large tcp DNS replies. Also add more debug lines about processing the DNS reply. (cherry picked from commit 5ed9b92097460cd8180db806a08213e97cfb8daa)
* Fix bug 5419: memory leak in ads_do_search_all_args() when enumerating 1000s ↵Steven Danneman2008-04-261-2/+24
| | | | | | | | | | | | | | | | | | | of entries The ads_do_search_all_args() function attempts to string together several LDAPMessage structures, returned across several paged ldap requests, into a single LDAPMessage structure. It does this by pulling entries off the second LDAPMessage structure and appending them to the first via the OpenLDAP specific ldap_add_result_entry() call. The problem with this approach is it skips non-entry messages such as the result, and controls. These messages are leaked. The short term solution as suggested by Volker is to replace the ads_*_entry() calls with ads_*_message() calls so we don't leak any messages. This fixes the leak but doesn't remove the dependence on the OpenLDAP specific implementation of ldap_add_result_entry().
* Revert "Add "desthost" to rpc_pipe_client"Volker Lendecke2008-04-251-1/+1
| | | | This reverts commit 783afab9c891dd7bcb78895b2a639b6f3a0edf5b.
* Revert "Fix two "ignoring asprintf result" warnings"Volker Lendecke2008-04-251-2/+3
| | | | This reverts commit 1d261e78b38e8080ca7122037d33c8ef913a4558.
* Revert "Use rpc_pipe_client->user_name instead of ↵Volker Lendecke2008-04-251-1/+1
| | | | | | rpc_pipe_client->cli->user_name" This reverts commit 3f6c5b99664a75a6f490ee3b6980b89cacf7f579.
* Revert "Move user/domain from rpc_pipe_client to cli_pipe_auth_data"Volker Lendecke2008-04-251-2/+1
| | | | This reverts commit 42de50d2cd43e760d776694f7b5f003ba51d7f84.
* Move user/domain from rpc_pipe_client to cli_pipe_auth_dataVolker Lendecke2008-04-251-1/+2
|
* cldap: avoid duplicate definitions so remove ads_cldap.h.Günther Deschner2008-04-211-4/+4
| | | | Guenther
* cldap: add talloc context to ads_cldap_netlogon().Günther Deschner2008-04-212-14/+30
| | | | Guenther
* libads: Use libnbt for CLDAP reply parsing.Günther Deschner2008-04-212-105/+24
| | | | Guenther
* Use rpc_pipe_client->user_name instead of rpc_pipe_client->cli->user_nameVolker Lendecke2008-04-201-1/+1
| | | | Also make sure that rpc_pipe_client->user_name is always talloced.
* Fix two "ignoring asprintf result" warningsVolker Lendecke2008-04-201-3/+2
|
* Add "desthost" to rpc_pipe_clientVolker Lendecke2008-04-201-1/+1
| | | | This reduces the dependency on cli_state
* Fix typo.Karolin Seeger2008-04-101-1/+1
| | | | Karolin
* Fix typos.Karolin Seeger2008-04-091-1/+1
| | | | Karolin
* Add ads_check_ou_dn().Günther Deschner2008-03-281-0/+47
| | | | Guenther
* Fix Coverity ID 488Volker Lendecke2008-03-231-0/+2
| | | | "status" was used uninitialized on success -- metze, please check
* Fix Coverity ID 487Volker Lendecke2008-03-231-0/+1
|
* Coverity fixesMarc VanHeyningen2008-03-173-6/+22
|