| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Jeremy.
|
|
|
|
| |
compiler-based argument checking.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch makes Samba compile cleanly with -Wwrite-strings.
- That is, all string literals are marked as 'const'. These strings are
always read only, this just marks them as such for passing to other functions.
What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables). The rest
is just adding a lot of 'const'.
As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).
Andrew Bartlett
|
| |
|
|
|
|
| |
remove 'alternate permissions' parameter (deprecated and not used since 2.0) (discussed with tridge)
|
|
|
|
| |
Andrew Bartlett
|
|
|
|
|
|
| |
use the silly cache any more. Also add group functions and fix a few callers.
Andrew Bartlett
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These might be reimplmented as simple pass-through functions, but all users
really should be doing 'getpwnam_alloc' or 'getpwuid_alloc' to ensure that
there are not shared static buffers.
I don't beleive we actually need a getpw*() cache inside samba - if we do
then I think we should look at our code design first.
(some of these changes are for platforms I don't have access to, but
they look sane)
Andrew Bartlett
|
| |
|
|
|
|
|
| |
returns to the client.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
for transfer_file.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
need to know about. Different from the DEBUG system.
Jeremy.
|
|
|
|
|
|
| |
dlopen & friends into configure.in. This should help building on *BSD
where dl*** calls are in libc.
Jeremy
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Changed "SMB/Netbios" to "SMB/CIFS" in file header.
|
|
|
|
| |
Jeremy
|
| |
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
can't redefine them. damn.
|
|
|
|
|
|
|
| |
This commit gets rid of all our old codepage handling and replaces it with
iconv. All internal strings in Samba are now in "unix" charset, which may
be multi-byte. See internals.doc and my posting to samba-technical for
a more complete explanation.
|
|
|
|
|
|
| |
Added vfs calls to symlink() and readlink() with appropriate configure
checks.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
can't
stop libc routines from calling getpwXXX functions, so caching a pointer to them
is impossible. This new code now makes two copies of the returned struct passwd
struct - one used as a cache, one returned to allow the caller to modify. When
doing a lookup we compare against the cached copy. Code is now easier to understand
also.
smbd/posix_acls.c: If we move the head of the linked list, remember to pass a
reference to that pointer.....
Jeremy.
|
|
|
|
|
|
|
|
|
| |
using fstrings. Spotted by Elrond. Thanks :-)
jerry
|
|
|
|
|
|
| |
srv_samr.c: Fix for pw caching.
smbd/nttrans.c: Fix to allow trans create to set ACL on open.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
uses cache max 100 times.
Jeremy.
|
|
|
|
|
|
|
|
| |
<rabollinger@home.com>
jerry
|
|
|
|
|
| |
Patrick Powell kindly pointed out the bug.
Jeremy.
|
|
|
|
|
| |
call in glibc 2.1.95. This hack only gets enabled if you define
GLIBC_HACK_FCNTL64
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handling in Samba. This was needed due to several limitations and
races in the previous code - as a side effect the new code is much
cleaner :)
in summary:
- changed sys_select() to avoid a signal/select race condition. It is a
rare race but once we have signals doing notification and oplocks it
is important.
- changed our main processing loop to take advantage of the new
sys_select semantics
- split the notify code into implementaion dependent and general
parts. Added the following structure that defines an implementation:
struct cnotify_fns {
void * (*register_notify)(connection_struct *conn, char *path, uint32 flags);
BOOL (*check_notify)(connection_struct *conn, uint16 vuid, char *path, uint32 flags, void *data, time_t t);
void (*remove_notify)(void *data);
};
then I wrote two implementations, one using hash/poll (like our old
code) and the other using the new Linux kernel change notify. It
should be easy to add other change notify implementations by creating
a sructure of the above type.
- fixed a bug in change notify where we were returning the wrong error
code.
- rewrote the core change notify code to be much simpler
- moved to real-time signals for leases and change notify
Amazingly, it all seems to work. I was very surprised!
|
|
|
|
|
| |
I had to modify sys_select() to not loop on EINTR. I added a wrapper
called sys_select_intr() which gives the old behaviour.
|
|
|
|
|
| |
modular form. In this pass I added oplock_irix.c and added a "struct
kernel_oplocks" that describes a kernel oplock implementation.
|
| |
|
|
|
|
|
| |
of doing a system call every time we want to just get our pid.
Jeremy.
|
| |
|
|
|
|
|
|
|
| |
to support some of this I added the following functions in util_file.c
file_lines_pload : load lines from a pipe
file_pload : load a pipe into memory
|
|
|
|
| |
Jeremy
|
|
|
|
|
|
| |
nmbd/nmbd_processlogon.c: Use "True" and "False" instead of 1 and 0.
Others - preparing for multiple pdu write code.
Jeremy.
|
|
|
|
|
|
|
|
|
| |
on the glibc source code and are safer than the traditional popen as
they don't use a shell to exec the requested command. Now we have
these functions they can be tightened up (environment etc.) as required
to make a safe popen. It should now be safe to add the environement
variable loading code to loadparm.c
Jeremy.
|
|
|
|
|
|
| |
lib/system.c: Trimmed down unicode directory entry to be POSIX complient.
lib/util_unistr.c: Added wstrdup().
Jeremy.
|
|
|
|
| |
Jeremy.
|