| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Summary:
Specially crafted SMB requests on
authenticated SMB connections can send smbd
into a 100% CPU loop, causing a DoS on the
Samba server.
(cherry picked from commit e2dff319a6d5c0c54acdba3d4fec05477ca60f11)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from Jeremy.
With this patch, I was able to join Windows 7 RC to a Samba3 DC, and login into a
Samba 3 Domain.
There are still two registry settings required:
HKLM\System\CCS\Services\LanmanWorkstation\Parameters
DWORD DomainCompatibilityMode = 1
DWORD DNSNameResolutionRequired = 0
Do *not* modify the other netlogon registry parameters that were passed around,
they weaken security.
Guenther / Jeremy.
|
|
|
|
|
|
|
| |
What a difference a name makes... :-). Just because something is missnamed
SA_RIGHT_SAM_OPEN_DOMAIN, when it should actually be SA_RIGHT_SAM_LOOKUP_DOMAIN,
don't automatically use it for a security check in _samr_OpenDomain().
Jeremy.
|
|
|
|
|
|
|
|
|
|
| |
correctly. For the clustering case.
Clustered setups should have only ever used
the unsigned version of TDB_DATA in the
first place so they can't be in this mess :-).
Just do the normal upgrade in the clustered case.
Jeremy.
|
|
|
|
|
| |
this fixes some compile time noise on FreeBSD 7
(cherry picked from commit 1bfdbb093f7c5e434ea3e653d389e1ccec578af6)
|
| |
|
|
|
|
|
|
| |
that "offered" read from the rpc packet in spoolss is under
that size. Tidyup from analysis from Veracode.
Jeremy.
|
|
|
|
|
|
|
|
|
|
| |
- Most of the time, we can determine from the file system we're connecting to
whether it supports case sensitivity. In those cases, we now set the
internal case sensitivity flag automatically. For those cases where the
request to retrieve file system attributes fails, we'll use the
user-specified option value.
Derrell
|
|
|
|
|
|
|
|
|
|
| |
- Since the revamp of libsmbclient, there has still been an external
declaration for smbc_urlencode and smbc_urldecode in libsmbclient.h, yet
those functions were renamed and made private. The two choices were to
remove the function names from libsmbclient.h or to make them public
again. The reported requested that they be public. This commit makes it so.
Derrell
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** THIS COMMIT CAUSES A CHANGE OF DEFAULT BEHAVIOR IN libsmbclient!!! ***
- libsmbclient now calls cli_set_case_sensitive() for a new CLI. By default,
it requests case-sensitive, but the old behavior of case-insensitive can be
requested with smbc_setOptionCaseSensitive(context, False);
The change of behavior is considered a bug fix, as it was previously
possible to accidentally overwrite a file that had the same case-insensitive
name but a different case-sensitive name as a previously-existing file,
while creating a new file.
Derrell
|
|
|
|
|
|
|
|
|
|
|
| |
in commit 61c5589d1fa4d6fe7ce7293a6f6ceab96d4ee193
(fix for bug #6019)
When cherry-picking from v3-3-test (or master) to v3-2-test,
we need to check that proto.h gets removed before committing,
since v3-2-test still has make proto.
Michael
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
This second patch cleans up by removing all of the code that is made
obsolete by the first patch. It should cause no functional changes.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
-1 or domain->last_status is not ok.
|
|
|
|
| |
metze
|
|
|
|
|
|
|
|
|
| |
LDAP_SSL_ON is not defined at all.
Ldaps can be used by specifying an ldaps URL using the "passdb backend"
parameter.
Karolin
(cherry picked from commit 0c6cf1f8793edfde924289aafbd174ce4a4fae0c)
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Author: SATOH Fumiyasu <fumiyas@osstech.co.jp>
Date: Wed Dec 17 00:42:25 2008 +0900
libsmbclient: Fix SIGBUS on non-x86 CPUs
We must align the struct smbc_dirent in the struct
SMBC_internal_data because the struct smbc_dirent
has numeric values that require alignment.
Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
ads->config.tried_closest_dc was never set.
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit dfe5b00db35e1e7c7bb3ba36729fc3f97eb48db3)
(cherry picked from commit 588f5aae669910fee6da7f807f330163496b4170)
(cherry picked from commit b609f41baa035a15dafb18b2ec569a2b96968b17)
|
|
|
|
| |
metze
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- only the first non truncating write causes
the write time update with 2 seconds delay.
It's not enough to check for an existing update event
as it will be NULL after the event was triggered.
- SMBwrite truncates always update the write time
unless the sticky write time is set.
- SMBwrite truncates don't trigger a write time update on close.
metze
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ok, here's the fix for the write times breakage
with the new tests in S4 smbtorture.
The key is keeping in the share mode struct
the "old_file_time" as the real write time,
set by all the write and allocation calls,
and the "changed_write_time" as the "sticky"
write time - set by the SET_FILE_TIME calls.
We can set them independently (although I
kept the optimization of not setting the
"old_file_time" is a "changed_write_time"
was already set, as we'll never see it.
This allows us to update the write time
immediately on the SMBwrite truncate case,
SET_END_OF_FILE and SET_ALLOCATION_SIZE calls,
whilst still have the 2 second delay on the
"normal" SMBwrite, SMBwriteX calls.
I think in a subsequent patch I'd like to
change the name of these from "old_file_time"
to "write_time" and "changed_write_time" to
"sticky_write_time" to make this clearer.
I think I also fixed a bug in Metze's original
code in that once a write timestamp had been
set from a "normal" SMBwriteX call the fsp->update_write_time_triggered
variable was set and then never reset - thus
meaning the write timestamp would never get
updated again on subsequent SMBwriteX's.
The new code checks the update_write_time_event
event instead, and doesn't update is there's
an event already scheduled.
Metze especially, please check this over for
your understanding.
Jeremy.
|
|
|
|
|
|
|
|
|
| |
Some of the bits generate INVALID_PARAMETER and some bits
are ignored when they come from a client, that's why we need
to use bits from the ignored range for our internal usage.
metze
(cherry picked from commit 7b4c8a4e39f310eb450918fa841b0ea1b4af19f7)
|
|
|
|
|
| |
as proposed by James Peach.
Jeremy.
|
|
|
|
|
|
| |
The macros "[un]likely" are already defined on SuSE 9.0.
Patch from Volker.
(cherry picked from commit 30d181c92463aecd6e649330d3645d86d5a17e43)
|
|
|
|
|
|
|
| |
Signed-off-by: Andreas Schneider <anschneider@suse.de>
Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
(cherry picked from commit fa803ce183376c938f92b0f31a7d89d522fd309f)
(cherry picked from commit 1cbae6583e04aa382c27d459f8d1c58488b3af7a)
|
|
|
|
|
| |
(cherry picked from commit 0e84e3bb800cec2b63df4692afbf9c40850b108f)
(cherry picked from commit 31a23b3fe4ca3cf7c65a6b3e079d10ef2956fae2)
|
| |
|
|
|
|
| |
(cherry picked from commit b2390aa738f6384016600dffb8065bd0bcda6ef1)
|
| |
|
| |
|
|
|
|
|
| |
Fix Coverity ID 552 and 553
(cherry picked from commit c46e10d2605b22d31675976e62e5ae61d73c8a0a)
|
|
|
|
|
|
| |
controlled via the ldap connection timeout parameter. This fixes fallbacks to secondary LDAP servers in multi LDAP server setups like in #4544
(cherry picked from commit 8e59a2fedc940b081222b0e8f90fe0c5a0981c06)
|
|
|
|
|
|
|
|
|
|
| |
Can someone with gpfs available test this ? The only codepath using this
function is the modules/gpfs.c module. The fix resolves at least the build
issues Samba has with recent kernel / libcap versions by using the portable
cap_get_proc()/cap_set_proc() interface (instead of using capget/capset).
Guenther
(cherry picked from commit 177955141247a4eb56ba0d82dc1add7f52175c40)
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
| |
RFC_IFACE."
This reverts commit 7bea00dca1ee08ef731dfa73110ef9c190a29919.
|
|
|
|
| |
This reverts commit 428654b473ba44b2f5340eefef0d4fcd51aff558.
|
|
|
|
| |
This reverts commit 2201a8118c6abae3425dd5728af129bb8f71b564.
|
|
|
|
| |
This reverts commit b1b6e93aa1f1b6d80969b6e5dd8f723e21ae8ce8.
|
|
|
|
| |
This reverts commit 5838d81346a51ef1e996bab938533ae2097f7e47.
|
|
|
|
|
|
| |
control data in the registry."
This reverts commit f673bbd300d972dd7ae2d092b3b1e642ed29cfd2.
|
|
|
|
| |
This reverts commit 6d543b1a1a5a7af98affc9aea2edf650cb476379.
|
|
|
|
| |
This code isn't finished yet.
|
|
|
|
|
|
| |
Should map the created sd to printer jobs, not printer.
Confirmed fix by the reporter. Karolin please pull for 3.2-stable.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
release-3-2-0pre2-2279-gd077ef6
The branch, v3-3-test has been updated
via d077ef64cd1d9bbaeb936566c2c70da508de829f (commit)
from 6e0e0cb8dd6f57de36c041e2ba4b82feeb357ce8 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
- Log -----------------------------------------------------------------
commit d077ef64cd1d9bbaeb936566c2c70da508de829f
Author: Günther Deschner <gd@samba.org>
Date: Mon May 5 16:58:24 2008 +0200
Fix client authentication with -P switch in client tools (Bug 5435).
Guenther
-----------------------------------------------------------------------
Summary of changes:
source/client/client.c | 5 ++++
source/include/popt_common.h | 1 +
source/lib/popt_common.c | 30 +------------------------
source/lib/util.c | 49 +++++++++++++++++++++++++++++++++++++++++-
source/libsmb/cliconnect.c | 22 +++++++++++++++++-
source/rpcclient/rpcclient.c | 15 ++++++++++++-
source/utils/smbcacls.c | 14 +++++++++++-
source/utils/smbcquotas.c | 15 ++++++++++++-
source/utils/smbtree.c | 6 +++++
9 files changed, 122 insertions(+), 35 deletions(-)
Changeset truncated at 500 lines:
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of entries
The ads_do_search_all_args() function attempts to string together several
LDAPMessage structures, returned across several paged ldap requests, into a
single LDAPMessage structure. It does this by pulling entries off the second
LDAPMessage structure and appending them to the first via the OpenLDAP specific
ldap_add_result_entry() call.
The problem with this approach is it skips non-entry messages such as the
result, and controls. These messages are leaked.
The short term solution as suggested by Volker is to replace the ads_*_entry()
calls with ads_*_message() calls so we don't leak any messages.
This fixes the leak but doesn't remove the dependence on the OpenLDAP specific
implementation of ldap_add_result_entry().
|
|
|
|
| |
This reverts commit aacb07b1b0f674b8cb92347ef4b4dd1e7808dde8.
|
|
|
|
| |
This reverts commit d1f82b7e67a791e19d08c682b607d82ae649feb4.
|