| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Jeremy.
|
|
|
|
| |
Michael
|
|
|
|
| |
Michael
|
|
|
|
|
|
| |
Use new flag LOOKUP_NAME_LOCAL.
Michael
|
|
|
|
| |
least surprise for callers
|
|
|
|
|
| |
This adds 28 fstrings on the stack, but I think an fstring on the stack is
still far better than a static one.
|
| |
|
|
|
|
| |
sid_to_string still expects a fstring
|
|
|
|
|
| |
No more temptations to use static length strings.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The point is doing the following associations:
- non discardable state data (all TDB files that may need to be backed
up) go to statedir
- shared data (codepage stuff) go to codepagedir
The patch *does not change* the default location for these
directories. So, there is no behaviour change when applying it.
The main change is for samba developers who have to think when dealing
with files that previously pertained to libdir whether they:
- go in statedir
- go in codepagedir
- stay in libdir
|
|
|
|
|
|
|
|
| |
(found by "make valgrindtest" and my "start winbindd on make test" patch)
metze
(cherry picked from commit fe21e48489852720a05b305b251e4f5cbb200f7a)
(cherry picked from commit 26d8a1ad20c10da495970c584983fbd261b4946e)
|
|
|
|
|
|
|
| |
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
|
| |
|
| |
|
|
|
|
|
|
| |
thread:
http://lists.samba.org/archive/samba-technical/2007-June/053747.html
|
|
|
|
|
|
| |
The callers of get_domain_group_from_sid() with some justification
expected map->gid to be initialized when get_domain_group_from_sid
returned True.
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
failed expression in SMB_ASSERT.
|
| |
|
| |
|
|
|
|
| |
sam unmapunixgroup"
|
|
|
|
|
|
| |
return values of some alias-releated pdb functions from BOOL to NTSTATUS
Thanks :-)
|
|
|
|
| |
Volker
|
|
|
|
|
| |
on talloc()'d memory when adding/removing members
from Local Groups.
|
|
|
|
|
|
| |
and fix all compiler warnings in the users
metze
|
|
|
|
|
|
| |
to avoid creating the TDB_DATA struct from strings "by hand"
metze
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we never mix malloc and talloc'ed contexts in the
add_XX_to_array() and add_XX_to_array_unique()
calls. Ensure that these calls always return
False on out of memory, True otherwise and always
check them. Ensure that the relevent parts of
the conn struct and the nt_user_tokens are
TALLOC_DESTROYED not SAFE_FREE'd.
James - this should fix your crash bug in both
branches.
Jeremy.
|
| |
|
|
|
|
|
|
|
| |
the DN must be rid,domain and not domain,rid
Also use member and not memberOf for group members
following conventions.
|
| |
|
|
|
|
|
| |
relies on appending to this list. Unfortunately this can't be tested
using 'net groupmap'
|
|
|
|
|
| |
This also fixes comments in group mappings, as the code accidentially
put in "ntName" in the comment field :-)
|
| |
|
|
|
|
|
|
|
| |
ldap
- use ldb_global_init() instead of the backend specific
ldb_tdb_init().
|
|
|
|
|
|
|
|
|
|
| |
rename to group_mapping.tdb.upgraded rather than an unlink when
upgrading. So if we absolutely have to go back to the tdb, we can
change mapping_ldb.o to mapping_tdb.o in Makefile.in and recover
peoples group mappings.
We could go one step futher and make the backend configurable. Any
opinions on that?
|
|
|
|
| |
See the discussion of this on the samba-technical list
|
|
|
|
|
|
|
|
|
| |
We usually do not get the results from user/group script modifications
immediately. A lot of users do add nscd restart/refresh commands into
their scripts to workaround that while we could flush the nscd caches
directly using libnscd.
Guenther
|
|
|
|
|
|
|
|
|
|
|
| |
* autogenerate lsa ndr code
* rename 'enum SID_NAME_USE' to 'enum lsa_SidType'
* merge a log more security descriptor functions from
gen_ndr/ndr_security.c in SAMBA_4_0
The most embarassing thing is the "#define strlen_m strlen"
We need a real implementation in SAMBA_3_0 which I'll work on
after this code is in.
|
|
|
|
| |
when using smbpasswd
|
| |
|
|
|
|
|
|
|
|
| |
pointing them
out.
Volker
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
afraid it's
more than 1000 lines of patch, but doing it in smaller pieces is hardly
possible.
Anybody interested please look over this. The patch is not really interesting,
just look at the new groupdb/mapping.c file.
Jerry, one entry for the 3.0.24 release notes: smbd will refuse to start if we
have overlapping mappings in group_mapping.tdb. With the old db a unix gid can
be mapped to two different SIDs. This will be refused with the new code.
Volker
|
|
|
|
|
|
|
|
| |
independently: Change
internal mapping.c functions to return NTSTATUS instead of BOOL.
Volker
|
|
|
|
|
|
|
|
| |
seemed a
bit pointless to me.
Volker
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove some unused code: pdb_find_alias is not used anymore, and nobody I
think has ever used the pdb_nop operations for group mapping. smbpasswd and
tdb use the default ones and ldap has its own.
Make the functions pdb_getgr* return NTSTATUS instead of BOOL. Nobody right
now really makes use of it, but it feels wrong to throw away information so
early.
Volker
|
|
|
|
|
|
| |
argument.
Volker
|
|
|
|
|
|
|
|
|
| |
does not
have the timeout argument in Samba4. Add a new routine
tdb_lock_bystring_with_timeout.
Volker
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Finally fix parsing idmap uid/gid ranges not to break with spaces
surrounding the '-'
* Allow local groups to renamed by adding info level 2 to
_samr_set_aliasinfo()
* Fix parsing bug in _samr_del_dom_alias() reply
* Prevent root from being deleted via Samba
* Prevent builting groups from being renamed or deleted
* Fix bug in pdb_tdb that broke renaming user accounts
* Make sure winbindd is running when trying to create the Administrators
and Users BUILTIN groups automatically from smbd (and not just check the
winbind nexted groups parameter value).
* Have the top level rid allocator verify that the RID it is about to
grant is not already assigned in our own SAM (retries up to 250 times).
This fixes passdb with existing SIDs assigned to users from the RID algorithm
but not monotonically allocating the RIDs from passdb.
|