| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
| |
dumps. It is gone until someone can tell us why its needed and what it
does. (It was only used on OSF1 and core dumped there anyway!)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
correctly. Added new parameter "stat cache size" - set to 50 by default.
I now declare the statcache code officially "open" for business :-).
It gets a hit rate of 97% with a NetBench run and seems to make
using a case insensitive run as efficient as a case sensitive run.
Also tidied up our sys_select usage - added a maxfd parameter and
also added an implementation of select in terms of poll(), for systems
where poll() is much faster. This is disabled by default.
Jeremy.
|
|
|
|
|
|
|
| |
problem was a buffer overflow in process_node_status_request().
this really points out a general problem is allocating MAX_DGRAM_SIZE
packets on the stack in nmbd. There must be a better way.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
| |
NetBench testing though.... :-). Attempts to efficiently reduce
the number of stat() calls Samba does.
Jeremy.
|
| |
|
|
|
|
| |
arrays. This prevents (harmless) warnings from some compilers
|
| |
|
|
|
|
| |
needs them and what should really be there.
|
| |
|
|
|
|
|
|
| |
the changes made re: -a and -o options.
Chris -)-----
|
|
|
|
|
| |
rpcsvc/ypclnt.h wants a struct dom_binding. knock-on include effect under
freebsd 2.1.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
if ((sbuf->st_mode & S_IWUSR) == 0)
result |= aRONLY;
rather than the very complex user/group permissions checks we do
currently. This is equivalent ot setting "alternate permissions = yes"
in the old code. The change is motivated by three main reasons:
1) it's basically impossible to second guess whether a file is
writeable without trying to open it for writing. ACLs, root squash etc
just make it too hard.
2) setting it not RONLY if the owner can write is closer to what NT
does (eg. look at a cdrom - files are not marked read only).
3) it prevents the silly problem of copying files from a read only
share to a writeable share and then finding you can't write to them as
windows preserves the RONLY flag. Lots of people get bitten by this
when they drag a folder from a Samba drive. It also hurts some install
programs.
I have also added a new flag type for loadparm.c called
FLAG_DEPRECATED which I've set for "alternate permissions". I'll soon
add code to testparm to give a warning about deprecated options.
|
|
|
|
|
|
|
| |
SMB_SET_FILE_ALLOCATION_INFO.
Office 97 expects this call to succeed when you tell it you do NT SMB calls.
Jeremy.
|
|
|
|
|
| |
have an ASSERT macro defined.
Jeremy.
|
| |
|
|
|
|
| |
in the rpc code.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
If the output line is longer than the format buffer could manage, I was
simply ignoring the additional output (that is, *not* copying it to the
format buffer--thus avoiding a buffer overrun). Instead, I now output
the current content followed by " +>\n", and then reset the format buffer.
I have never seen a debug line that exceeds the size of a pstring, but I
might as well handle the situation...just in case.
Chris -)-----
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
default to overwrite and smbd would default to append. Also, the -a option
(actually a toggle, such that "-a -a" would set the default) was documented
as append mode for nmbd, and *overwrite mode* for smbd.
nmbd now defaults to append mode, to match smbd. The -a option now always
means append, and I've added the -o option to both, meaning overwrite.
Note that the change to nmbd's default behavior may confuse some people.
I've not seen anything about 2.0.0 changes in the WHATSNEW.txt file.
Where would I document a change like this?
Chris -)-----
|
|
|
|
|
|
| |
if we do then NTws gets a BSOD.
I checked and NT server refuses these queries too :)
|
|
|
|
|
|
| |
Note: It is intended to extend this so that the release
process produces all the packaging scripts, templates, etc.
that may be needed.
|
|
|
|
| |
explanation.
|
|
|
|
|
| |
Luke, you need to do something similar in the rest of the rpc code.
Have fun!
|
|
|
|
| |
structures declared on the stack.
|
|
|
|
|
| |
Regards
Richard Sharpe
|
| |
|
| |
|
|
|
|
| |
perms on lock dir should be 755 not 644.
|
|
|
|
| |
basename of a file but the whole file name. silly error.
|
|
|
|
|
|
| |
chain_fsp on close (if you don't know what this means, consider yourself
lucky - this one took a day to track down :-).
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the head of an SMB request (ie. are part of a chain) will not be queued -
this will be fixed when we move to the new chain code. In practice, this
doesn't seem to cause much of a problem (in my admittedly limited testing)
bug a debug level zero message will be placed in the log when this
happens to help determine how real the problem is.
smbd/locking.c: New debug messages.
smbd/blocking.c: New blocking code - handles SMBlock, SMBlockread and SMBlockingX
smbd/chgpasswd.c: Fix for master fd leak.
smbd/files.c: Tidyup comment.
smbd/nttrans.c: Added fnum to debug message.
smbd/process.c: Made chain_reply() use construct_reply_common(). Added blocking
lock queue processing into idle loop.
smbd/reply.c: Added queue pushes for SMBlock, SMBlockread and SMBlockingX.
Jeremy.
|
|
|
|
| |
permissions.
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
| |
include/includes.h: Added nterr.h.
locking/locking.c: Moved blocking lock code into smbd/blocking.c for link purposes.
smbd/close.c: Added blocking lock removal to file close.
smbd/filename.c: Tidied up unix_convert() so I could read it (:-) in preparation
for the stat_cache code.
smbd/nttrans.c: Added WRITE_ATTRIBUTES check.
smbd/reply.c: Fixed multibyte char problem in wildcard mask.
Jeremy.
|
|
|
|
|
| |
locking/locking.c: More blocking lock changes.
Jeremy.
|
|
|
|
|
| |
could be overwritten in oplock processing code.
Jeremy.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
the splitup was done with an axe, not a scalpel, so there are some
rough edges. I mostly wanted to get the general form right with fine
tuning of what goes where to come later. Still, this is better than
what we had before where server.c was a general repository for
anything that didn't fit elsewhere.
|
|
|
|
| |
created dosmode.c and filename.c
|
|
|
|
|
|
|
| |
server.c without breaking things.
this splits off netprot.c and fileio.c for negprot and read/write/seek
handling respectively.
|
|
|
|
|
|
|
|
|
| |
very large. files.c now promotes a files_struct to the top of the list
if it is used when it is more than 10 elements from the top.
also moved common linked list code for the 5 sets of linked lists that
I've created over the past few days into dlinklist.h (I've explained
to Chris why I didn't use the ubiqx code)
|
|
|
|
| |
arrays to uchar
|
|
|
|
| |
to a linked list with bitmap format.
|