summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* test_smbclient_tarmode.pl: refactor, cleanup and document in PODAurélien Aptel2013-11-051-178/+459
| | | | | | Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* test_smbclient_tarmode.pl: add tests for wildcard pattern (cI, cX, cF, xF).Aurélien Aptel2013-11-051-33/+161
| | | | | | | | | | | * add some test for wildcard pattern and r switch, when possible (-r is very buggy) * change default DIR to "tar_test_dir" * add tests for attributes (nohidden, nosystem which are undocumented) Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* test_smbclient_tarmode.pl: add a first simple wildcard testAurélien Aptel2013-11-051-40/+145
| | | | | | | | | | | | | * File::list() now takes an absolute path * check_remote() now takes the dir to check * added an optional File destructor * added cleanpath() to remove unecessary slashes * File::new_remote() can take an absolute path * File->{dir} is now absolute from the localpath Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* test_smbclient_tarmode.pl: add a clean option to erase the local pathAurélien Aptel2013-11-051-0/+7
| | | | | | Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* test_smbclient_tarmode.pl: add test for xFAurélien Aptel2013-11-051-2/+28
| | | | | | | | Add test for extracting from a file list. Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* test_smbclient_tarmode.pl: add test for creation w/ filelistAurélien Aptel2013-11-051-2/+39
| | | | | | | | | * add test_creation_list() * add parameter to File::new_local() to provide file content Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* test_smbclient_tarmode.pl: add extraction test for I and X.Aurélien Aptel2013-11-051-7/+60
| | | | | | | | | | * add test for xI and xX * fix bug in check_remote(): print filename instead of ref * replace hash by list in test_extraction_normal() Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* test_smbclient_tarmode.pl: add tests for X and I.Aurélien Aptel2013-11-051-2/+34
| | | | | | | | Found a bug while doing so. X doesn't exclude file path. Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* test_smbclient_tarmode.pl: add option to choose and run a single testAurélien Aptel2013-11-051-1/+22
| | | | | | Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* test_smbclient_tarmode.pl: add first extraction testAurélien Aptel2013-11-051-8/+173
| | | | | | | | | | | | | | | | | | * add normal extraction test * add (or bring back) - File::list() -- return list of File in a path - File::tree() -- same but recursive - File::walk() -- high order function to iterate on a File hierarchy * compute md5 sum when not cached * add check_remote(), will be useful for all extraction tests * fix consecutive slashes bug in some File::xxxpath() At this point, the script can replace the old test_smbclient_tarmode.sh in terms of features. Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* test_smbclient_tarmode.pl: remove unused functionsAurélien Aptel2013-11-051-27/+0
| | | | | | Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* test_smbclient_tarmode.pl: add nested dirs testAurélien Aptel2013-11-051-5/+8
| | | | | | | | add a test to check that the backup handles nested directories. Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* test_smbclient_tarmode.pl: refactored file related function to a File packageAurélien Aptel2013-11-051-155/+194
| | | | | | | | | all the localpath(), remotepath() and all file related functions were getting out of hand. The tests are now simpler to write. Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* test_smbclient_tarmode.pl: add test for "newer than" (`N` flag)Aurélien Aptel2013-11-051-1/+45
| | | | | | | | | add test for the N FILE flag which makes smbclient only backup files newer or as new as FILE. Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* test_smbclient_tarmode.pl: add test for reset modeAurélien Aptel2013-11-051-6/+52
| | | | | | | | | add a new test for the reset mode which can be triggered via `-a` or `tarmode reset`. Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* test_smbclient_tarmode.pl: improve incremental testAurélien Aptel2013-11-051-2/+5
| | | | | | | | | instead of using archived and non-archived files for the test, use archive and various flags (system, hidden, readonly). Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* test_smbclient_tarmode.pl: add proper argument parsing for configuration.Aurélien Aptel2013-11-051-50/+94
| | | | | | | | documentation is included in the script in POD format. Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* initial commit of the new tarmode test script.Aurélien Aptel2013-11-051-0/+367
| | | | | | | | | This script will hopefully replace and improve test_smbclient_tarmode.sh. Right now it only does normal and incremental tests. Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* Add regression test for bug #10229 - No access check verification on stream ↵Jeremy Allison2013-11-042-0/+182
| | | | | | | | | | | | | | files. Checks against a file with attribute READONLY, and a security descriptor denying WRITE_DATA access. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@suse.de> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Mon Nov 4 23:10:10 CET 2013 on sn-devel-104
* Fix bug #10229 - No access check verification on stream files.Jeremy Allison2013-11-041-0/+59
| | | | | | | | | | | | | https://bugzilla.samba.org/show_bug.cgi?id=10229 We need to check if the requested access mask could be used to open the underlying file (if it existed), as we're passing in zero for the access mask to the base filename. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@suse.de>
* torture: Add smb2.rename.rename_dir_benchVolker Lendecke2013-11-042-0/+376
| | | | | | | | | This is a little benchmark test excercising parallel directory renames. With lots of open files directory renames get pretty slow against some SMB server implementations. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* testparm: Add warning for socket options.Andreas Schneider2013-11-041-0/+33
| | | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Mon Nov 4 16:52:25 CET 2013 on sn-devel-104
* testparm: Reformat text and add a newline.Andreas Schneider2013-11-041-54/+110
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* vfs: Fix some build warnings in glusterfs.Andreas Schneider2013-11-041-2/+2
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* vfs: Fix building the glusterfs module.Andreas Schneider2013-11-041-2/+2
| | | | | | | | Using calloc directly throws an error. This fixes building the glusterfs module. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* s3:rpc_server: rpc_create_tcpip_sockets() may leak talloc_stackframe on failureGregor Beck2013-11-041-6/+9
| | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=10241 Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Mon Nov 4 12:30:27 CET 2013 on sn-devel-104
* s3:rpcclient: fix a leaked talloc_stackframe in cmd_epmapperGregor Beck2013-11-041-5/+7
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=10241 Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3:rpc_client: fix a leaked talloc_stackframeGregor Beck2013-11-041-1/+2
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=10241 Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Andreas Schneider <asn@samba.org>
* smbd: Invalidate the session correctly.Jeremy Allison2013-11-041-0/+23
| | | | | | | | When a session is invalidated then we must also ensure it isn't used in any pending requests being processed. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4-dsdb: instanceType NC_HEAD is only allowed combined with WRITE for an ↵Nadezhda Ivanova2013-11-032-5/+15
| | | | | | | | | | | | originating add operation As described in MS-ATDS 3.1.1.5.2.8. Signed-off-by: Nadezhda Ivanova <nivanova@symas.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Nadezhda Ivanova <nivanova@samba.org> Autobuild-Date(master): Sun Nov 3 16:17:30 CET 2013 on sn-devel-104
* doc/msdfs proxy: extend example for multi target configBjörn Jacke2013-11-011-3/+3
| | | | | | | | Signed-off-by: Björn Jacke <bj@sernet.de> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Fri Nov 1 00:12:19 CET 2013 on sn-devel-104
* smbd: Support multiple dfs targets for msdfs proxy sharesVolker Lendecke2013-10-311-26/+8
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Björn Jacke <bj@sernet.de>
* libcli/smb: fix smb2cli_ioctl*() against Windows 2008.Stefan Metzmacher2013-10-311-4/+29
| | | | | | | | | | | | | | | The subsections of [MS-SMB2] "3.2.5.14 Receiving an SMB2 IOCTL Response" say the client should ignore the InputOffset/InputCount. We do that only if we ask for max_input_length = 0. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10232 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Oct 31 01:16:10 CET 2013 on sn-devel-104
* s3:libsmb: SMBC_getatr() if no method worked, try all methods again on next ↵Gregor Beck2013-10-301-3/+5
| | | | | | | | attempt Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* client: use cli_qpathinfo3 for allinfoGregor Beck2013-10-301-2/+2
| | | | | | Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: cli_qpathinfo3 use cli_qpathinfo2 for smb2Gregor Beck2013-10-301-1/+7
| | | | | | | | | cli_qpathinfo3 only works (and is only needed as fallback so far) for smb1. Use cli_qpathinfo2 in the smb2 case to make it universally usable. Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* client: remove a write only variableGregor Beck2013-10-301-2/+1
| | | | | | Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: SMBC_getatr use pathinfo3 for second tryGregor Beck2013-10-303-0/+15
| | | | | | | | | The pathinfo2 call might fail against NetApp because it is sending broken packages. Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: SMBC_getatr do not let ino undefined on successGregor Beck2013-10-301-0/+3
| | | | | | Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: SMBC_getatr try pathinfo2 only onceGregor Beck2013-10-301-1/+2
| | | | | | Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: add function cli_qpathinfo3()Gregor Beck2013-10-302-0/+61
| | | | | | | | | This is a reimplemantation of cli_qpathinfo2 without the use of info level SMB_QFILEINFO_ALL_INFO which leads to broken responses from NetApp. Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: add function cli_qpathinfo_standard()Gregor Beck2013-10-302-0/+53
| | | | | | Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: pass creation or birth time in cli_qpathinfo_basic()Gregor Beck2013-10-301-0/+1
| | | | | | Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:modules: nfs4_acls ACLs with zero entries are fine.Alexander Werth2013-10-301-6/+6
| | | | | | | | Signed-off-by: Alexander Werth <alexander.werth@de.ibm.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Wed Oct 30 20:31:42 CET 2013 on sn-devel-104
* s3:modules: Fix realloc with zero sized ACLsAlexander Werth2013-10-301-5/+7
| | | | | | | | A realloc with size zero is similar to a free. Since we return the number of acls that's not an error. Signed-off-by: Alexander Werth <alexander.werth@de.ibm.com> Reviewed-by: David Disseldorp <ddiss@samba.org>
* rpc_server: Fix a typoVolker Lendecke2013-10-301-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* librpc-idl: change the drsuapi_DsBindInfoCtr so that it match what is on the ↵Matthieu Patou2013-10-302-9/+204
| | | | | | | | | | | | | wire both in NDR32 and NDR64. Previous implementation had a problem with NDR64 with uint32 and uint3264 being in the wrong order Signed-off-by: Matthieu Patou <mat@matws.net> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Oct 30 10:16:02 CET 2013 on sn-devel-104
* s3-rpc_client: Make data pointer const in trans_send().Andreas Schneider2013-10-302-2/+2
| | | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Oct 30 01:32:08 CET 2013 on sn-devel-104
* s3-rpc_server: Remove obsolete make_internal_rpc_pipe().Andreas Schneider2013-10-292-90/+0
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3-rpc_server: Remove obsolete FAKE_FILE_TYPE_NAMED_PIPE handling.Andreas Schneider2013-10-291-37/+1
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>