| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| |
| |
| | |
Start removing unneeded "BOOL ok" from this reply.c
(this logic is old, old, old..... :-).
Jeremy.
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
create disposition of FILE_CREATE then there's no need
to check can_delete_file_in_directory().
Jeremy.
|
| |
| |
| |
| |
| | |
go back to normal. Sorry about that.
Jeremy.
|
| |
| |
| |
| |
| | |
to go...
Jeremy.
|
| |
| |
| |
| | |
Jeremy.
|
| |
| |
| |
| |
| |
| |
| | |
The only difference between the two trees now w.r.t file
serving are the changes to smbd/open.c in this branch I need
to review.
Jeremy.
|
| |
| |
| |
| |
| | |
The patch fixes the behaviour of GPFS sharemodes when
the access mask is no_access.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
fires, it
might be possible that we hang in the receive_smb() although that socket is
not the reason for the select() to return.
This immediately reacts to the fam socket to become readable, and goes into
the select loop again. This fixes delays in files showing up in Windows.
Jeremy, James please review this and merge to 3_0_24 if appropriate.
Thanks,
Volker
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
James, can you please confirm this and merge it to 3_0_24? For me it fixes the
segfault.
Thanks,
Volker
|
| |
| |
| |
| | |
Jeremy.
|
| |
| |
| |
| |
| |
| |
| | |
comparisons here, not unsigned as we're eventually
casting into what it normall a signed 32 bit
value. Guenther please check (but I think I'm right here).
Jeremy.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Just try to log on in offline mode without the fix: all accounts are expired,
although they are set to never expire in the PAC/info3.
NTTIME "Never" needs to get (time_t) -1.
We were casting a uint64 to time_t before
comparing, and we should have been doing it
the other way around.
Guenther please check this fixes things.
Jeremy.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The problem occurs like this:
1) running smbd as a domain member without winbindd
2) client1 connects, during auth smbd-1 calls update_trustdom_cache()
3) smbd-1 takes the trustdom cache timestamp lock, then starts
enumerate_domain_trusts
4) enumerate_domain_trusts hangs for some unknown reason
5) other clients connect, all block waiting for read lock on trustdom
cache
6) samba is now hung
The problem is the lock, and really its just trying to avoid a race
where the cure is worse than the problem. A race in updating the
trutdom cache is not a big issue. So I've just removed the lock.
It is still an open question why enumerate_domain_trusts() can
hang. Unfortunately I've not in a position to get a sniff at the site
that is affected. I suspect a full fix will involve ensuring that all
the rpc code paths have appropriate timeouts.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In case a user authenticated sucessfully and his password just expired
while beeing disconnected, we should allow a user to logon (given a
clear warning). We currently forced the user into a password change
dialogue in that scenario; this did not make much sense while offline.
Guenther
|
| |
| |
| |
| | |
coverity warnings.
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
--with-smbmount.
|
| |
| |
| |
| |
| |
| |
| |
| | |
"never" as
key words for -1 as policy values for net sam policy.
Volker
|
| |
| |
| |
| |
| |
| |
| |
| | |
We were incorrectly calculating the days until the password expires and
we also need to look at the info3 pass_must_change_time for expiry
calculation.
Guenther
|
| |
| |
| |
| | |
for the hint.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
wcard unlink if bad_path was set. The error
returned here is almost certainly incorrect
and will need testing properly with smbtorture,
but I don't want to forget about this path
(yes Volker I know this is currently incorrect :-).
Jeremy.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
starts to make
sense. Until then, remove it from the tree to keep the diff between 3_0_24 and
3_0 small.
Volker
|
| |
| |
| |
| |
| |
| |
| |
| | |
particular the NT_STATUS_INVALID_PARAMETER thing was badly wrong. Remove the
changes based on it. Using gentest is much more effective in this respect, but
it will take a while to figure out the wildcard error handling of W2k3.
Volker
|
| |
| |
| |
| | |
Guenther
|
| |
| |
| |
| |
| |
| |
| |
| | |
that we've
taken care of above.
Volker
|
| |
| |
| |
| |
| |
| |
| |
| | |
doing early
returns.
Volker
|
| | |
|
| |
| |
| |
| | |
anymore
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
reply_unlink
under Linux we returned NT_STATUS_NOT_A_DIRECTORY. This is because in the
bad_path==True condition lstat(2) returns ENOTDIR and not ENOENT.
Not sure if we want to necessarily replicate the INVALID_PARAMETER here, but
this is what W2k3 does.
Jeremy, I tried to call you, but you were not around. So I'll leave it up to
you to merge this.
Volker
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
set_bad_path_error
is equivalent to UNIX_ERROR. Expand the last reference. Lets see if I can kill
that as well :-)
Volker
|
| |
| |
| |
| |
| |
| |
| |
| | |
bad_path==True argument
being handled further up.
Volker
|
| | |
|
| |
| |
| |
| | |
unix error mapping table
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
I'm checking in micro-steps to make them independently checkable. This code
just very severely needs cleanup, but I don't want to break anything. So, be
patient with me, please :-)
Volker
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
Volker
|
| | |
|
| | |
|