| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
| |
as an error. (This is purely cosmetic here, issuing a success
message at the end.)
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
talloc context for use with the actual rpc query and response.
So the the parent context does not get flooded by the posslibly
large amount of response data (when looking up a lot of sids).
Note: It not possible, to simply use the names and domains arrays
as talloc contexts for the talloc_strdup calls, because from
rpccli_lsa_lookup_sids_all, this is called with names + offset
and domains + offset where names and domains are talloced
arraye for the complete response.
|
|
|
|
|
|
|
|
|
|
|
|
| |
dn_lookup loop by a rpccli_lsa_lookupsids_all (see r23070)
call. This replaces one ldap search per member sid by one
rpc call per 1000 sids. This greatly speeds up groupmem
lookups for groups with lots of users.
Since the loop in lookup_groupmem was the only use of dn_lookup,
the function is removed.
Michael
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
looked up at one time. This limit is at 20480 for w2k3.
Our rpccli_lsa_lookup_sids function ignores this limit, so when
we give the server too long a list of SIDs, then we will get
nothing back. Since typically rpccli_lsa_lookup_sids is given
one SID (or a small number of SIDS), this did not do harm
up to now. But since I want to use lsa_lookup_sids in a subsequent
modification to winbindd_ads.c:lookup_groupmem to get rid of
a vast number of dn_lookup calls to the server, I had to make
sure we do it correctly.
I have added a function rpccli_lsa_lookup_sids_all function
that has the same prototype but internally splits the list
of SIDs up into hunks of a (conservative, hard coded) 1000
SIDs each for a first go.
If this approach is agreed upon, the new function could replace
the original rpccli_lsa_lookup_sids function.
Michael
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
doing this because for the clustering the marshalling is needed in more
than one place, so I wanted a decent routine to marshall a message_rec
struct which was not there before.
Tridge, this seems about the same speed as it used to be before, the
librpc/ndr overhead in my tests was under the noise.
Volker
|
|
|
|
|
|
| |
check for IS_DC. Otherwise we will for example fail to lookup a
sid of S-1-22-1-780 because it has no valid struct winbindd_domain*
in the list. Thanks to Simo for the catch.
|
| |
|
|
|
|
|
|
|
|
|
| |
to be able to handle SIDs in the S-1-22-{1,2} domain in order
for winbindd_sid_to_uid(), et. al. to succeed. For 3.0.25a,
we will short circuit in the sid_to_uid() family of functions
so that smbd is ok.
For 3.0.26, we need to allow winbindd to handle all types of SIDs.
|
|
|
|
| |
Nothing of major interest. Will fix a few problems with one way trusts.
|
|
|
|
| |
TIME_T_MAX, and also display of it in http_timestring()
|
|
|
|
|
|
|
|
|
|
| |
winbindd main function.
I have tested and somewhat extended the code, and it seems
to do a good job. I have possibly not caught all error
conditions though.
Michael
|
|
|
|
|
|
|
| |
use a helper function to construct the TDB_DATA key
as strlen_m() is totally wrong here anyway
metze
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
message_send_pid is used anymore. Two users of duplicates_allowed: winbind and
the printer notify system.
I don't thing this really changes semantics: duplicates_allowed is hell racy
anyway, we can't guarantee that we don't send the same message in sequence
twice, and I think the only thing we can harm with the print notify is
performance.
For winbind I talked to Günther, and he did not seem too worried.
Volker
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
replaces
the timeouts on the individual message send calls with an overall timeout on
all the calls.
The timeout in message_send_pid_with_timeout() did not make much sense IMO
anyway, because the tdb_fetch() for the messages_pending_for_pid was blocking
in a readlock anyway, we "just" did the timeout for the write lock.
This new code goes through the full wait for the write lock once and then
breaks out of sending the notifies instead of running into the timeout per
target.
Jerry, please check this!
Thanks,
Volker
|
| |
|
|
|
|
| |
Jeremy.
|
| |
|
|
|
|
|
|
|
|
| |
lock we know nothing about that we retry the lock every
10 seconds instead of waiting for the standard select
timeout. This is how we used to (and are supposed to)
work.
Jeremy.
|
|
|
|
| |
Bug #3181.
|
|
|
|
|
|
|
|
| |
with \.
This patch removes this dead code.
Patch from Pascal Terjan <pterjan@mandriva.com> for bug #2313.
|
|
|
|
|
| |
packet size.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
| |
we have to take care to preserve the "special" values
for Windows of 0x80000000 and 0x7FFFFFFF when casting
between time_t and uint32. Add conversion functions
(and use them).
Jeremy.
|
| |
|
|
|
|
|
|
| |
only if the output of which has a leading '/' the output is useful...
metze
|
|
|
|
| |
boxes like this. Thanks, Don!
|
|
|
|
| |
option to pass to kernel code so it can know when to retry)
|
|
|
|
|
|
| |
frees that
valgrind noticed
|
|
|
|
|
|
| |
since any SID/uid/gid translation calls will reset the struct when
popping the security ctx. This should fix the standalone server
configuration issues reported by David Rankin (thanks for the logs).
|
|
|
|
|
| |
would flood at log level 2. We know when we're using the legacy
mapping code anyways since it will log an informative msg.
|
| |
|
|
|
|
| |
DsDGetPrimaryRoleInfo() and configured for security = domain.
|
|
|
|
| |
the ELF segment
|
|
|
|
|
|
|
|
| |
smb4k uses 'net rap server domain' to list servers in domain.
Previously we just ignored all arguments in net_rap_server() but now we don't
as 'net rap server name' has added an explicit check on arguments.
Allow 'net rap server domain' to aid smb4k. Any other arguments will cause help message.
|
|
|
|
|
| |
(slightly truncated by me). Will be in 3.0.25a.
Jeremy.
|
| |
|
| |
|
|
|
|
| |
release yet .... ;-))
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Attempt to fix some build farm failures: On port 139 the first
successful packet gives len==0 from the server, so the = in
if (len <= 0) {
in line 136 of clientgen.c throws a failure."
The irritating thing is that I already had it correct in
SAMBA_3_0_26 and forgot to merge the change across.
len == 0 is a valid return - I messed that up when
converting client_receive_smb() to return a length
rather than a BOOL.
Doh !
Jeremy.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
Originally, dlfcn.o was only added to LIBREPLACEOBJ if dlopen
was found in libdl but header dlfcn.h was not appropriate.
Michael
|
|
|
|
| |
Jeremy, please check this and merge if appropriate.
|