| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
really should be together. Chris -)-----
|
| |
|
|
|
|
|
|
|
|
|
| |
debug format buffer to be written out (and reset). fflush() is also called
to force the issue. I replaced the call to fflush() in client.c with a
call to dbgflush(), which seems to have fixed the problem that Andrew was
working on (i.e., that the prompt was not displayed when using smbclient).
Chris -)-----
|
|
|
|
| |
not?
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
locking/locking.c: First cut a blocking lock code. #ifdef'ed out for now.
locking/locking_shm.c: Removed dir_ptr. Not needed.
smbd/nttrans.c: More work on ChangeNotify - return is not an error and needs
to be handled as a nttrans with zero params. Removed dir_ptr. Not needed.
smbd/reply.c:
smbd/server.c:
smbd/trans2.c: Removed dir_ptr. Not needed.
Hmmm. At the moment smbclient is broken - doesn't issue prompt correctly.
This needs looking at.
Jeremy.
|
|
|
|
|
|
|
| |
message *but the daemon would start anyway*. I've added a call to exit()
in the default: case of the option processing loop.
Chris -)-----
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
macros that meets the RVALUE requirement and doesn't use the (a?b:c) format
that Andrew called "ugly". I've added the new macros but kept the old
macros within a #if 0..#else..#endif block in case I've missed somthing.
Basically, I've used
(void)( (a) && (b) )
or
(void)( (a) && (b) && (c) )
instead of
( (a) ? (void)(b) : (void)(c) )
or similar. I have this compiled and running now.
Here's the diff:
$ cvs diff smb.h
Enter passphrase for RSA key 'crh@Ruby':
Index: smb.h
===================================================================
RCS file: /data/cvs/samba/source/include/smb.h,v
retrieving revision 1.172
diff -r1.172 smb.h
143a144,145
> #if 0
>
150a153,164
>
> #else
>
> #define DEBUG( level, body ) \
> (void)( (DEBUGLEVEL >= (level)) \
> && (dbghdr( level, FILE_MACRO, FUNCTION_MACRO, (__LINE__) )) \
> && (dbgtext body) )
>
> #define DEBUGADD( level, body ) \
> (void)( (DEBUGLEVEL >= (level)) && (dbgtext body) )
>
> #endif
Chris -)-----
|
|
|
|
| |
ignored).
|
| |
|
| |
|
|
|
|
|
|
|
| |
before the config file has been loaded. Otherwise the default is no
timestamp.
Chris -)-----
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Debug1() was being called like this:
Debug1( format_bufr );
but if format_bufr contains any %s or other % arguments (such as when
processing a smb.conf file containing % macros) then smbd dies a
horrible death.
The quick fix is to use:
Debug1( "%s", format_bufr);
|
|
|
|
|
|
|
| |
causing seg faults on my machine and because the fault code calls
DEBUG() it is looping!
now to find the bug in the Debug1() code ...
|
|
|
|
|
|
|
|
| |
manpath in (although we don't currently use it).
client/client.c: Added John Blair's fixes for "put -".
include/nterr.h: Added NT_STATUS_NOTIFY_ENUM_DIR error code.
smbd/nttrans.c: Added in devious fix for one-shot NT change notify bug.
Jeremy.
|
| |
|
|
|
|
|
|
|
|
|
| |
include/smb.h: Fixed bugs in Debug macro's with SGI compiler.
smbd/trans2.c: Fixed bug reported by Zoltan Palmai <ZSPA@chevron.com>
PR#8903 where get_lanman2_dir_entry() could return a
mangled name as a resume key and call_trans2findnext()
wasn't doing the same.
Jeremy.
|
|
|
|
|
| |
modified it not to need any smbd specific structures and instead pass
things from smbd.
|
|
|
|
|
| |
into passdb/pass_check.c. This means SWAT no longer needs to link to
smbd/password.c
|
|
|
|
| |
utilities
|
| |
|
| |
|
| |
|
|
|
|
| |
I'll do the rest tomorrow.
|
|
|
|
| |
something about our dependencies between seemingly unrelated code.
|
|
|
|
|
|
| |
illogical places. Once I get everything compiled these will need to be
revisited, but at least the new Makefile.in makes it really obvious
what is out of place.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Chris, you should never put if statements in macros, use the ugly
(a?b:c) form instead, otherwise you can produce incorrect code when
you have things like:
if (foo)
DEBUG((blah));
else
DEBUG((blooh));
|
| |
|
| |
|
| |
|
|
|
|
| |
now the Makefile .....
|
| |
|
|
|
|
|
| |
functions (notably innetgr) to ensure we don't replace them if they
are in -lsocket
|
| |
|
| |
|
|
|
|
| |
update make scripts to use new autoconfigure setup
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
|
| |
the correct directory before doing the stat. Doh !
uid.c: Fix for performance in security=share mode. Invalid vuid meant
that in security=share mode Samba was always doing the become_user/
undebome_user pairs for *every* smb. This code fixes it, but tridge
should review for security implications.
Jeremy.
|
|
|
|
|
|
|
| |
nttrans.c: Moved common code into function in server.c
Removed left over debug level 0.
server.c: Moved common code into function in server.c
Jeremy.
|
|
|
|
|
|
| |
so that we wouldn't get too many timestamps.
Chris -)-----
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for changes in the directory modify timestamps. A better version
will look at the requested client flags, and create a hash that
represents the current state of the directory, and check against
this instead.
debug.c: Added lp_timestamp_logs() function.
loadparm.c: Added "change notify timeout" in seconds (default 60)
- this is the scan rate for a directory.
Added ""timestamp logs" boolean - default True. Turns
off log timestamps (so I can read them :-).
nttrans.c: ChangeNotify implementation.
server.c: ChangeNotify implementation.
shmem_sysv.c: Added exits on shmem errors (without them smbd can
core dump if some calls fail).
smb.h: Added ChangeNotify flags for future use.
util.c: Tidied up typedef.
Jeremy.
|
|
|
|
|
| |
very long output line in become_domain_master_query_success().
Chris -)-----
|
|
|
|
|
|
|
|
|
|
| |
through and changed some DEBUG() calls to DEBUGADD() to combine output
under a single timestamp. There were too many timestamps.
Note that Jeremy has told me that he's working on adding a config parameter
to turn timestamps off. Cool.
Chris -)-----
|
|
|
|
|
|
|
|
|
|
| |
Replaced printfs with DEBUG(0. Tested ... Works.
Hope I didn't disturb the autoconf code ... It feels
great to be able to run configure for Samba at long last!
Regards
Richard Sharpe
|
|
|
|
|
|
|
|
| |
when Andrew and I were both working with util.c. I really don't know
how I lost the autoconfigure changes (honest, I *did* run frequent
updates).
Chris -)-----
|
|
|
|
|
|
|
| |
for the rest. I've found that only debug.h seems to be out of sync (i.e.,
util.c itself appears to be okay).
Chris -)-----
|
|
|
|
|
|
|
|
|
| |
timestamps from several DEBUG messages. The timestamps are redundant now
that DEBUG() provides them automatically.
There are still a few more files to do, but I've got to get home for dinner.
Chris -)-----
|
|
|
|
| |
Chris -)-----
|
|
|
|
|
|
|
|
|
|
|
| |
Makefile.in: I've added debug.o.
proto.h : Rebuilt, as is standard for these sorts of things.
smb.h : New macros, etc.
util.c : Debug code removed.
I'll check in debug.c in the next step.
Chris -)-----
|