summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* s3: Save errno around a TALLOC_FREEVolker Lendecke2012-06-111-0/+3
| | | | Signed-off-by: Jeremy Allison <jra@samba.org>
* s3: Fix Coverity ID 703871 Unused pointer valueVolker Lendecke2012-06-111-0/+4
| | | | Signed-off-by: Jeremy Allison <jra@samba.org>
* s3/doc: some spelling fixesBjörn Jacke2012-06-1123-26/+26
| | | | | | | Thanks to Frans Luteijn <f.a.g.luteijn at knoware.nl> for providing the fixes! Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Mon Jun 11 23:16:26 CEST 2012 on sn-devel-104
* s3-winbindd: add comments about dump_core_setupMatthieu Patou2012-06-111-0/+11
| | | | | | | | This patch is related to change 0ea7152ff479e32e25817e4ddb1c2a1569bad81d Comments are added to explain why we call dump_core_setup 3 times. Autobuild-User(master): Matthieu Patou <mat@samba.org> Autobuild-Date(master): Mon Jun 11 21:21:11 CEST 2012 on sn-devel-104
* s3:smbd: explain parameters to filename_convert call in smbd_smb2_create_send()Michael Adam2012-06-111-2/+2
| | | | | Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Mon Jun 11 19:21:51 CEST 2012 on sn-devel-104
* s3: Fix Coverity ID 703869 Logically dead codeVolker Lendecke2012-06-111-10/+6
| | | | | | | | | | | | We "TALLOC_FREE(curr)" and assign prev=curr in the for-loop header. This will lead to "prev"==NULL always. In this loop, we do not need to correctly re-shuffle the linked list, we delete all from the beginning anyway. Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon Jun 11 17:26:53 CEST 2012 on sn-devel-104
* s3: Fix Coverity ID 709049 Dereference before null checkVolker Lendecke2012-06-111-1/+1
| | | | | | | | | | We have dereferenced fsp before. Because smb2 is only handle based, this is a bogus check. Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon Jun 11 15:30:54 CEST 2012 on sn-devel-104
* debug: Do not constantly rename logs when max log size = 0Andrew Bartlett2012-06-111-16/+18
| | | | | | | | | | | | | | | | In Samba4, the max log size parameter is not yet connected, so maxlog is 0 This means that we would, on receipt of a -HUP, have all child processes attempt a rename. Now we have the -HUP mean we reopen the logs unconditionally, and then we see if the log is too large (samba3 mode) or simply proceed assuming that someone else has renamed the logs for us. Andrew Bartlett Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Mon Jun 11 13:34:43 CEST 2012 on sn-devel-104
* file_server: Use samba4 auth module for guest logins as wellAndrew Bartlett2012-06-111-1/+1
| | | | | | | This is important for consistancy on NTLM logins, as the samba4 stack is used for all NTLMSSP logins anyway. Andrew Bartlett
* lib/param: simplfy lp_find_security()Andrew Bartlett2012-06-111-5/+0
| | | | | | All the roles other than ROLE_DOMAIN_MEMBER map to SEC_USER. Andrew Bartlett
* pyldb: Ensure that the ldb argument is really an ldb before we dereferenceAndrew Bartlett2012-06-111-0/+10
|
* s3-smbd: Remove unused branches in negprot since security=share was removedAndrew Bartlett2012-06-111-21/+8
|
* s4-selftest: Test samba-tool drs replicate --local --full-syncAndrew Bartlett2012-06-113-2/+12
|
* libcli/nbt: remove unused system/network.h from libnbt.hStefan Metzmacher2012-06-111-1/+0
| | | | | | | | | | | | | | | | | | | | | | This is not needed and breaks the build on AIX: [ 988/3309] Compiling source4/smb_server/smb/reply.c "../source4/smb_server/smb/reply.c", line 1093.42: 1506-022 (S) "lseek64" is not a member of "union smb_seek". "../source4/smb_server/smb/reply.c", line 1093.42: 1506-022 (S) "lseek64" is not a member of "union smb_seek". "../source4/smb_server/smb/reply.c", line 1093.42: 1506-022 (S) "lseek64" is not a member of "union smb_seek". "../source4/smb_server/smb/reply.c", line 1093.42: 1506-022 (S) "lseek64" is not a member of "union smb_seek". "../source4/smb_server/smb/reply.c", line 1109.13: 1506-022 (S) "lseek64" is not a member of "union smb_seek". "../source4/smb_server/smb/reply.c", line 1110.13: 1506-022 (S) "lseek64" is not a member of "union smb_seek". "../source4/smb_server/smb/reply.c", line 1111.13: 1506-022 (S) "lseek64" is not a member of "union smb_seek". "../source4/smb_server/smb/reply.c", line 1113.38: 1506-022 (S) "lseek64" is not a member of "union smb_seek". Waf: Leaving directory `/opt/home/build/build_farm/samba_4_0_test/bin' Build failed: -> task failed (err #1): {task: cc reply.c -> reply_1.o} metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon Jun 11 10:32:51 CEST 2012 on sn-devel-104
* lib/ldb/tools: add missing "replace.h"Stefan Metzmacher2012-06-114-0/+4
| | | | | | | | | This has to be the first header! metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon Jun 11 01:21:01 CEST 2012 on sn-devel-104
* s3/test: make dd call more portableBjörn Jacke2012-06-101-1/+1
| | | | | | | using multiplicative suffixes like K, M etc. in dd isn't portable Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Sun Jun 10 23:29:42 CEST 2012 on sn-devel-104
* s4/pvfs: handle non-POSIX compliant Tru64, NetBSD and FreeBSD errno on ↵Björn Jacke2012-06-101-1/+22
| | | | | | O_NOFOLLOW symlink open calls see also f75f1d62339f0accb4e574645b1d265c75a01b5b
* s3: fix build on systems without O_NOFOLLOWBjörn Jacke2012-06-101-1/+1
|
* wafsamba: try to fix the build on AIX with xlc_rStefan Metzmacher2012-06-101-1/+10
| | | | | | | | | | | | | | | bld.env['CPP'] can be 'None' or '[]', bld.CONFIG_SET("CPP") should return False File "./buildtools/wafsamba/samba_pidl.py", line 131, in SAMBA_PIDL_LIST bld.SAMBA_PIDL(name, p, options=options, output_dir=output_dir, symlink=symlink, generate_tables=generate_tables) File "./buildtools/wafsamba/samba_pidl.py", line 65, in SAMBA_PIDL cpp = 'CPP="%s"' % bld.CONFIG_GET("CPP")[0] IndexError: list index out of range metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Sun Jun 10 20:18:49 CEST 2012 on sn-devel-104
* heimdal:lib/asn1: try to fix the build on IRIXStefan Metzmacher2012-06-101-2/+6
| | | | | | | | | | | cc-1028 cc: ERROR File = ../source4/heimdal/lib/asn1/gen_template.c, Line = 548 The expression used must have a constant value. struct templatehead template = { 0L, &(template). tqh_first }; ^ If this really fixes the IRIX build, we'll propose this for heimdal upstream. metze
* Revert "s3:smbd: set req->smb2req->compat_chain_fsp in file_fsp()"Stefan Metzmacher2012-06-101-3/+0
| | | | | | | | | | | This reverts commit c2716a7d5ccf78f9716b703c22e6cf4d4f179656. This is not needed anymore, as we have file_fsp_smb2() now. metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Sun Jun 10 18:04:21 CEST 2012 on sn-devel-104
* s3: handle non-POSIX compliant Tru64, NetBSD and FreeBSD errno on O_NOFOLLOW ↵Björn Jacke2012-06-101-1/+20
| | | | | | | | | | | | | symlink open calls or should we leave the NetBSD and FreeBSD platforms just broken? Actually these two *want* to have broken platforms as they use different errno's than POSIX demands *interntionally*. The POSIX errno ELOOP for O_NOFOLLOW open calls on symlinks is clear and unambiguous. See http://gnats.netbsd.org/43154 for the interesting NetBSD discussion on that. Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Sun Jun 10 16:10:02 CEST 2012 on sn-devel-104
* s3:smb2_ioctl: make use of file_fsp_smb2()Stefan Metzmacher2012-06-101-30/+12
| | | | | | | metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Sun Jun 10 01:10:15 CEST 2012 on sn-devel-104
* s3:smb2_lock: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-30/+12
| | | | metze
* s3:smb2_write: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-26/+9
| | | | metze
* s3:smb2_read: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-29/+11
| | | | metze
* s3:smb2_notify: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-26/+9
| | | | metze
* s3:smb2_setinfo: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-29/+12
| | | | metze
* s3:smb2_getinfo: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-29/+12
| | | | metze
* s3:smb2_find: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-26/+9
| | | | metze
* s3:smb2_break: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-32/+13
| | | | metze
* s3:smb2_close: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-30/+15
| | | | metze
* s3:smb2_flush: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-26/+9
| | | | metze
* s3:smbd: add file_fsp_smb2()Stefan Metzmacher2012-06-092-0/+46
| | | | metze
* s3:smb2_write: pass fsp->fnum to init_strict_lock_struct()Stefan Metzmacher2012-06-091-1/+1
| | | | | | | | | | | | fsp->fnum is the same as in_file_id_volatile. When we start to support durable handles we should pass in_file_id_persistent. metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Sat Jun 9 18:50:32 CEST 2012 on sn-devel-104
* s3:smb2_read: pass fsp->fnum to init_strict_lock_struct()Stefan Metzmacher2012-06-091-2/+2
| | | | | | | | | fsp->fnum is the same as in_file_id_volatile. When we start to support durable handles we should pass in_file_id_persistent. metze
* s3:smb2_lock: use fsp->fnum as locking contextStefan Metzmacher2012-06-091-1/+1
| | | | | | | | | fsp->fnum is the same as in_file_id_volatile. When we start to support durable handles we should pass in_file_id_persistent. metze
* s3:smb2_lock: use smb2req->compat_chain_fsp instead of looking it up againStefan Metzmacher2012-06-091-6/+1
| | | | metze
* s3:smbd: set req->smb2req->compat_chain_fsp in file_fsp()Stefan Metzmacher2012-06-091-0/+3
| | | | metze
* s3:smb2_close: add missing TALLOC_FREE(subreq) in smbd_smb2_request_close_done()Stefan Metzmacher2012-06-091-0/+1
| | | | | | | metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Sat Jun 9 13:57:31 CEST 2012 on sn-devel-104
* s3:smbd: readd START_PROFILE(smbd_idle)/END_PROFILE(smbd_idle)Stefan Metzmacher2012-06-091-0/+15
| | | | metze
* tdb2: use ccan/err instead of err.hRusty Russell2012-06-0935-36/+11
| | | | | | | | | Solaris has no err.h, so use CCAN replacement. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Autobuild-User(master): Rusty Russell <rusty@rustcorp.com.au> Autobuild-Date(master): Sat Jun 9 12:07:15 CEST 2012 on sn-devel-104
* ccan: make failtest use ccan/err.Rusty Russell2012-06-092-1/+2
| | | | | | As per CCAN commit 48b700953f9c856102e91596103238f5da9ea079. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* ccan: import err module.from ccan revision ↵Rusty Russell2012-06-096-2/+348
| | | | | | | | 5add556a1cb64b49a664506aa76216d885b22c97 This allows us to avoid err.h in failtest. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* s3:smbd: change set_file_oplock() to return NTSTATUSMichael Adam2012-06-083-7/+9
| | | | | | | | Pair-Programmed-With: Volker Lendecke <vl@samba.org> Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Fri Jun 8 23:20:20 CEST 2012 on sn-devel-104
* s3: Replace an if with a boolean short circuitVolker Lendecke2012-06-081-5/+3
| | | | Signed-off-by: Michael Adam <obnox@samba.org>
* s3: Assigning ?True:False to a bool is a bit pointlessVolker Lendecke2012-06-081-3/+2
| | | | Signed-off-by: Michael Adam <obnox@samba.org>
* s3: Remove unnecessary ()Volker Lendecke2012-06-081-1/+1
| | | | Signed-off-by: Michael Adam <obnox@samba.org>
* s3: Replace an if with a boolean short circuitVolker Lendecke2012-06-081-5/+3
| | | | Signed-off-by: Michael Adam <obnox@samba.org>
* s3: Assigning ?True:False to a bool is a bit pointlessVolker Lendecke2012-06-081-2/+2
| | | | Signed-off-by: Michael Adam <obnox@samba.org>