summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Tidied up some error returns from printing calls. Still need to map UNIXJeremy Allison2000-08-233-10/+16
| | | | | errors to NT error for print job failure returns. Patch from John Reilly at HP. Jeremy.
* Documentation on NT_USER_TOKEN. Requested by Sander.Jeremy Allison2000-08-231-0/+5
| | | | Jeremy.
* Added code to do SID to uid/gid conversion. Needed for ACL support.Jeremy Allison2000-08-235-26/+266
| | | | Jeremy.
* Patch from John Reilly <jreilly@hp.com> for not processing duplicate filesTim Potter2000-08-221-0/+8
| | | | when moving printer driver to download area.
* Fix for safe_free freeing static strings. From Robert August Vincent, II.Jeremy Allison2000-08-211-5/+6
| | | | Jeremy.
* oops. must return "" string and length zero when strlen(filebuf) == 0Luke Leighton2000-08-181-13/+16
|
* fixed an off by one error where I was tromping on memoryGerald Carter2000-08-181-1/+1
| | | | | | | | when initializing a driver_info_3 struct. See spoolss_addprinterdriver() jerry
* fixed initialization errors (again!) I must have forgot toGerald Carter2000-08-181-0/+6
| | | | | | | | | check these in before. jerry
* getfileline() - line with length of zero -> filebuf[strlen(filebuf)-1]Luke Leighton2000-08-181-10/+13
| | | | is NOT ok.
* changing some debug message levelsGerald Carter2000-08-181-12/+12
| | | | j-
* Fix for Win9x driver downloads when information isGerald Carter2000-08-171-83/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | stored in the TDB. See the message I posted about this on samba-technical * If the admin does not desire the new NT print driver support, nothing needs to be done. All existing parameters work the same. * If the admin wants to take advantage of NT printer driver support but does not want to migrate the 9x drivers to the new setup, the leave the existing printers.def file. When smbd attempts to locate a 9x driver for the printer in the TDB and fails it will drop down to using the printers.def (and all associated parameters). The make_printerdef tool will also remain for backwards compatibility but will be moved to the "this tool is the old way of doing it" pile. * If the admin installs a 9x driver for a printer on a Samba host (in the printing TDB), this information will take precedence and the three old printing parameters will be ignored (including print driver location). * If an admin wants to migrate the printers.def file into the new setup, I can write a script to do this using rpcclient. The main problem is the driver namespace (we need the NT driver name first in order to be consistent). jerry
* added comment for my own memory purposesGerald Carter2000-08-171-0/+1
| | | | jerry
* hack for unmarshalling unistr's on machines with BIG_ENDIAN archGerald Carter2000-08-161-2/+19
| | | | | | | | | | I think we have a lot more of these bugs lurking (i'm fairly confident of it). jerry
* - fixed memcpy bug in copy_unistr2()Gerald Carter2000-08-161-7/+21
| | | | | | | | | - init_unistr2_from_unistr() does not NULL terminate the buffer --jerry
* fixed unitialized struct bug in enum_users (whatever it is called)Gerald Carter2000-08-161-1/+5
| | | | jerry
* fixed typo.Gerald Carter2000-08-161-1/+1
| | | | jerry
* fixed error in [public] spotted by Ron Alexander <rcalex@home.com>Gerald Carter2000-08-151-2/+1
| | | | | | | | changed to read only = yes jerry
* Merge of uninitialised variable fix from APPLIANCE_HEAD.Tim Potter2000-08-151-4/+1
|
* Tidied up extra ()'s.Jeremy Allison2000-08-151-12/+12
| | | | Jeremy
* Reverted the change Luke made. Removed IS_BITS_SET_XX macros.Jeremy Allison2000-08-142-18/+7
| | | | | | | | Do not re-add them. These macros are unsafe as they are not understood. Change all TNG code using them to correct '&' and '|' please. IS_BITS_SET_ALL was being used in cmd_interp.c when IS_BITS_SET_SOME should have been used. Jeremy.
* Merge.Tim Potter2000-08-141-2/+2
|
* fixed a few bugs in new_smb_io_relarraystr().Gerald Carter2000-08-141-2/+5
| | | | | | | Marshalling code path now uses spoolss_smb_io_unistr() also caught a NULL pointer case. i'll update TNG later.
* NT printer permissions test program.Tim Potter2000-08-143-0/+433
|
* restored IS_BITS_SET_xxx macros.Luke Leighton2000-08-141-0/+5
|
* hey, jerry: turns out you _have_ converted to get_safe_nt_errmsg!!!Luke Leighton2000-08-141-2/+4
| | | | | | [got confused with which way dirdiff was going :)]. ... but you forgot to update TNG's lib/cmd_interp.c...
* jeremy,Luke Leighton2000-08-141-11/+15
| | | | | | | | | | | | | | | | | please do not remove IS_BITS_SET_XXX macros just because you happen "not to like them". whilst still working on merging, you are not responsible for this code, therefore do not hinder its development whilst people are attempting to do merges. after the merge from TNG to cvs main is completed, you can do what the hell you like. thank you. jerry, please could you consider adding underlying routines (in this case get_safe_smb_errstr()) instead of reverting to a [less secure] previous coding method. thanks.
* minor formatting fixes.Gerald Carter2000-08-141-9/+9
| | | | jerry
* fix for new_smb_io_relarraystr() and new_smb_io_relstr()Gerald Carter2000-08-141-2/+2
| | | | | | | | | | | | | | to use spool_smb_io_unistr() as this does not call prs_align() befrore parsing the UNISTR. Parsing a void* buffer from an RPC should not be aligned on 4 byte boundaries. Don't think this change affects any marshalling code, only unmarshalling... jerry
* removed the prs_align in spoolss_smb_io_unistr() (JF, please check)Gerald Carter2000-08-121-3/+36
| | | | | | | | | | | | as it was throwing things off when parsing buffers passed in SPOOLSS RPCs fixed the unmarshalling of UNISTR arrays to be double NULL terminated jerry
* fixes to prs_unistr UNMARSHALLING only. Problem was due to talloc'sGerald Carter2000-08-121-29/+37
| | | | | | | | of 0 bytes. jerry
* FIxed some unmarshalling problems with relstr and unistr arraysGerald Carter2000-08-123-200/+163
| | | | jerry
* fixed unistr_to_ascii to deal with NULL src stringsGerald Carter2000-08-121-14/+14
| | | | jerry
* reworked talloc() to in order to help track down invalidGerald Carter2000-08-122-25/+32
| | | | | | | | | | | | | | | | | memory access. Tridge, I don't think using 0xdeadbeef for size allocations of 0 is going to work. I ended up having to use NULL as much code that works on UNISTR checks to see if the buffer ptr is NULL. So valid code ends up with a seg fault. Rather than rewriting it all, I added a DEBUG_TALLOC #ifdef in talloc.h that sets a macro BAD_PTR. This is the value assigned to ptr for an allocation of 0 bytes. jerry
* removed (void) typecast from SMB_ASSERTGerald Carter2000-08-121-1/+1
| | | | jerry
* Updated by Patrick Powell <papowell@lprng.org>John Terpstra2000-08-121-106/+195
|
* Fixed the problem with UNISTR marshalling in a buffer5 struct.Jeremy Allison2000-08-112-53/+25
| | | | | | | | | | The smb_io_unistr() code called a prs_align, this was not being counted in the size or taken account of in the offset calculation. Fixed size_ calculation to always return a size a multiple of 4 and also set the offset correctly. This fixes the problem I saw and will hopefully fix the problem HP reported. JF please check this change. Jeremy.
* First shot at actually *doing* WINS failover.Christopher R. Hertel2000-08-111-1/+8
| | | | | | | | | | | | | | | | | | If libsmb/namequery.c:name_query() times out while doing a non-broadcast query, I mark that WINS server 'dead'. Note that I don't try the new WINS server. I think I can get that working too. This is only for queries, not registrations. The biggest problem is that I may have to fiddle with the UNICAST SUBNET, but I need to check talk that over with someone (Jeremy?) before I hack at it. I can't actually test the above change, I'm 'fraid. I'm getting: 4 errors detected in the compilation of "rpc_server/srv_spoolss_nt.c". in head branch. Chris -)-----
* Fix case where volumename could be returned as UNIX charset or DOS codepageJeremy Allison2000-08-111-2/+6
| | | | | depending on where it came from. Jeremy.
* Added "add_printer_hook" call to update printer for Win9x clients.Jeremy Allison2000-08-101-62/+68
| | | | | Patch from John Reilly <jreilly@hp.com>. Jeremy.
* Tidied up security rights definitions.Jeremy Allison2000-08-107-39/+30
| | | | Jeremy.
* Removed requirement that sid have an owner before being interpreted.Jeremy Allison2000-08-101-18/+9
| | | | | Thanks to Elrond for pointing this out. Jeremy.
* Working on spoolss_getprinterdriver() as it does not display all theGerald Carter2000-08-102-6/+21
| | | | | | | | dependentfiles. jery
* working on the unmarshalling of dependentfiles to a DRIVER_INFO_3Gerald Carter2000-08-101-2/+9
| | | | | | | | | | struct. Not wuite there. jerry
* code formatting cleanupGerald Carter2000-08-101-6/+0
| | | | jerry
* deal with allocation size of 0 in prs_unistr when UNMARSHALLINGGerald Carter2000-08-101-24/+30
| | | | jerry
* Deal will NULL UNISTR in unistr_to_asciiGerald Carter2000-08-101-13/+21
| | | | jerry
* talloc returns 0xdeadbeef when asked to allocate 0 bytesGerald Carter2000-08-101-19/+29
| | | | jerry
* Needed to add the SHARED attribute bit when creating a printerGerald Carter2000-08-102-10/+15
| | | | | | | | | | | | on a Samba host. Also needed to add an option to pass the share name (printer name) on the command line. And fixed the checking of the return code for spoolss_r_addprinterex() jerry
* Fixed bug in new printer access check code. If PRINTER_ALL_ACCESS is changedJeremy Allison2000-08-091-0/+10
| | | | | | in the ACE's the same thing must be done in the desired access or they will never match. This took me a while to find... :-). Jeremy.
* make protoGerald Carter2000-08-091-2/+2
|