| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
errors to NT error for print job failure returns. Patch from John Reilly at HP.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
when moving printer driver to download area.
|
|
|
|
| |
Jeremy.
|
| |
|
|
|
|
|
|
|
|
| |
when initializing a driver_info_3 struct. See spoolss_addprinterdriver()
jerry
|
|
|
|
|
|
|
|
|
| |
check these in before.
jerry
|
|
|
|
| |
is NOT ok.
|
|
|
|
| |
j-
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stored in the TDB. See the message I posted about
this on samba-technical
* If the admin does not desire the new NT print driver
support, nothing needs to be done. All existing
parameters work the same.
* If the admin wants to take advantage of NT printer
driver support but does not want to migrate the 9x drivers
to the new setup, the leave the existing printers.def
file. When smbd attempts to locate a 9x driver for the
printer in the TDB and fails it will drop down to
using the printers.def (and all associated parameters).
The make_printerdef tool will also remain for backwards
compatibility but will be moved to the "this tool is the
old way of doing it" pile.
* If the admin installs a 9x driver for a printer on
a Samba host (in the printing TDB), this information will
take precedence and the three old printing parameters
will be ignored (including print driver location).
* If an admin wants to migrate the printers.def file into
the new setup, I can write a script to do this using
rpcclient. The main problem is the driver namespace
(we need the NT driver name first in order to
be consistent).
jerry
|
|
|
|
| |
jerry
|
|
|
|
|
|
|
|
|
|
| |
I think we have a lot more of these bugs lurking (i'm fairly
confident of it).
jerry
|
|
|
|
|
|
|
|
|
| |
- init_unistr2_from_unistr() does not NULL terminate
the buffer
--jerry
|
|
|
|
| |
jerry
|
|
|
|
| |
jerry
|
|
|
|
|
|
|
|
| |
changed to read only = yes
jerry
|
| |
|
|
|
|
| |
Jeremy
|
|
|
|
|
|
|
|
| |
Do not re-add them. These macros are unsafe as they are not understood.
Change all TNG code using them to correct '&' and '|' please.
IS_BITS_SET_ALL was being used in cmd_interp.c when IS_BITS_SET_SOME
should have been used.
Jeremy.
|
| |
|
|
|
|
|
|
|
| |
Marshalling code path now uses spoolss_smb_io_unistr()
also caught a NULL pointer case.
i'll update TNG later.
|
| |
|
| |
|
|
|
|
|
|
| |
[got confused with which way dirdiff was going :)].
... but you forgot to update TNG's lib/cmd_interp.c...
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
please do not remove IS_BITS_SET_XXX macros just because you happen
"not to like them". whilst still working on merging, you are not
responsible for this code, therefore do not hinder its development
whilst people are attempting to do merges. after the merge from
TNG to cvs main is completed, you can do what the hell you like.
thank you.
jerry,
please could you consider adding underlying routines (in this case
get_safe_smb_errstr()) instead of reverting to a [less secure]
previous coding method. thanks.
|
|
|
|
| |
jerry
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to use spool_smb_io_unistr() as this does not call prs_align()
befrore parsing the UNISTR.
Parsing a void* buffer from an RPC should not be aligned
on 4 byte boundaries. Don't think this change affects
any marshalling code, only unmarshalling...
jerry
|
|
|
|
|
|
|
|
|
|
|
|
| |
as it was throwing things off when parsing buffers passed in SPOOLSS
RPCs
fixed the unmarshalling of UNISTR arrays to be double NULL terminated
jerry
|
|
|
|
|
|
|
|
| |
of 0 bytes.
jerry
|
|
|
|
| |
jerry
|
|
|
|
| |
jerry
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
memory access.
Tridge, I don't think using 0xdeadbeef for size allocations
of 0 is going to work. I ended up having to use NULL
as much code that works on UNISTR checks to see if the buffer ptr
is NULL. So valid code ends up with a seg fault.
Rather than rewriting it all, I added a DEBUG_TALLOC
#ifdef in talloc.h that sets a macro BAD_PTR.
This is the value assigned to ptr for an allocation of 0 bytes.
jerry
|
|
|
|
| |
jerry
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The smb_io_unistr() code called a prs_align, this was not being
counted in the size or taken account of in the offset calculation.
Fixed size_ calculation to always return a size a multiple of 4
and also set the offset correctly. This fixes the problem I saw
and will hopefully fix the problem HP reported. JF please check
this change.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If libsmb/namequery.c:name_query() times out while doing a non-broadcast
query, I mark that WINS server 'dead'. Note that I don't try the new
WINS server. I think I can get that working too.
This is only for queries, not registrations. The biggest problem is that
I may have to fiddle with the UNICAST SUBNET, but I need to check talk
that over with someone (Jeremy?) before I hack at it.
I can't actually test the above change, I'm 'fraid. I'm getting:
4 errors detected in the compilation of "rpc_server/srv_spoolss_nt.c".
in head branch.
Chris -)-----
|
|
|
|
|
| |
depending on where it came from.
Jeremy.
|
|
|
|
|
| |
Patch from John Reilly <jreilly@hp.com>.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
Thanks to Elrond for pointing this out.
Jeremy.
|
|
|
|
|
|
|
|
| |
dependentfiles.
jery
|
|
|
|
|
|
|
|
|
|
| |
struct. Not wuite there.
jerry
|
|
|
|
| |
jerry
|
|
|
|
| |
jerry
|
|
|
|
| |
jerry
|
|
|
|
| |
jerry
|
|
|
|
|
|
|
|
|
|
|
|
| |
on a Samba host. Also needed to add an option to pass the share
name (printer name) on the command line.
And fixed the checking of the return code for spoolss_r_addprinterex()
jerry
|
|
|
|
|
|
| |
in the ACE's the same thing must be done in the desired access or they will
never match. This took me a while to find... :-).
Jeremy.
|
| |
|