| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
3_0 and
3_0_24 because I was explicitly asked to, although this needs close
review. Jeremy, I'm sure you will check this thoroughly :-)
In reply_open_and_X the separate "size" variable kills the calculation of the
SPARSE flag returned to the client in the attrib field. In getpathinfo we do
it correctly, and RAW-OPEN (correctly) complains about the difference.
Add the "set the write time" to mknew and create.
For trans2open we were missing the "ofun == 0" ->
NT_STATUS_OBJECT_NAME_COLLISION case, and we dropped the status returned in
favor of ACCESS_DENIED once too many.
Last change is a fix to trans2open: We were returning the attributes given by
the client, not the attributes of the new file.
Volker
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
the child domain cannot always resolve SIDs in sibling domains.
Windows tries to contact a DC in its own domain and then the root
domain in the forest. This async changes makes winbindd's name2sid()
call do the same.
|
| | |
|
| |
| |
| |
| | |
so apps will know which one to look for,
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
check_is_at_open==False,
remove that parameter.
Volker
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The only error path of can_delete() that we're interested in ntcreate&x is the
one of can_delete_file_in_directory(), so call that directly.
The only other one where we might get a NT_STATUS_ACCESS_DENIED is from the
lstat in can_delete, but this is covered later in the open_directory and
open_file_ntcreate calls. open_directory does a stat() in the open case which
also covers the (potential) symlink, and open_file_ntcreate does the open(2)
itself, so this should also work.
This makes can_delete() static to reply.c.
Volker
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Jeremy, please check this.
Thanks,
Volker
|
| |
| |
| |
| |
| |
| | |
Add lots of TODOs :-)
Volker
|
| |
| |
| |
| | |
metze
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
survives the
first of the raw-notify subtests, the one-level test_notify_dir without any
flags around yet.
The tricky part was getting the data structures right, I hope the next tests
don't let that fall over.
fsp->notify is now by default NULL, meaning that nobody has issued a
changenotify call. This means nobody is interested in changes for this
directory.
If that has happened, notify_change_buf collects the changes if no current
request is outstanding, and it collects the requests if no change has happened
since the last request.
Happy New Year, somewhere on this planet it's already 2007 :-)
Volker
P.S: Jeremy, there's a question for you in smbd/files.c line 367.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
call_nt_transact_notify_change() is now sync if there are changes around.
A notify_message does a direct reply from within the message, so
process_pending_change_notify_queue is not needed anymore for samba-generated
events. Next step is to restructure the kernel-mechanisms to generate
messages.
Volker
|
| | |
|
| |
| |
| |
| |
| |
| | |
is (effectively) in libc. Convert AC_LIBTESTFUNC to use the mystically
undocumented m4_ifval, which fixes some quoting problems when
providing shell code for the if-true and if-false branches.
|
| |
| |
| |
| | |
libSystem on Mac OS X.
|
| |
| |
| |
| | |
libSystem on Mac OS X.
|
| | |
|
| |
| |
| |
| |
| | |
for this error code.
Jeremy.
|
| |
| |
| |
| |
| |
| | |
modified). Ensure "hide unXXX" parameters don't
hide MSDFS links. Bug #3319.
Jeremy.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
As discussed with jerry at the CIFS conf: overriding the
administrator's wishes from the krb5.conf has only every given me
segfaults. We suggest leaving this up to the defaults from the
libraries anyway.
Andrew Bartlett
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Checking in because Jeremy was bugging me. Potentially this becomes quite
intrusive, I'm not sure if I should open a temporary branch for this.
Jeremy, Jerry, do you think 3_0 is the right place for this?
Volker
|
| | |
|
| |
| |
| |
| | |
metze
|
| |
| |
| |
| | |
metze
|
| |
| |
| |
| |
| |
| |
| |
| | |
this is done by libreplace...
this hopefully fixes the build on HPUX 11.00
metze
|
| |
| |
| |
| |
| |
| |
| | |
only try to find dlfcn.h if the dlopen symbol was found,
it hopefully fixes systems where dlfcn.h but no library with dlopen
metze
|
| |
| |
| |
| | |
Jeremy.
|
| |
| |
| |
| |
| |
| |
| | |
wcards. I had forgotten this and had refused to allow
dest to contain wcards. We now pass all the normal
Samba4 smbtorture RAW-RENAME tests.
Jeremy
|
| |
| |
| |
| |
| |
| | |
from open_file_ntcreate make sure we return it on rename
error.
Jeremy.
|
| |
| |
| |
| |
| |
| | |
being returned (false positive). Up debug
level on "open_directory" message.
Jeremy.
|
| |
| |
| |
| |
| |
| |
| | |
by ensuring we pass in a valid src_len (or zero when appropriate).
Volker is correct in that this is a *horrible* interface and he is
now free to generally clean it up everywhere :-). Go for it Volker !
Jeremy.
|
| |
| |
| |
| |
| | |
before checking length. Found by Volker.
Jeremy.
|
| |
| |
| |
| |
| | |
found by Volker.
Jeremy
|
| |
| |
| |
| |
| |
| |
| | |
This involved passing the dirname as argument to a few routines instead of
calling parent_dirname() deep down.
Volker
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
together.
Jeremy, I'm 100% sure you watch me closely here, I count on you :-)
Volker
|
| |
| |
| |
| |
| |
| |
| |
| | |
name-based (for
directory opens) routines.
Volker
|
| |
| |
| |
| |
| |
| |
| |
| | |
open_directory
we want to follow symlinks.
Volker
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
regarding
error messages: We relied upon a stat that a directory did not exist to later
on then do the mkdir or not. This does the mkdir directly and copes with a
potential error.
The second one is more important: It's possible with Samba 3 to do a
ntcreate&x with NTCREATEX_OPTIONS_DIRECTORY and we happily do a NT_STATUS_OK.
Also move up the use_nt_status() logic a bit. I think this does not belong
into the core routines, the smb server as such should take care of it.
Jeremy, do you think this should go to 3.0.24?
I'll update samba4torture when the build farm has picked up this checkin.
Volker
|