| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
all the *HORRIBLE* DBG_RW_XXX and RW_XXX macros from include/byteorder.h.
They were macros that included macros that had conditional macros included.
No one understood them (they were the cause of most of the bigendian issue
bugs). Finally, I went into parse_prs.c and inlined all of that stuff with
regular function calls. They're understandable, they're easy to edit and
they don't include macros !
JF - please look at the one comment I added (JF PLEASE CHECK). I have
tested this partly with IRIX (a bigendian system) running with AS/U on
a Solaris box in SGI's lab, and I've also confirmed these new changes
work with W2K (vmware) but there may be the odd bug lurking. Herb, if
you could re-checkout and test again with this code that would help.
I'm not going to sync these changes with HEAD until I know they're
completely correct (which I believe they are).
Jeremy
|
|
|
|
|
|
|
|
|
|
|
| |
byte-swap uint32 arrays (SIDS). Restored them to the original values - this
wouuld have caused the AS/U work that Herb and I did to break. So I expanded
(BY HAND !!! GRRR!!!!) the *stupid* DBG_RW_XXX macros for unicode strings,
and made sure that all places marshalling uint16 arrays as unicode strings
(spoolss) called the new function which (hopefully) correctly handles byte
swapping for big-endian RPC machines. I'm now off to the SGI lab (this is no
way to spend a friday night :-) to check with Herb if this works.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
smbd/notify_kernel.c: This code was wrong I believe. It was structured to only
return a changenotify event on being called from timeout processing (t != 0).
The kernel changenotify events should fire on *asynchronous* processing (EINTR
return from select caused by the realtime signal delivery) with t == 0.
Reported by Juergen Hasch (Hasch@t-online.de).
ANDREW PLEASE CHECK THIS !
Currently the hash style changenotify is done on async processing as well
as timeout processing. As this is expensive we may want to revisit doing this
and maybe set it to fire only on timeout processing.
Jeremy.
|
|
|
|
| |
compiles.
|
| |
|
| |
|
|
|
|
| |
Jeremy.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when copying to a full disk problem, I discovered that we were not allowing
the delete on close flag to be set properly, this led to other things, and
after investigation of the proper delete on close semantics and their relationship
to the file_share_delete flag I discovered there were some cases where we
weren't doing the deny modes properly. And this after only 5 years working
on them..... :-) :-).
So here's the latest attempt. I realised the delete on close flag needs to
be set across all smbds with a dev/ino pair open - in addition, the delete
on close flag, allow share delete and delete access requested all need to
be stored in the share mode tdb.
The "delete_on_close" entry in the fsp struct is now redundant and should
really be removed. This may also mean we can get rid of the "iterate_fsp"
calls that I didn't like adding in the first place. Whilst doing this patch,
I also discovered we needed to do the se_map_generic() call for file opens
and POSIX ACL mapping, so I added that also.
This code, although ugly, now passes the deny mode torture tests plus the
delete on close tests I added. I do need to add one more multiple connection
delete on close test to make sure I got the semantics exactly right, plus we
should also (as Andrew suggested) move to random testing here.
The good news is that NT should now correctly delete the file on disk
full error when copying to a disk :-).
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
| |
this and the FILE_SHARE_DELETE flag exactly. The bad news is it means our
share mode handling is broken (again :-).
Jeremy.
|
|
|
|
|
| |
delete test explicit.
Jeremy.
|
|
|
|
|
| |
behaves in this situation.
Jeremy.
|
| |
|
| |
|
|
|
|
| |
updates from Jim McDonough @ IBM
|
|
|
|
|
|
| |
vfs object
vfs options
os2 driver map
|
| |
|
|
|
|
| |
using 'rpcclient setdriver'
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
Used in smbtorture mods. Re-cast cli_nt_create() as a call to cli_nt_create_full().
Jeremy.
|
|
|
|
| |
Jeremy.
|
| |
|
|
|
|
|
|
|
|
|
| |
parameter in HEAD. I do not want to maintain two sets of docs
so HEAD-only parameters are flagged in smb.conf.
jerry
|
|
|
|
|
| |
be returned.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two things in the commit...
o rename of new_smb_io_* to smb_io_* for consistency sake.
The latter was the way in whic the majority of related
fnuctions were named
o added 'setdriver <printer> <driver>' to rpcclient. This means
an admin can install the printer driver once and loop over
/etc/printcap to set the driver for all printers :-) Yeah!
Caveats...I know know how to remove the various memory leaks I have
introduced into rpcclient. These will be fixed after I update the
documentation.
|
|\ |
|
| | |
|
| |
| |
| |
| | |
convert names to rids yet.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
reporting imaginary "default" inheritable ACLs on directories, otherwise,
when you add an entry and click on apply without noticing there's no
default entry associated with it, it applies a null acl on the files
within the directory (hey, that's what you told NT you wanted, right ! :-).
Also ensure that minimum permissions for a directory are r-x for owner,
not just r--.
Jeremy.
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
Also fixed an error return for smbc_rmdir so that we can distinguish
between EACCES and ENOTEMPTY
|
| |
| |
| |
| | |
Jeremy.
|
| |
| |
| |
| | |
Jeremy
|
| |
| |
| |
| |
| |
| | |
sun1.samba.org is down at the moment so I can't test the compile on this. I'm
sure Solaris people using quotas will scream if I've meesed anything up :-).
Jeremy.
|
| |
| |
| |
| | |
Jeremy.
|
| |
| |
| |
| |
| |
| | |
problems with smbd failing to create a log file. If we can't create a log
file keep using the old file.
Jeremy.
|
| |
| |
| |
| | |
Jeremy.
|
| |
| |
| |
| | |
Jeremy.
|
| | |
|
| |
| |
| |
| |
| | |
connection fail.
Jeremy.
|
| |
| |
| |
| |
| |
| |
| | |
smb.conf
file in utf8.
Jeremy.
|
| |
| |
| |
| | |
Jeremy.
|
| |
| |
| |
| | |
Jeremy.
|
| |
| |
| |
| |
| | |
any code that could modify errno is called.
Jeremy.
|
| |
| |
| |
| | |
Jeremy.
|
| |
| |
| |
| |
| | |
From Robert Montjoy <Rob_Montjoy@ECECS.UC.EDU>.
Jeremy.
|
| |
| |
| |
| |
| | |
to the places where [f]chmod_acl is called instead.
Jeremy.
|