summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* s3-docs: Fix bug #7908.Karolin Seeger2011-10-111-1/+1
| | | | | | | | | Fix typo. Thanks to John Bradshaw for reporting! Karolin (cherry picked from commit 8aaa27754663a55f45facc18783eea458205d8a5)
* Bug 7551: Return error of cli_push when 'put - /some/file' is usedBram2011-10-081-1/+1
| | | | | | Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Sep 29 23:47:02 CEST 2011 on sn-devel-104 (cherry picked from commit d883cc664cac81633a60e5b04f99f23a3577ae65)
* Fix bug #8509 - Read-only handles on SAMR allow SAMR_DOMAIN_ACCESS_CREATE_USER.Jeremy Allison2011-10-081-3/+8
| | | | | | | | | Not a security issue as we also check inside _samr_CreateUser2. Thanks to Andreas Schneider <asn@samba.org> for finding and testing this. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Oct 7 21:51:27 CEST 2011 on sn-devel-104 (cherry picked from commit c80ba57169cee2ec66e8afe3616956c17958a3ae)
* Fix bug #8507 - smbd doesn't correctly honor the "force create mode" bits ↵Jeremy Allison2011-10-081-6/+6
| | | | | | | | | | from a cifsfs create. Don't manipulate the new_dos_attributes bits until we know it's not a POSIX open. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Oct 5 01:19:17 CEST 2011 on sn-devel-104 (cherry picked from commit f93fd128eb623e324459806a34052bd40afe82e5)
* Second part of fix for bug #8443 - Default user entry is set to minimal ↵Jeremy Allison2011-10-081-8/+11
| | | | | | | | | | permissions on incoming ACL change with no user specified. Be smarter about setting default permissions when a ACL_USER_OBJ isn't given. Use the principle of least surprises for the user. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Sep 9 00:26:08 CEST 2011 on sn-devel-104 (cherry picked from commit e30b8c72def13e2abc14858ea64eb849ea665b80)
* First part of fix for bug #8443 - Default user entry is set to minimal ↵Jeremy Allison2011-10-081-58/+2
| | | | | | | | permissions on incoming ACL change with no user specified. create_default_mode() is not needed - it's taken care of by code inside ensure_canon_entry_valid(). (cherry picked from commit 793bd527fdd0b188aba8f3b4bffd8fa8f69a9cd1)
* Part 3 of bugfix for bug #7509 - smb_acl_to_posix: ACL is invalid for set ↵Jeremy Allison2011-10-081-7/+6
| | | | | | | | | (Invalid argument) Don't call check_owning_objs() to convert ACL_USER->ACL_USER_OBJ and AC_GROUP->ACL_GROUP_OBJ for default (directory) ACLs, we do this separately inside ensure_canon_entry_valid(). (cherry picked from commit c528fc5cacaae7e0e83041eb98150052b436071e)
* Part 2 of bugfix for bug #7509 - smb_acl_to_posix: ACL is invalid for set ↵Jeremy Allison2011-10-081-0/+38
| | | | | | | | (Invalid argument) Only map CREATOR_OWNER/CREATOR_GROUP to ACL_USER_OBJ/ACL_GROUP_OBJ in a default(directory) ACL set. (cherry picked from commit a5038ace24559bb02eec8262d3af5b5e78634d16)
* Part 1 of bugfix for bug #7509 - smb_acl_to_posix: ACL is invalid for set ↵Jeremy Allison2011-10-081-72/+0
| | | | | | | | (Invalid argument) Remove the code I added for bug "6878 - Cannot change ACL's inherit flag". It is incorrect and causes the POSIX ACL ACL_USER_OBJ duplication. (cherry picked from commit 2b935b49f3d975759eb1cbcf2b11bf7c9d982804)
* Fix bug #8458] - IE9 on Windows 7 cannot download files to samba 3.5.11 shareJeremy Allison2011-10-082-0/+26
| | | | | Handle the SECINFO_LABEL flag in the same was as Win2k3. (cherry picked from commit 893497ee169ba5455cd70458a339e60544e171d7)
* Fix bug #8493 - DFS breaks zip file extracting unless "follow symlinks = no" setJeremy Allison2011-10-031-11/+2
| | | | | | | | If a client sends a mangled name as part of a DFS path, use the post-mangled name for the pathname walk, not the mangled name. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Oct 1 00:45:59 CEST 2011 on sn-devel-104
* s3-docs: Fix typos.Karolin Seeger2011-10-033-3/+3
| | | | | | | | | | Thanks to Samba-JP oota <ribbon@samba.gr.jp> for reporting! Karolin Autobuild-User: Karolin Seeger <kseeger@samba.org> Autobuild-Date: Fri Sep 30 23:12:35 CEST 2011 on sn-devel-104 (cherry picked from commit 5c569a97ab477a324a96aae7f58770ccbe2572de)
* s3:smb2_server: SMB2_OP_CANCEL requests don't have to be signedStefan Metzmacher2011-09-301-0/+2
| | | | | | | | | | metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu Sep 29 02:58:41 CEST 2011 on sn-devel-104 (cherry picked from commit ea00f0e452f64868fdc78cf0dc8e9ce3af19fe32) Fix bug #8503 (The SMB2 server should ignore signing on CANCEL requests).
* s3-docs: Remove "experimental" label on VFS ACL modulesKarolin Seeger2011-09-282-8/+0
| | | | | | in the documentation also (bug #8494). Karolin
* These modules are no longer experimental but production-ready (especially ↵Jeremy Allison2011-09-282-4/+0
| | | | | | | | | | the acl_xattr code). Remove the "experimental" tag. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Tue Sep 27 21:00:12 CEST 2011 on sn-devel-104 (cherry picked from commit fa2236c066890b687483408ed0d82a4bb1f95157) Fix bug #8494 (Remove "experimental" label on VFS ACL modules).
* Fix bug 8480 - acl_xattr can free an invalid pointer if no blob is loaded.David Disseldorp2011-09-281-1/+1
| | | | | | Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Sep 23 22:20:55 CEST 2011 on sn-devel-104 (cherry picked from commit ca8c25abebb8715176f68be9916217db9a8400dd)
* s3:smbd: don't call smbd_terminate_connection in smb2_validate_message_id() ↵Stefan Metzmacher2011-09-281-2/+3
| | | | | | | | | | | | (bug #8476) Only return false and the caller will terminate the connection. metze (cherry picked from commit 02d83d8fd4d21825110fd7da1ccb570a26e66ca6) Part of a fix for bug #8476 (Samba asserts when SMB2 client breaks the crediting rules.)
* Fix bug #8476 - Samba asserts when SMB2 client breaks the crediting rules.Jeremy Allison2011-09-281-1/+6
| | | | | | | | Just drop the connection, not SMB_ASSERT. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Sep 22 19:41:31 CEST 2011 on sn-devel-104 (cherry picked from commit d50fa9c21e1c3b6f7126c33e24966099c7567225)
* s3-libnet: allow to use default krb5 ccache in libnet_Join/libnet_Unjoin.Günther Deschner2011-09-282-31/+5
| | | | | | | | | We force using a MEMORY ccache though in the wkssvc server. Guenther Part of a fix for bug #7465 (net ads join -k didn't work if KRB5CCNAME is not set).
* Revert "s3-libnet: allow to use default krb5 ccache in ↵Karolin Seeger2011-09-262-4/+30
| | | | | | | | libnet_Join/libnet_Unjoin." This reverts commit 050123d9b6ae8fd69ed58380d8bdf210c38556fc. This commit seems to break the build.
* Fix bug #8473 - smb2_find uses a hard coded max reply size of 0x10000 ↵Jeremy Allison2011-09-261-1/+1
| | | | | | | instead of smb2_max_trans. Use lp_smb2_max_trans() instead of 0x10000. (cherry picked from commit e68ebe600d9349e16e83aeb8e6ae8647c117d098)
* s3-netapi: allow to use default krb5 credential cache for libnetapi users.Günther Deschner2011-09-262-7/+23
| | | | Guenther
* s3-libnet: allow to use default krb5 ccache in libnet_Join/libnet_Unjoin.Günther Deschner2011-09-262-30/+4
| | | | | | We force using a MEMORY ccache though in the wkssvc server. Guenther
* s3-docs: document -k switch in net manpage.Günther Deschner2011-09-261-0/+1
| | | | | | | | Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue Sep 20 15:47:00 CEST 2011 on sn-devel-104 (cherry picked from commit 8dda773bd7eea1d163282b1f3c5e90cbff8a1003)
* Fix bug #8477 - Map to guest can return uninitialized blob of data.Jeremy Allison2011-09-261-1/+3
| | | | | | | | Found by Codenomicon at SNIA SDC. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Sep 23 03:19:46 CEST 2011 on sn-devel-104 (cherry picked from commit f0f91d0117b2ccf778382e61a411b5e4f0ea2b14)
* s3-registry: fix bug #8401 - registry/reg_format.c must include includes.h.Günther Deschner2011-09-221-0/+1
| | | | | Guenther (cherry picked from commit e00a6c40bf13d9c1225022129e4cb1d617aa49bf)
* Fix bug #8453 - smbclient segfaults when dialect option -m is used for ↵Jeremy Allison2011-09-221-0/+13
| | | | | | legacy dialects Ensure we have valid pointers.
* WHATSNEW: Add changes since 3.6.0.Karolin Seeger2011-09-161-2/+65
| | | | | | To be completed. Karolin
* Fix bug #8229 - git patch attached against 3.6.0-rc2 to fix 'widelinks' ↵Jeremy Allison2011-09-155-1/+68
| | | | | | | | | regression intro'd in 3.2 Add "allow insecure widelinks" to re-enable the ability (requested by some sites) to have "widelinks = yes" and "unix extensions = yes". Based on an original patch by Linda Walsh <samba@tlinx.org>
* Fix bug 8429 - Compound SMB2 requests on an IPC connection can corrupt the ↵Jeremy Allison2011-09-151-12/+17
| | | | | | | | reply stream. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Aug 31 21:18:11 CEST 2011 on sn-devel-104 (cherry picked from commit 786fe9fab223723e4d2340f285592b2a44945d73)
* s3-spoolss: Fix bug #8351 forms migration.Andreas Schneider2011-09-151-0/+4
| | | | | | Don't fail if the form already exists (or is builtin now). Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:libsmb: check the wct of the incoming SMBnegprot responsesStefan Metzmacher2011-09-151-0/+10
| | | | | | | | metze Fix bug #8452 (negprot reply needs to check vwv vector length). The corresponding commit in master is 85332eb1c721d585e1a33101bddafdca4073e10f.
* s3: Do not fork the echo handler for smb2Volker Lendecke2011-09-151-1/+2
| | | | | | | | | | | | | | | | | | | If a smb1 negprot negotiated smb2 we forked the echo responder. This will eventually lead to a panic from [2011/08/30 10:33:29.212578, 0, pid=3846917] smbd/smb2_server.c:243(smbd_smb2_request_create) Invalid SMB packet: first request: 0x0009 because from the echo responder we always read using the normal smb1 protocol handling routine. If that is a bit down the smb2 stream, we get a non-negprot packet and panic. BTW, the echo responder is not required for smb2 anyway, Microsoft confirmed that it probes the server liveness using TCP keepalives and not smb2 echo requests. The last 2 patches address bug #8334 (smb2: smbd logs Invalid SMB packet: first request: 0x0008 and crashes).
* s3: Fork the echo handler only after SMB1 negprot is doneVolker Lendecke2011-09-153-7/+8
| | | | | | | | This enables activating the echo responder also if SMB2 is enabled, albeit it will only be used for SMB1 at this moment. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri May 20 15:06:03 CEST 2011 on sn-devel-104
* s3-spoolss: Fix bug #8236 empty notify servername.Andreas Schneider2011-09-151-0/+9
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:smb2_server: keep compound_related on struct smbd_smb2_requestStefan Metzmacher2011-09-152-4/+4
| | | | | | | | metze (cherry picked from commit 0d450d166bab952daf37d922e5c2e5cac16f1cc3) The last 3 patches address bug #8407 (SMB2 server can return requests out-of-order when processing a compound request).
* Based on metze's fix for Bug 8407 - SMB2 server can return requests ↵Jeremy Allison2011-09-152-2/+39
| | | | | | out-of-order when processing a compound request. (cherry picked from commit 726b4685aa25b0b3b4470bfec5d514fb2db7a95e)
* s3:smb2_server: make sure we prefer responses over requests on the client socketStefan Metzmacher2011-09-151-12/+52
| | | | | | | | metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Fri Aug 12 16:46:43 CEST 2011 on sn-devel-104 (cherry picked from commit 42cde0480bd6a5e2dddaa66917e1fa71e6a4edcd)
* Fix bug 8433, segfault in iconv.cVolker Lendecke2011-09-011-1/+0
| | | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Thu Sep 1 18:25:34 CEST 2011 on sn-devel-104 (cherry picked from commit 1d4de78f567e908e0acc218630fceb0884b07d65)
* s3:smb2 fix Bug 8428 - wrong reply to DHnC (durable handle reconnect)Christian Ambach2011-08-301-6/+6
| | | | | | | | | | | | | According to [MS-SMB2] 3.3.5.9.7 (http://msdn.microsoft.com/en-us/library/cc246784%28v=PROT.13%29.aspx), smbd must reply with NT_STATUS_OBJECT_NAME_NOT_FOUND as it does not support durable file-handles yet. I have seen w2k8r2 running xcopy /C ending up in an endless loop trying to get back the original file handle from smbd sending the same requests over and over. Metze, Jeremy, please check!
* s3: Fix getent group if trusted domains are not reachableVolker Lendecke2011-08-301-2/+7
| | | | Fix bug #8420 (wb_group_members: non-resistance against garbage).
* Fix bug 8412 - Microsoft Office 2007 (Microsoft Word) fails to save as on a ↵Jeremy Allison2011-08-302-6/+46
| | | | Samba share with SMB2. (cherry picked from commit dec3b21cd1737b317749e7ebced5aa1c2115ebdf)
* s3: Use sys_read in fork_domain_childVolker Lendecke2011-08-301-1/+1
| | | | | | | | | | | | I've seen [2011/08/26 01:44:10.872057, 1] winbindd/winbindd_dual.c:1336(fork_domain_child) fork_domain_child: Could not read child status: nread=-1, error=Interrupted system call on a customer box. Not good. (cherry picked from commit 964e809ce2069ad888e0fb12dfe51bac5a461508) The last 3 patches address bug #8409 (f7d97868 created a new race condition).
* s3: Use sys_write in fork_domain_childVolker Lendecke2011-08-301-1/+1
| | | | | | | | Counterpart for last checkin. A lot less likely, but not impossible in a child. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri Aug 26 13:14:27 CEST 2011 on sn-devel-104 (cherry picked from commit e0e3d215b1902ecbeb3d469af9a196856711921e)
* s3: Fix a winbind race leading to 100% CPUVolker Lendecke2011-08-301-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | This fixes a race condition that leads to the winbindd_children list becoming corrupted. It happens when on a busy winbind SIGCHLD is a bit late. Imagine a winbind with multiple requests in the queue for a single child. Child dies, and before the SIGCHLD handler is called we find the socket to be dead. wb_child_request_done is called, receiving an error from wb_simple_trans_recv. It closes the socket. Then immediately the wb_child_request_trigger will do another fork_domain_child before the signal handler is called. This means that we do another fork_domain_child, we have child->sock==-1 at this point. fork_domain_child will do a DLIST_ADD(winbindd_children, child) a second time where the child is already part of that list. This corrupts the list. Then the signal handler kicks in, spinning in for (child = winbindd_children; child != NULL; child = child->next) { forever. Not good. This patch makes sure that both conditions (sock==-1 and not part of the list) for a winbindd_child struct match up. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri Aug 26 18:51:24 CEST 2011 on sn-devel-104 (cherry picked from commit ed058f4dc3e059967f3c0538bc220866e9c63588)
* s3: Fix the build of vfs_aixacl2.cSATOH Fumiyasu2011-08-301-0/+1
| | | | | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Thu Aug 25 23:06:12 CEST 2011 on sn-devel-104 (cherry picked from commit faa769ec19b6486675048734837a6e2237d6f0a4) Fix bug #8390 (vfs_aixacl2.c needs system/filesys.h).
* s3: Fix bug 8385Volker Lendecke2011-08-301-26/+14
| | | | | | | | | | | | | Poll and select behave differently regarding error handling. When doing the connect(2), we can not rely on poll telling us both readability and writability upon error. Just always try a second connect(2). At least on Linux it returns 0 when it succeeded. Signed-off-by: Jeremy Allison <jra@samba.org> Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Aug 25 19:39:12 CEST 2011 on sn-devel-104 (cherry picked from commit 50e30afa608dfdeae8a260730ead9761ed424dad)
* Fix bug Bug 8422 - Infinite loop in ACL module code.Jeremy Allison2011-08-301-1/+1
| | | | | | Missing assignment means this loop will never terminate. Need to be applied to 3.5.x and 3.6.1. (cherry picked from commit 218cccfdf1820a9840a5cbc7df3915b6b58a762d)
* Fix bug #8395 - optimize serverid_exists() for Solaris.Ira Cooper2011-08-231-1/+5
| | | | | | | | | | | | | | jra asked: Do you have any idea on how many calls it saves, and what help the optimization gives ? As far as calls: Not 100% sure, dtrace pointed the issue out to me, and when I saw 10-50%(Or more), I looked for an easy fix. The real expense here is the fnctl locks on the database. That's pretty painful. 1000ns per call, and probably 3-4 calls in that chain. So it doesn't take much to come out ahead was my math.
* talloc: check block count aftter references testAndrew Tridgell2011-08-201-0/+1
| | | | | | | | Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit 73677875b46251f59b66c9713f1decc89bd2ea3e) The last 7 patches address bug #8384 (Windows XP clients seem to crash smbd process every once in a while).
generated by cgit (git 2.34.1) at 2025-09-01 10:24:48 +0000