| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
| |
from a cifsfs create.
Don't manipulate the new_dos_attributes bits until we know it's not a POSIX open.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct 5 01:19:17 CEST 2011 on sn-devel-104
(cherry picked from commit f93fd128eb623e324459806a34052bd40afe82e5)
(cherry picked from commit 5253d36689115672f35ea8fffdcf509587900135)
|
|
|
|
|
|
|
|
|
|
|
| |
permissions on incoming ACL change with no user specified.
Be smarter about setting default permissions when a ACL_USER_OBJ isn't given. Use the principle of least surprises for the user.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Sep 9 00:26:08 CEST 2011 on sn-devel-104
(cherry picked from commit e30b8c72def13e2abc14858ea64eb849ea665b80)
(cherry picked from commit 589bea9d314e14b8a493acdb31104f731073cafa)
|
|
|
|
|
|
|
|
|
| |
permissions on incoming ACL change with no user specified.
create_default_mode() is not needed - it's taken care of by code
inside ensure_canon_entry_valid().
(cherry picked from commit 793bd527fdd0b188aba8f3b4bffd8fa8f69a9cd1)
(cherry picked from commit 0bb1e5919a5f3dd3a290f7dd082b3e67c95b37c6)
|
|
|
|
|
|
|
|
|
|
| |
(Invalid argument)
Don't call check_owning_objs() to convert ACL_USER->ACL_USER_OBJ and
AC_GROUP->ACL_GROUP_OBJ for default (directory) ACLs, we do this separately
inside ensure_canon_entry_valid().
(cherry picked from commit c528fc5cacaae7e0e83041eb98150052b436071e)
(cherry picked from commit 5e06c88de7bc4fe215c8630d9c3b6861f18d63bf)
|
|
|
|
|
|
|
|
|
| |
(Invalid argument)
Only map CREATOR_OWNER/CREATOR_GROUP to ACL_USER_OBJ/ACL_GROUP_OBJ in
a default(directory) ACL set.
(cherry picked from commit a5038ace24559bb02eec8262d3af5b5e78634d16)
(cherry picked from commit 7f3a6c5631f901240d9e460b16d1df81e6f66e2d)
|
|
|
|
|
|
|
|
|
| |
(Invalid argument)
Remove the code I added for bug "6878 - Cannot change ACL's inherit flag". It is incorrect
and causes the POSIX ACL ACL_USER_OBJ duplication.
(cherry picked from commit 2b935b49f3d975759eb1cbcf2b11bf7c9d982804)
(cherry picked from commit 27c49f085a16da709e64e0f50df535edcb524b77)
|
|
|
|
|
|
| |
Handle the SECINFO_LABEL flag in the same was as Win2k3.
(cherry picked from commit 893497ee169ba5455cd70458a339e60544e171d7)
(cherry picked from commit 5f4eb867b1297493473b0d652c7e3d0d21260bf8)
|
|
|
|
|
|
|
|
|
| |
If a client sends a mangled name as part of a DFS path, use the
post-mangled name for the pathname walk, not the mangled name.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Oct 1 00:45:59 CEST 2011 on sn-devel-104
(cherry picked from commit 149875f887287dbbf016d2252962b023b0bae967)
|
|
|
|
|
|
|
|
|
|
|
| |
Thanks to Samba-JP oota <ribbon@samba.gr.jp> for reporting!
Karolin
Autobuild-User: Karolin Seeger <kseeger@samba.org>
Autobuild-Date: Fri Sep 30 23:12:35 CEST 2011 on sn-devel-104
(cherry picked from commit 5c569a97ab477a324a96aae7f58770ccbe2572de)
(cherry picked from commit e6b33a5a3f83272d7e6dea66b1f15db4b19d3170)
|
|
|
|
|
|
|
|
|
|
|
| |
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Sep 29 02:58:41 CEST 2011 on sn-devel-104
(cherry picked from commit ea00f0e452f64868fdc78cf0dc8e9ce3af19fe32)
Fix bug #8503 (The SMB2 server should ignore signing on CANCEL requests).
(cherry picked from commit 3d2c591ff6ce75317556de8ad522c73e5cc8f614)
|
|
|
|
|
|
|
| |
in the documentation also (bug #8494).
Karolin
(cherry picked from commit bd5d9d9fba23ea585b701c41ec27482a0076729e)
|
|
|
|
|
|
|
|
|
|
|
| |
the acl_xattr code). Remove the "experimental" tag.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Sep 27 21:00:12 CEST 2011 on sn-devel-104
(cherry picked from commit fa2236c066890b687483408ed0d82a4bb1f95157)
Fix bug #8494 (Remove "experimental" label on VFS ACL modules).
(cherry picked from commit bdf1c399646a0a968a4360c65be2db8089e6ab8d)
|
|
|
|
|
|
|
| |
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Sep 23 22:20:55 CEST 2011 on sn-devel-104
(cherry picked from commit ca8c25abebb8715176f68be9916217db9a8400dd)
(cherry picked from commit 700532c72592751b57521295b80f65039a260471)
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(bug #8476)
Only return false and the caller will terminate the connection.
metze
(cherry picked from commit 02d83d8fd4d21825110fd7da1ccb570a26e66ca6)
Part of a fix for bug #8476 (Samba asserts when SMB2 client breaks the crediting
rules.)
(cherry picked from commit bdb2c72565e1374585bd638d2d12862d90b80c6b)
|
|
|
|
|
|
|
|
|
| |
Just drop the connection, not SMB_ASSERT.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Sep 22 19:41:31 CEST 2011 on sn-devel-104
(cherry picked from commit d50fa9c21e1c3b6f7126c33e24966099c7567225)
(cherry picked from commit 46ead7f8b1ee69cb61abdc1358ed2c4c411e3fc1)
|
|
|
|
|
|
|
|
|
|
| |
We force using a MEMORY ccache though in the wkssvc server.
Guenther
Part of a fix for bug #7465 (net ads join -k didn't work if KRB5CCNAME is not
set).
(cherry picked from commit 65d953f074394c0a588f1741aeb6c79f1a515866)
|
|
|
|
|
|
|
|
|
| |
libnet_Join/libnet_Unjoin."
This reverts commit 050123d9b6ae8fd69ed58380d8bdf210c38556fc.
This commit seems to break the build.
(cherry picked from commit 82e2f1834380c226eed203a70eaec21b73c0d10a)
|
|
|
|
|
|
|
|
| |
instead of smb2_max_trans.
Use lp_smb2_max_trans() instead of 0x10000.
(cherry picked from commit e68ebe600d9349e16e83aeb8e6ae8647c117d098)
(cherry picked from commit 92a6ffc4a9fa37f5e05987835f15c37211fa810f)
|
|
|
|
|
| |
Guenther
(cherry picked from commit 1f9875f435d1a9cf6d0476f476f8af9480b87bdb)
|
|
|
|
|
|
|
| |
We force using a MEMORY ccache though in the wkssvc server.
Guenther
(cherry picked from commit 050123d9b6ae8fd69ed58380d8bdf210c38556fc)
|
|
|
|
|
|
|
|
|
| |
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Sep 20 15:47:00 CEST 2011 on sn-devel-104
(cherry picked from commit 8dda773bd7eea1d163282b1f3c5e90cbff8a1003)
(cherry picked from commit d7a691e2d713aa37b13d88bab628f9b45f05d10d)
|
|
|
|
|
|
|
|
|
| |
Found by Codenomicon at SNIA SDC.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Sep 23 03:19:46 CEST 2011 on sn-devel-104
(cherry picked from commit f0f91d0117b2ccf778382e61a411b5e4f0ea2b14)
(cherry picked from commit b60b85c55295b1e7ba41a5e835345af28cdd3592)
|
|
|
|
|
|
| |
Guenther
(cherry picked from commit e00a6c40bf13d9c1225022129e4cb1d617aa49bf)
(cherry picked from commit c0156d6a4059f42e6fefaec5ddbec92129d5a180)
|
|
|
|
|
|
|
| |
legacy dialects
Ensure we have valid pointers.
(cherry picked from commit 9bbb3a89ffa39c9be30c269bf96f080866740406)
|
|
|
|
|
|
|
| |
To be completed.
Karolin
(cherry picked from commit 5a109e34dc93e338dc18b5e1dc1881d5b8fdc093)
|
|
|
|
|
|
|
|
|
|
| |
regression intro'd in 3.2
Add "allow insecure widelinks" to re-enable the ability (requested
by some sites) to have "widelinks = yes" and "unix extensions = yes".
Based on an original patch by Linda Walsh <samba@tlinx.org>
(cherry picked from commit 8fcba00fc3329f5a4bda63a3c3beac30d07a0463)
|
|
|
|
|
|
|
|
|
| |
reply stream.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Aug 31 21:18:11 CEST 2011 on sn-devel-104
(cherry picked from commit 786fe9fab223723e4d2340f285592b2a44945d73)
(cherry picked from commit 740c7bd0fead31517890548a02f881b7310cc537)
|
|
|
|
|
|
|
| |
Don't fail if the form already exists (or is builtin now).
Signed-off-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit a272dcf1754bd31ab585bf5b40b5b7f59be27467)
|
|
|
|
|
|
|
|
|
| |
metze
Fix bug #8452 (negprot reply needs to check vwv vector length).
The corresponding commit in master is 85332eb1c721d585e1a33101bddafdca4073e10f.
(cherry picked from commit 1168f7799fb3a1de96233080cd11c6114584b329)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a smb1 negprot negotiated smb2 we forked the echo responder. This will
eventually lead to a panic from
[2011/08/30 10:33:29.212578, 0, pid=3846917] smbd/smb2_server.c:243(smbd_smb2_request_create)
Invalid SMB packet: first request: 0x0009
because from the echo responder we always read using the normal smb1 protocol
handling routine. If that is a bit down the smb2 stream, we get a non-negprot
packet and panic.
BTW, the echo responder is not required for smb2 anyway, Microsoft confirmed
that it probes the server liveness using TCP keepalives and not smb2 echo
requests.
The last 2 patches address bug #8334 (smb2: smbd logs Invalid SMB packet: first
request: 0x0008 and crashes).
(cherry picked from commit d72878365e3ab0ef7bc31065261d744d7693d578)
|
|
|
|
|
|
|
|
|
| |
This enables activating the echo responder also if SMB2 is enabled, albeit it
will only be used for SMB1 at this moment.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri May 20 15:06:03 CEST 2011 on sn-devel-104
(cherry picked from commit 4ad4665e10a77038d7f3dd8400473c8fcf3db451)
|
|
|
|
|
| |
Signed-off-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 703b787307984b5ddf1ef0b214092288d7b076fc)
|
|
|
|
|
|
|
|
|
| |
metze
(cherry picked from commit 0d450d166bab952daf37d922e5c2e5cac16f1cc3)
The last 3 patches address bug #8407 (SMB2 server can return requests
out-of-order when processing a compound request).
(cherry picked from commit 151bea2cc30f5a3e3cfaafd9e080f0d510f9563e)
|
|
|
|
|
|
|
| |
out-of-order when processing a compound request.
(cherry picked from commit 726b4685aa25b0b3b4470bfec5d514fb2db7a95e)
(cherry picked from commit bd377e89a6bc5fa20485bf9614c06159c9785cdf)
|
|
|
|
|
|
|
|
|
| |
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Aug 12 16:46:43 CEST 2011 on sn-devel-104
(cherry picked from commit 42cde0480bd6a5e2dddaa66917e1fa71e6a4edcd)
(cherry picked from commit 90e4b68a3b0e46c238753e66ededa16de3104302)
|
|
|
|
|
|
|
| |
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Sep 1 18:25:34 CEST 2011 on sn-devel-104
(cherry picked from commit 1d4de78f567e908e0acc218630fceb0884b07d65)
(cherry picked from commit 7d2006ccf58555e82bc957aa62beab6420fcbc48)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to [MS-SMB2] 3.3.5.9.7
(http://msdn.microsoft.com/en-us/library/cc246784%28v=PROT.13%29.aspx),
smbd must reply with NT_STATUS_OBJECT_NAME_NOT_FOUND as it does not
support durable file-handles yet.
I have seen w2k8r2 running xcopy /C ending up in an endless loop
trying to get back the original file handle from smbd sending the same
requests over and over.
Metze, Jeremy, please check!
(cherry picked from commit fc8c5880d9785103e3345781bfca48e67a92cc33)
|
|
|
|
|
| |
Fix bug #8420 (wb_group_members: non-resistance against garbage).
(cherry picked from commit 1a996fe1d12a55e68b7266ce5db8972b6e5f101a)
|
|
|
|
|
|
| |
Samba share with SMB2. (cherry picked from commit dec3b21cd1737b317749e7ebced5aa1c2115ebdf)
(cherry picked from commit a0a799663bd4780bb9f948e2dd0635dadb4e2c40)
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I've seen
[2011/08/26 01:44:10.872057, 1] winbindd/winbindd_dual.c:1336(fork_domain_child)
fork_domain_child: Could not read child status: nread=-1, error=Interrupted system call
on a customer box. Not good.
(cherry picked from commit 964e809ce2069ad888e0fb12dfe51bac5a461508)
The last 3 patches address bug #8409 (f7d97868 created a new race condition).
(cherry picked from commit 2f0a5b477f58378c3505631d15b422057b037efe)
|
|
|
|
|
|
|
|
|
| |
Counterpart for last checkin. A lot less likely, but not impossible in a child.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Aug 26 13:14:27 CEST 2011 on sn-devel-104
(cherry picked from commit e0e3d215b1902ecbeb3d469af9a196856711921e)
(cherry picked from commit 11ab2d68023dbfd9089a7e2ec2d36ef4f1f7974e)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a race condition that leads to the winbindd_children list becoming
corrupted. It happens when on a busy winbind SIGCHLD is a bit late.
Imagine a winbind with multiple requests in the queue for a single child. Child
dies, and before the SIGCHLD handler is called we find the socket to be dead.
wb_child_request_done is called, receiving an error from wb_simple_trans_recv.
It closes the socket. Then immediately the wb_child_request_trigger will do
another fork_domain_child before the signal handler is called. This means that
we do another fork_domain_child, we have child->sock==-1 at this point.
fork_domain_child will do a DLIST_ADD(winbindd_children, child) a second time
where the child is already part of that list. This corrupts the list. Then the
signal handler kicks in, spinning in
for (child = winbindd_children; child != NULL; child = child->next) {
forever. Not good. This patch makes sure that both conditions (sock==-1 and not
part of the list) for a winbindd_child struct match up.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Aug 26 18:51:24 CEST 2011 on sn-devel-104
(cherry picked from commit ed058f4dc3e059967f3c0538bc220866e9c63588)
(cherry picked from commit b181fe9ec50ff63074b217143b6daa5cddfb8853)
|
|
|
|
|
|
|
|
|
| |
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Aug 25 23:06:12 CEST 2011 on sn-devel-104
(cherry picked from commit faa769ec19b6486675048734837a6e2237d6f0a4)
Fix bug #8390 (vfs_aixacl2.c needs system/filesys.h).
(cherry picked from commit e66a1f06dc0cdbebf6a4adb801317773a09f0dbc)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Poll and select behave differently regarding error handling. When doing the
connect(2), we can not rely on poll telling us both readability and writability
upon error. Just always try a second connect(2). At least on Linux it returns 0
when it succeeded.
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Aug 25 19:39:12 CEST 2011 on sn-devel-104
(cherry picked from commit 50e30afa608dfdeae8a260730ead9761ed424dad)
(cherry picked from commit 45392d05ff059987fb76d3818969177b5a5de6b0)
|
|
|
|
|
|
|
| |
Missing assignment means this loop will never terminate. Need to be applied
to 3.5.x and 3.6.1.
(cherry picked from commit 218cccfdf1820a9840a5cbc7df3915b6b58a762d)
(cherry picked from commit 225c66ada497449a55d2eed6dfb27cedf3a863c0)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
jra asked:
Do you have any idea on how many calls it saves,
and what help the optimization gives ?
As far as calls: Not 100% sure, dtrace pointed the issue out to me, and when I
saw 10-50%(Or more), I looked for an easy fix.
The real expense here is the fnctl locks on the database. That's pretty
painful. 1000ns per call, and probably 3-4 calls in that chain. So it doesn't
take much to come out ahead was my math.
(cherry picked from commit 9bf2b3034b4c9523bfac779e518a2a1a6d76ef46)
|
|
|
|
|
|
|
|
|
| |
Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 73677875b46251f59b66c9713f1decc89bd2ea3e)
The last 7 patches address bug #8384 (Windows XP clients seem to crash smbd
process every once in a while).
(cherry picked from commit 8d46b29595c4da27b175b25a08b945fbeeeab3ec)
|
|
|
|
|
|
|
|
|
| |
this tests the fix from Simo
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Jul 29 11:30:13 CEST 2011 on sn-devel-104
(cherry picked from commit d004fd0b53fb6f3ae64f0e24cf51f4471d434574)
(cherry picked from commit 2e07c662b08f8bba5cc03efcdcc13165e392b6e8)
|
|
|
|
|
|
|
| |
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Apr 24 03:27:54 CEST 2011 on sn-devel-104
(cherry picked from commit fb05e82c99f0779bd44371a2bdafdd7147448dd5)
(cherry picked from commit 39b7c96517995d2b14e19a006cb18ef642cb98ff)
|
|
|
|
|
|
|
|
| |
Express better that this should be a pointer of a pointer.
Reviewed-by: Tridge
(cherry picked from commit 6723e90d524c8e73f19c06b3ff28867a1a89b14b)
(cherry picked from commit 0c5a41da1375bab225274833ba149ba47df42aec)
|