| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Karolin
|
|
|
|
| |
Karolin
|
|
|
|
| |
Karolin
|
|
|
|
|
| |
Karolin
(cherry picked from commit 315437d3d5a503b2d17c8a01f0e2c088febb041a)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SLES 9's glibc for example had weird macros where the use of strncat resulted
in the use of strcat which we don't allow.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Thu Aug 4 17:50:24 CEST 2011 on sn-devel-104
(cherry picked from commit d3b4d75364210e2d2a4a1cd806f28b0021f22909)
Fix bug #8362 (build issue on old glibc systems).
(cherry picked from commit 87fa72a5202fe3780d4a61289bf755027cd078f4)
(cherry picked from commit 552ccc6588b0744ae9b3731b1406749baea03d5a)
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is more portable, as we have a strtoll replacement
in lib/replace.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Aug 6 11:55:45 CEST 2011 on sn-devel-104
(cherry picked from commit a6be0820d09b3f3eabfbb5f4356add303aa8a494)
Fix bug #8347 (CVE-2011-2522 regression for HP-UX, AIX and OSF).
|
|
|
|
|
| |
Karolin
(cherry picked from commit 999514b140c5f85497109da558d5e8630d59b57e)
|
|
|
|
|
| |
Karolin
(cherry picked from commit eff1c775066938267c44ab0bd25de99363c1d569)
|
|
|
|
|
|
|
| |
Thanks to Simo for reporting!
Karolin
(cherry picked from commit 40787695a1a3200421c9409eef9e520b849ee3a1)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In CGI mode, we don't get access to the user's password, which would
reduce the hash used so far to parameters an attacker can easily guess.
To work around this, read the nonce from secrets.tdb or generate one if
it's not there.
Also populate the C_user field so we can use that for token creation.
Signed-off-by: Kai Blin <kai@samba.org>
The last 12 patches address bug #8290 (CSRF vulnerability in SWAT).
This addresses CVE-2011-2522 (Cross-Site Request Forgery in SWAT).
(cherry picked from commit a4922192d9b95e79bb31c54ca820a9b876a1bbe9)
|
|
|
|
|
| |
Signed-off-by: Kai Blin <kai@samba.org>
(cherry picked from commit 0b811f5b825637b2ecb0450d24dc6b3425ad05a8)
|
|
|
|
|
| |
Signed-off-by: Kai Blin <kai@samba.org>
(cherry picked from commit deb66470413780c93656294a1dca40f8cc1bada8)
|
|
|
|
|
| |
Signed-off-by: Kai Blin <kai@samba.org>
(cherry picked from commit e4e6195701d761326ad5f2dbb63aeb71b0dc7971)
|
|
|
|
|
| |
Signed-off-by: Kai Blin <kai@samba.org>
(cherry picked from commit 9839935c29ec0ab522994436e6e89939696409de)
|
|
|
|
|
| |
Signed-off-by: Kai Blin <kai@samba.org>
(cherry picked from commit 6ea5fac27f2fef35ea12c24250948e00245aacee)
|
|
|
|
|
| |
Signed-off-by: Kai Blin <kai@samba.org>
(cherry picked from commit d499c09fc7bf6d86e9694bc8dc60b96c80d94c35)
|
|
|
|
|
| |
Signed-off-by: Kai Blin <kai@samba.org>
(cherry picked from commit 4b64b7e57d729df996d0734444415f12c066b89f)
|
|
|
|
|
| |
Signed-off-by: Kai Blin <kai@samba.org>
(cherry picked from commit b25d00e3c1ff91e7ec5f56ec2ad0d6b3d635d1e3)
|
|
|
|
|
| |
Signed-off-by: Kai Blin <kai@samba.org>
(cherry picked from commit 8af2d4c60a9bad18ef1b37d4034f11c6008efcfa)
|
|
|
|
|
| |
Signed-off-by: Kai Blin <kai@samba.org>
(cherry picked from commit 69ebd0eee88b1b4b8e29a7620e01c8d9c89b452a)
|
|
|
|
|
| |
Signed-off-by: Kai Blin <kai@samba.org>
(cherry picked from commit dffaf0ed0bb7f38c23f15b0b128a5eb39a55a813)
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nobuhiro Tsuji of NTT DATA SECURITY CORPORATION reported a possible XSS attack
against SWAT, the Samba Web Administration Tool. The attack uses reflection to
insert arbitrary content into the "change password" page.
This patch fixes the reflection issue by not printing user-specified content on
the website anymore.
Signed-off-by: Kai Blin <kai@samba.org>
(cherry picked from commit 05fa09be5a801baa5d35014e2f54b46c1ff5466b)
|
|
|
|
|
|
|
|
|
|
|
|
| |
(bug #8276)
Fix bug #7949 (DoS in Winbind and smbd with many file descriptors open)
(commit feb3fcd0fa4bda0967b881315595d7702f4d1752) changed the bahavior,
so that we skipped some sockets.
This should work for v3-4-test.
metze
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the fix for bso#7836, the parent smbd is responsible for
maintaining an up-to-date printcap cache. It does this by forking a
child process to asynchronously fetch printcap data from CUPS.
When the child process exits after fetching all printcap data, the
parent smbd is sent SIGCHLD. This triggers smbd_sig_chld_handler() which
looks for the exited process PID on a "children" list.
Child smbd process PIDs are added to the "children" list to ensure
cleanup on unclean shutdown and log level change notification messages.
Printcap update process PIDs are not added to the list as they do not
maintain any state that requires cleanup, nor do they wait on tevent for
messages.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Feb 17 11:11:45 CET 2011 on sn-devel-104
(cherry picked from commit 9c12232f1ae36e00d04114ad73edd8ba3c2c6a5c)
Fix bug #8269 (smbd spams log with "Could not find child X -- ignoring"
messages).
(cherry picked from commit ba118ac287d49267dd2f346d4ddd2e590ebbe653)
|
| |
|
|
|
|
|
|
|
|
| |
There is currently a lot of duplicate code included for processing
responses to CUPS_GET_PRINTERS and CUPS_GET_CLASSES requests. This
change splits this code into a separate function.
Signed-off-by: Günther Deschner <gd@samba.org>
|
|
|
|
|
|
|
|
|
|
| |
Use printcap IDL for marshalling and unmarshalling messages between cups
child and parent smbd processes. This simplifies the IPC and ensures
the parent is notified of cups errors encountered by the child.
https://bugzilla.samba.org/show_bug.cgi?id=7994
Signed-off-by: Günther Deschner <gd@samba.org>
|
|
|
|
| |
Signed-off-by: Günther Deschner <gd@samba.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cups_async_callback() is called to receive new printcap data from a
child process which requests the information from cupsd.
Newly received printcap information is stored in a temporary printcap
cache (tmp_pcap_cache). Once the child process closes the printcap IPC
file descriptor, the system printcap cache is replaced with the newly
populated tmp_pcap_cache, however this only occurs if tmp_pcap_cache is
non null (has at least one printer).
If the printcap cache is empty, which is the case when cups is not
exporting any printers, the printcap cache is not replaced resulting in
stale data.
Signed-off-by: Günther Deschner <gd@samba.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pcap_cache_loaded() assertions were added to the (re)load_printers()
functions, to ensure the caller had called pcap_cache_reload() prior to
reloading printer shares.
The problem is, pcap_cache_loaded() returns false if the the pcap_cache
contains no printer entries. i.e. pcap_cache_reload() has run but not
detected any printers.
Remove these assertions, correct call ordering is already enforced.
Signed-off-by: Günther Deschner <gd@samba.org>
The last 3 patches address bug #7836 (A newly added printer isn't visbile to
clients).
|
|
|
|
|
|
| |
This reverts commit ad450870eacb114b3f15941a4478ba25701e035a.
Signed-off-by: Günther Deschner <gd@samba.org>
|
|
|
|
|
|
| |
This reverts commit 36ea03bbe28122ce03de4969e254dd276cfe5a79.
Signed-off-by: Günther Deschner <gd@samba.org>
|
|
|
|
| |
Karolin
|
|
|
|
| |
Karolin
|
|
|
|
| |
Karolin
|
|
|
|
| |
(cherry picked from commit 2167ac2cd42c9ed5aaae0086dbd27e29d1d77686)
|
|
|
|
| |
Karolin
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure we use a timeout of 60 seconds, not 60 milliseconds...
This prevented us from successfully using the ncacn_ip_tcp client in a lot of
places, I guess.
Guenther
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Apr 13 18:59:19 CEST 2011 on sn-devel-104
(cherry picked from commit 4b3fe5247a6e16b1ad9f05269e9aa00e3120e36a)
Fix bug #8085 - incorrect timeout handling in ncacn_ip_tcp client code.
(cherry picked from commit d7d39c723e1855a3d18813e8a79fcca9770b0142)
|
|
|
|
| |
Fix bug #8086 - null pointer reference crashes winbind.
|
|
|
|
|
| |
Karolin
(cherry picked from commit c32b64f22e0ed14d686cb88554e618f2d63acebe)
|
|
|
|
|
| |
Karolin
(cherry picked from commit 7afb216d1d25c1269dcf63f845bebde9a989caa2)
|
|
|
|
|
| |
Karolin
(cherry picked from commit 2aa648e4e9c530a4c9e8d1389fa16e775ac91e54)
|
|
|
|
|
| |
Karolin
(cherry picked from commit 8da98df066bcfc8a47a83615788a55206075ad2b)
|
|
|
|
|
| |
Karolin
(cherry picked from commit da478595190a4a6634b6fc1654fcac58c73e66de)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CVE-2011-0719
Fix bug #7949 (DoS in Winbind and smbd with many file descriptors open).
All current released versions of Samba are vulnerable to
a denial of service caused by memory corruption. Range
checks on file descriptors being used in the FD_SET macro
were not present allowing stack corruption. This can cause
the Samba code to crash or to loop attempting to select
on a bad file descriptor set.
A connection to a file share, or a local account is needed
to exploit this problem, either authenticated or unauthenticated
(guest connection).
Currently we do not believe this flaw is exploitable
beyond a crash or causing the code to loop, but on the
advice of our security reviewers we are releasing fixes
in case an exploit is discovered at a later date.
(cherry picked from commit 43babef991feedbe2acb77d27254d302ab107fa8)
|
|
|
|
| |
Karolin
|
|
|
|
| |
Karolin
|
|
|
|
|
|
|
|
| |
When the TCP RST came before the 5 msecs timeout kicked in, we
viewed this as final, as state->req_139 was not set yet.
Fix bug introduced by a fix for bug #7881 (winbind flaky against w2k8).
(cherry picked from commit f2a19b87725f9318e983dff6358a3eee721bff08)
|
|
|
|
| |
Karolin
|
|
|
|
| |
Karolin
|