summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* s3-docs: Move -D option to the right paragraph in man winbindd.Karolin Seeger2010-05-121-10/+10
| | | | | | | | | Fix bug #7260 (Command line option documentation in wrong place in winbindd man page.). Thanks to Ged Haywood <samba@jubileegroup.co.uk> for reporting! Karolin (cherry picked from commit da5c49d727150eea7d2a4b83da1a02ac1f26e77c) (cherry picked from commit b737434fbf60c250166f10cf196af8030b388bdb)
* work around AIX6.1 name space pollution rename mod_name to module_nameOlaf Flebbe2010-05-122-11/+11
| | | | Fix bug #7421 (samba 3.4.7 does not compile on AIX 6.1).
* s3-spoolss: Fix _spoolss_EnumPrinters servername handling.Günther Deschner2010-05-111-1/+1
| | | | | | | | | Guenther (cherry picked from commit b3c2b2260a503079b9abf22f6b35b56c61c2b372) The last two patches address bug #7418 ("net rpc printer list" command is inoperative). (cherry picked from commit df5f448fe371a1227a507cedc2642fa1a4b77e65)
* s3-spoolss: in spoolss_EnumPrinters r->in.server is a *unique* pointer!Günther Deschner2010-05-111-3/+5
| | | | | | Guenther (cherry picked from commit 8ce66fba03f782c0b9948a9835bb488cfa74acf9) (cherry picked from commit cb6fcb9b16b36fcdc68bef382dbd7ecf89521d4e)
* s3-net: Fix Bug #7417. 'net rpc user password' can set the wrong password.Günther Deschner2010-05-111-1/+4
| | | | | Guenther (cherry picked from commit 7887d99a60387e93ce5ce4a3bfe9117939d1e4c8)
* WHATSNEW: Start release notes for Samba 3.4.9.Karolin Seeger2010-05-111-2/+43
| | | | Karolin
* VERSION: Bump version up to 3.4.9.Karolin Seeger2010-05-111-1/+1
| | | | Karolin
* WHATSNEW: Update changes since 3.4.7.Karolin Seeger2010-05-101-1/+77
| | | | Karolin
* s3-spoolss: fix rpcclient after setprinter IDL fixes.Günther Deschner2010-05-041-2/+2
| | | | | Guenther (cherry picked from commit 31cf2b086a9275955b0480b4b9035dc12671761d)
* spoolss: more mork on SetPrinterInfo() levels.Günther Deschner2010-05-044-82/+98
| | | | | Guenther (cherry picked from commit be95cb6f8357334af08d1502910a429328b85bc5)
* s3-rpcclient: Fix Bug #7277. rpcclient was sending invalid data, causing ↵Günther Deschner2010-05-041-4/+23
| | | | | | | cupsaddsmb to fail. Guenther (cherry picked from commit 9cc10e6a5742f09261f01a2c0b3a94b7b772e573)
* s3-net_conf: Display an error on net conf import failures.Jim McDonough2010-04-211-0/+3
| | | | | | | | When something goes wrong, such as a typo in a parameter name, we'll now display the failure instead of just returning with -1 and no message. Fix bug #7378 ("net conf import" fails silently on parameter typo).
* s3-libsmbclient: Fix incomplete description of function return values in ↵Derrell Lipman2010-04-161-8/+14
| | | | | | | libsmbclient.h. Fix bug #7345. (cherry picked from commit ce565b0498608714e2c4f7c9f9373dddcbfba568)
* s3:winbindd: make sure we don't try rpc requests against unaccessable domainsStefan Metzmacher2010-04-161-5/+28
| | | | | | | | | | | This makes sure we don't crash while trying to dereference domain->conn.cli->foo while trying to establish a rpc connection to the server. This fixes bug #7316. metze (cherry picked from commit d930904b997d310aeff781bde1e7e3ce47dde8a1) (cherry picked from commit 01b60b113869f526dcf3bb478d70df21dbb207c8)
* s3-docs: Improve "winbind nss info" section in man smb.conf.Karolin Seeger2010-04-161-10/+8
| | | | | | Karolin (cherry picked from commit 20fc769179377bf037f4d5efe1afbaf77d4c9292) (cherry picked from commit fb1b0901ec93afe998145bb7a7549bbdb13c712c)
* Fix bug #7288 - SMB job IDs in CUPS job names wrong.Jeremy Allison2010-04-154-22/+32
| | | | | | | | | | | | | | | | | | | | | | | | | Based on a patch from Michael Karcher <samba@mkarcher.dialup.fu-berlin.de>. I think this is the correct fix. It causes cups_job_submit to use print_parse_jobid(), which I've moved into printing/lpq_parse.c (to allow the link to work). It turns out the old print_parse_jobid() was *broken*, in that the pjob filename was set as an absolute path - not relative to the sharename (due to it not going through the VFS calls). This meant that the original code doing a strncmp on the first part of the filename would always fail - it starts with a "/", not the relative pathname of PRINT_SPOOL_PREFIX ("smbprn."). This fix could fix some other mysterious printing bugs - probably the ones Guenther noticed where job control fails on non-cups backends. Contains c79ca41baf15b4ef7eb287d343b17a53ba41e852 and 92332fb2368c641db1552d1f2a2f7b3deaa11519 from master. Jeremy. (cherry picked from commit 12936bfeb36ae867b52fe48d0f6d3d17d5c8b110)
* libwbclient: Re-Fix a bug that was fixed with e5741e27c4cVolker Lendecke2010-04-134-26/+53
| | | | | | | | | | | | | | | | | > r21878: Fix a bug with smbd serving a windows terminal server: If winbind > decides smbd to be idle it might happen that smbd needs to do a winbind > operation (for example sid2name) as non-root. This then fails to get the > privileged pipe. When later on on the same connection another authentication > request comes in, we try to do the CRAP auth via the non-privileged pipe. > > This adds a winbindd_priv_request_response() request that kills the existing > winbind pipe connection if it's not privileged. The fix for this was lost during the conversion to libwbclient. Thanks to Ira Cooper <samba@ira.wakeful.net> for pointing this out! Volker
* s3:winbindd: make "smbcontrol winbindd validate-cache" reliable againStefan Metzmacher2010-04-131-0/+3
| | | | | | | | | commit 73577205cf81644e7fe853eaf3e6459f7f443096 (s3:winbindd: fix problems with SIGCHLD handling (bug #7317)) broke this. metze (cherry picked from commit eb9b7d0363669574de8ec380089407890f15eac2)
* s3:winbindd: remove unused variablesStefan Metzmacher2010-04-131-2/+0
| | | | | | metze (cherry picked from commit e18ddb6036f5e0a2211e89a7c9b5514c30a653cf) (cherry picked from commit c64c867c307d32b8ec17d6e079395e0e9b604f00)
* s3:winbindd: fix problems with SIGCHLD handling (bug #7317)Stefan Metzmacher2010-04-133-17/+6
| | | | | | | | | | | | | | | | | | | | | | | The main problem is that we call CatchChild() within the parent winbindd, which overwrites the signal handler that was registered by winbindd_setup_sig_chld_handler(). That means winbindd_sig_chld_handler() and winbind_child_died() are never triggered when a winbindd domain child dies. As a result will get "broken pipe" for all requests to that domain. To reduce the risk of similar bugs in future we call CatchChild() in winbindd_reinit_after_fork() now. We also use a full winbindd_reinit_after_fork() in the cache validation child now instead instead of just resetting the SIGCHLD handler by hand. This will also fix possible tdb problems on systems without pread/pwrite and disabled mmap as we now correctly reopen the tdb handle for the child. metze (cherry picked from commit 73577205cf81644e7fe853eaf3e6459f7f443096) (cherry picked from commit e0ece652956292cc67383535a0fa174b5015d91e)
* s3:winbindd: correctly retry if the netlogon pipe gets disconnected during a ↵Stefan Metzmacher2010-04-131-2/+2
| | | | | | | | | | | | logon call This fixes hopefully the last part of bug #7295. metze (cherry picked from commit 4c6cde99c0751a073120d8bc36d40922d8027344) (cherry picked from commit 482518fcafb18bda1f084ebf1906a2ad02436b80) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:winbindd_reconnect: don't only reconnect on NT_STATUS_UNSUCCESSFULStefan Metzmacher2010-04-131-14/+59
| | | | | | | | metze (cherry picked from commit 6bd5a2a3739938f95fce23ab2da652c9b5a48111) (cherry picked from commit 169628fcb656ba5987a99bd50c7f588b731eae51) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:winbindd_cm: invalidate connection if cm_connect_netlogon() failsStefan Metzmacher2010-04-131-2/+2
| | | | | | | | metze (cherry picked from commit 94a4bcd2f0c0464e192556679c6636639cb307ea) (cherry picked from commit c046ae8428fb62ff2749689e7c738f1a2e8f8251) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:winbindd: consistently use TALLOC_FREE(conn->foo_pipe) is we create a new ↵Stefan Metzmacher2010-04-131-0/+5
| | | | | | | | | | connection metze (cherry picked from commit 4f391fedac7111683d13f2d79fee7c0dbc27f86e) (cherry picked from commit c462e54142c00fdd81c2847d16a75119b1cc89fc) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:winbindd_cm: use rpccli_is_connected() helper functionStefan Metzmacher2010-04-131-4/+5
| | | | | | | | metze (cherry picked from commit d980c06a994d032a833adc8d56d2f2c037f8fdaf) (cherry picked from commit aa7d54ed04585a183a88363406ed7f3244b24d85) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:winbindd_cm: use cli_state_is_connected() helper functionStefan Metzmacher2010-04-131-14/+4
| | | | | | | | metze (cherry picked from commit 408a3eb35a0e61b5d66a3b48ebbd1a6796672d0f) (cherry picked from commit 00a93190d2cae31cd2213b810ea348c055670399) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:rpc_client: return at least 10 sec as old timeout in rpccli_set_timeout() ↵Stefan Metzmacher2010-04-131-3/+12
| | | | | | | | | | instead of 0 metze (cherry picked from commit 3e70da3f470eeb122f95477fb48d89939f501b3e) (cherry picked from commit 60861fba533027b6c9a0ff704b95dcf631ea3ca3) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:rpc_client: add set_timeout hook to rpc_cli_transportStefan Metzmacher2010-04-135-3/+65
| | | | | | | | metze (cherry picked from commit 99664ad15460530b6fb44957b6c57823f09884bf) (cherry picked from commit 89164eb8363ffc0b951256578be48d37ddba46b1) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:rpc_client: add rpccli_is_connected()Stefan Metzmacher2010-04-136-18/+193
| | | | | | | | metze (cherry picked from commit 4f41b53487ac9bc96c7960e8edab464558656373) (similar to commit 958b49323968740e2cbf69dc2a0a5dd57d5bcf87) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:rpc_client: don't mix layers and keep a reference to cli_state in the callerStefan Metzmacher2010-04-131-8/+17
| | | | | | | | | | | | We should not rely on the backend to have a reference to the cli_state. This will make it possible for the backend to set its cli_state reference to NULL, when the transport is dead. metze (cherry picked from commit dc09b12681ea0e6d4c2b0f1c99dfeb1f23019c65) (cherry picked from commit 1e2e47da82aeb249dce431541738a62cb139aebb) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:rpc_transport_np: use cli_state_is_connected() helperStefan Metzmacher2010-04-131-1/+1
| | | | | | | | metze (cherry picked from commit b862351da8624df893ec77e020a456c1d23c58ed) (cherry picked from commit 8c2f4426ce178ac33748cfba01532ec2fd205710) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: add cli_state_is_connected() functionStefan Metzmacher2010-04-132-0/+19
| | | | | | | | metze (cherry picked from commit d7bf30ef92031ffddcde3680b38e602510bcae24) (cherry picked from commit 589f73924273e8a9b54669f42a92381661dcb33f) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: don't let cli_shutdown() segfault with a NULL cli_stateStefan Metzmacher2010-04-131-0/+4
| | | | | | | | metze (similar to commit 47e10ab9a85960c78af807b66b99bcd139713644) (cherry picked from commit 957c0d4a5ee67ac70e576155a0f2f6f84cdb1596) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:rpc_transport_np: handle trans rdata like the output of a normal readStefan Metzmacher2010-04-131-0/+17
| | | | | | | | | | Inspired by bug #7159. metze (cherry picked from commit 911287285cc4c8485b75edfad3c1ece901a69b0b) (cherry picked from commit e2739a2bf37e654c37cbea6e510f63a7ce4adfea) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3: Fix infinite loop in NCACN_IP_TCP asa there is no timeout. Assume ↵Stefan Metzmacher2010-04-131-0/+16
| | | | | | | | | lsa_pipe_tcp is ok but network is down, then send request is ok, but select() on writeable fds loops forever since there is no response. Signed-off-by: Bo Yang <boyang@samba.org> (cherry picked from commit 36493bf2f6634b84c57107bcb86bcbf3e82e80fc) (similar to commit b58b359881c91ec382cfa1d6ba3007b8354b29cb) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* Fix broken pipe handlingStefan Metzmacher2010-04-131-2/+2
| | | | | | | | | | | Metze is right: If we have *any* error at the socket level, we just can not continue. Also, apply some defensive programming: With this async stuff someone else might already have closed the socket. (cherry picked from commit f140bf2e6578e45b8603d4a6c5feef9a3b735804) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:rpc_client: close the socket when pipe is brokenStefan Metzmacher2010-04-131-1/+24
| | | | | | Signed-off-by: Bo Yang <boyang@samba.org> (similar to commit aa70e44cd0576e5280e24cf35000369a47dd958f) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3: fix crash in winbindd (similar to commit ↵Stefan Metzmacher2010-04-132-2/+15
| | | | | | f8cc0e88fbbb082ead023e0cb437b1e12cf35459) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3-docs: Fix typo in man idmap_ad.Karolin Seeger2010-04-131-1/+1
| | | | | | Karolin (cherry picked from commit 6389fac6db2f54d148222009b5e209cef5c6bdd7) (cherry picked from commit 39dbf73a6fb4ad45eac259124b70042994d4f215)
* s3:lib/time: remove TIME_T_MIN/MAX definesBjörn Jacke2010-04-121-8/+0
| | | | | | | we already get them from lib/util/time.h (cherry picked from commit f5729dbb6e720cb6076ea053f1ad0680259e6b39) The last two patches address bug #7352 (TIME_T_MAX defines inconsistent).
* lib/util: move TIME_T_MIN/MAX defines into header file (cherry picked from ↵Björn Jacke2010-04-122-14/+14
| | | | commit 571ee54b791b93ad46e09ed563ef4a5582dcf0c8)
* WHATSNEW: Start release notes for Samba 3.4.8.Karolin Seeger2010-04-121-3/+5
| | | | Karolin
* Second part of fix for bug #7159 - client rpc_transport doesn't cope with ↵Jeremy Allison2010-04-081-0/+6
| | | | | | | | | | | | | | bad server data returns. If server returns zero on a NP read. Report pipe broken. Prevents client from looping if it thinks there should be more data. Jeremy. (cherry picked from commit 0055e33dbed0e81548464d01bcf864255bab3159) (cherry picked from commit f5ca9f84e9b511c2ba7a4280b1997daa441f9877) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* First part of fix for bug #7159 - client rpc_transport doesn't cope with bad ↵Stefan Metzmacher2010-04-082-0/+16
| | | | | | | | | | | | | | | server data returns. Ensure that subreq is *always* talloc_free'd in the _done function, as it has an event timeout attached. If the read requests look longer than the cli->timeout, then the timeout fn is called with already freed data. Jeremy. (cherry picked from commit ad77ae1d5870e06f8587ecf634e0b6bdcbb950d7) (similar to commit 6e5b6b5acb30869eb63b25ed1406014101a5e89d) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3: Fix bug 7326 -- can't write with vfs_full_audit activeVolker Lendecke2010-04-061-4/+4
|
* s3: signals are processed twice in child.Bo Yang2010-04-013-5/+36
| | | | | | | | Signed-off-by: Bo Yang <boyang@samba.org> (cherry picked from commit 8c8bb51de1ac2baa46ac0736fae12c034288e5d4) Fix bug #7206 (duplicate signal handler, signals are processed twice in child process).
* Fix bug 7310 - DOS attribute inconsistency with MS OfficeJeremy Allison2010-04-011-0/+17
| | | | | | On rename we need to set the archive bit on the renamed file. Jeremy
* Fix bug 7307 - man net usershare mistakeJeremy Allison2010-03-301-1/+1
| | | | | | | | Fix bad usage message, reported by headset001@yahoo.com. Jeremy. (cherry picked from commit e14a6fbf8c9e4d16b2727e48c708ceccfd157e59) (cherry picked from commit 9620f5fbe64910d86cae51345156a1a4dd71e231)
* Fix bug 7297 - smbd crashes with CUPS printers and no [printers] share defined.Jeremy Allison2010-03-291-1/+1
| | | | | | | Ensure we don't dereference an array with an index of -1. Jeremy. (cherry picked from commit e4127ab299e654777c43d983b2e0a158baa7d79a)
* s3 ntlm_auth: Don't malloc data that will be talloc_free()dKai Blin2010-03-291-12/+12
| | | | | This fixes bug #7290 Thanks to Mohan <mohann@silver-peak.com> for the bug report.