| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
| |
'SAMBA_TNG_2_5_GOOD'.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\ |
|
| |
| |
| |
| | |
in TNG
|
| | |
|
| | |
|
| |
| |
| |
| | |
zero
|
| |
| |
| |
| |
| |
| | |
entry before adding to ensure that we don't ever add a duplicate entry
this code can be removed when ubi gets fixed
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
new open mechanism Andrew & I discussed.
config.sub:
configure: Included the QNX patch.
include/vfs.h:
smbd/vfs-wrap.c:
smbd/vfs.c: Added ftruncate vfs call (needed).
Note that we will also need locking calls in the vfs (to be added).
lib/util_unistr.c:
nmbd/nmbd_processlogon.c: Fix for NT domain logons causing nmbd to core dump.
Also fix for sidsize DOS bug.
locking/locking.c: Check value of ret before using it for memdup.
printing/printing.c: Convert print_fsp_open to return an allocated fsp.
rpc_server/srv_lsa.c: Fix for NT domain logons.
I have removed all use of lp_share_modes() from the code (although I
left the parameter in the table for backwards compatibility). It no longer makes
sense for this to exist.
smbd/close.c: Removed lp_share_modes().
smbd/fileio.c: Fixed parameters to unlock_share_entry call in panic code.
smbd/files.c: Correctly set the unix_ERR_code to ERRnofids on fsp allocation fail.
smbd/nttrans.c:
smbd/reply.c:
smbd/trans2.c: Changed all occurrences of open_file_shared/open_directory/
open_file_stat to return an fsp from the call.
smbd/open.c: Changed all occurrences of open_file_shared/open_directory/
open_file_stat to return an fsp from the call.
In addition I have fixed a long standing race condition in the deny mode
processing w.r.t. two smbd's creating a file. Andrew, please note that
your original idea of using open with O_EXCL in this case would not work
(I went over the races very carefully) and so we must re-check deny modes
*after* the open() call returns. This is because there is a race between
the open with O_EXCL and the lock of the share mode entry. Imagine the
case where the first smbd does the open with O_EXCL and a deny mode of DENY_ALL,
but is pre-empted before it locks the share modes and creates the deny
mode entry for DENY_ALL. A second smbd could then come in with O_RDONLY
and a deny mode of DENY_NONE and the two opens would be allowed.
The *only* way to fix this race is to lock the share modes after the
open and then do the deny mode checks *after* this lock in the case
where the file did not originally exist.
This code will need extensive testing but seems to initially work.
Jeremy.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
communications. Client state now indexed by file descriptor rather
than pid number closing a possible security hole.
The lsa and samr pipe handles now cached on a per-domain basis which
speeds things up dramatically. However it has exposed some problems in
the rpc client code. Use and group enumeration code and types simplified
quite a bit.
Still some work to do in moving yet more state back towards the nss
client. The eventual goal is to have nss clients unaffected by the stopping
and restarting of the winbind daemon. Some scalability issues still to be
addressed.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
communications. Client state now indexed by file descriptor rather
than pid number closing a possible security hole.
The lsa and samr pipe handles now cached on a per-domain basis which
speeds things up dramatically. However it has exposed some problems in
the rpc client code. Use and group enumeration code and types simplified
quite a bit.
Still some work to do in moving yet more state back towards the nss
client. The eventual goal is to have nss clients unaffected by the stopping
and restarting of the winbind daemon. Some scalability issues still to be
addressed.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
reply.c:
> fixed overlapping strcpy() found by insure
service.c:
> don't copy a null groups list
In TNG this was already fixed by returning NULL from
memdup(NULL)
|
| |
| |
| |
| |
| | |
installscripts.sh installswat.sh makeyodldocs.sh
smbtar
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
LIBSMB_OBJ, cause libsmb anyway depended on them.
Now could remove $(RPC_PARSE_OBJ2) from nmbd and smbclient,
and both got 30k smaller.
Split PRINTING_OBJ into PRINTING_OBJ and PRINTBACKEND_OBJ,
like HEAD. Now swat links, but spoolssd still doesn't link.
(Of course, smbd also doesn't compile)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
> printing/printing.c: Convert print_fsp_open to return an allocated fsp.
Now at leat smbd/open.c compiles, but spoolssd and swat
don't link any more, cause printing.c now depends on
smbd/files.c, which in turn depends on whatever.
I guess, swat will not link in HEAD either...
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
> nmbd/nmbd_processlogon.c: Fix for NT domain logons causing nmbd to core dump.
I didn't see this in the diff.
> Also fix for sidsize DOS bug.
Saw that.
Luke: Can you take a _short_ look at the diff of
nmbd_processlogon.c in TNG and HEAD, this looks like
unicode-stuff.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
unused currently, if you need them, make them public again:
lib/msrpc-client.c, rpc_client/cli_connect.c,
rpc_parse/parse_lsa.c, rpcclient/display_dfs.c
merged a little of util_sid.c from HEAD (more cosmetic and
ordering)
dropped in profile.c from HEAD
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
winbindd-specific objects and from which the prototypes are
generated, and WINBINDD_OBJ, which contains WINBINDD_OBJ1
and library-objects.
Did this, cause proto.h just again included all the
prototypes for rpc_client and rpc_parse.
proto.h went down from 6466 lines / 288k
to 4578 lines / 197k
... hope, Tim isn't too angry, that I touched his area.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Modified daemon architecture to manage partial reads and writes of client
data properly.
Also keep client socket file descriptors open for as long as possible.
Moved client state back a level from inside winbindd_{user,group}.c into
winbindd.c
All winbindd_* functions now take a winbindd_state pointer as argument
rather than selected bits of the request structure.
Lots of code moved to winbind_utils.c
String handling cleaned up.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Cleaned up string handling.
Cut out huge swathes of code into winbindd_util.c
Renamed a bunch of types.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Cleaned up string handling.
Moved across group and user state for {set,get,end}{pw,gr}ent() functions.
Added externals for domain name, uid and gid lists.
|
| |
| |
| |
| |
| | |
Moved across common functions from winbindd.c, winbindd_{user,group}.c and
winbindd_surs.c
|
| |
| |
| |
| | |
Moved functions into ntdom.c as they are now only used by the client.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Checked result of all system calls == -1 instead of < 0.
Cleaned up string handling.
Copied across next_token() function from lib/util_string.c and removed call
to strtok() function.
Keep connection to winbindd UNIX domain socket open rather than closing it
after each transaction.
Process pid now not required to be passed to winbindd.
|
| | |
|
| |
| |
| |
| | |
a reliability-bug.
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
ncacn_np_use.c end up in both proto.h and
rpc_client_proto.h.
|
| | |
|