summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* s3-pam_winbind: Fix Bug 6253: Use correct value for password expiry calculation.Günther Deschner2009-05-261-1/+1
| | | | | | | | Patch from Blindauer Emmanuel <samba@mooby.net>. Guenther (cherry picked from commit 290449aeae950d7490cdcf9d601052fc45bb84dd) (cherry picked from commit a79ae4e5364fe8e3ec6b451364dc5d861f202528)
* s3:onefs.so fix issue with missing entries when enumerating directoriesSteven Danneman2009-05-261-130/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This bug prompted several, fairly large changes to the of OneFS's readdirplus() within Samba. One fundamental problem is that we kept our cache cursor pointed at the next entry to be returned from onefs_readdir(), while the resume cookie needed to refill the cache such that our cursor would be on this entry, was located in the previous cache entry. This meant that to correctly handle seekdir() cases which could be found within the existing cache, and cases where a cache reload was needed, required that the cache always hold at least two entries: the entry we wished to return, and the previous entry which held the resume cookie. Since the readdirplus() syscall gives us no guarantee that it will always return these two direntries, there was a fundamental problem with this design. To fix this problem, I have rearchitected the onefs_readdir() path to keep its pointer on the entry which contains the resume_cookie, not the entry which will be returned next. Essentially, I changed onefs_readdir() from a "return an entry then increment the cursor" model to "increment the cursor then return an entry". By doing this, we only require that a single entry be within the cache: the entry containing the resume cookie. Second, there have been numerous off-by-one bugs in my implementation of onefs_seekdir() which did a mapping between the 64-bit resume cookie returned by readdirplus() and its own monotonically increasing "location" offset. Furthermore, this design caused a somewhat frequent waste of cycles, as in some cases we'd need to re-enumerate the entire directory to recover the current "location" from an old resume cookie. As this code was somewhat difficult to understand, prone to bugs, and innefficient in some cases I decided it was better to wholesale replace it now, rather than later. It is possible to algorithmically map the 64-bit resume cookies from readdirplus() into 32-bit offset values which SMB requires. The onefs.so module now calls into a system library to do this conversion. This greatly simplifies both the seekdir() and telldir() paths and is more efficient. (cherry picked from commit aeb7de50b51840bddcdd4cbe6d96a4066b5116f0)
* Fix bug #6315 smbd crashes doing vfs_full_audit on IPC$ close event.Jeremy Allison2009-05-261-3/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The underlying problem is that once SMBulogoff is called, all server_info contexts associated with the vuid should become invalid, even if that's the context being currently used by the connection struct (tid). When the SMBtdis comes in it doesn't need a valid vuid value, but the code called inside vfs_full_audit always assumes that there is one (and hence a valid conn->server_info pointer) available. This is actually a bug inside the vfs_full_audit and other code inside Samba, which should only indirect conn->server_info on calls which require AS_USER to be set in our process table. I could fix all these issues, but there's no guarentee that someone might not add more code that fails this assumption, as it's a hard assumption to break (it's usually true). So what I've done is to ensure that on SMBulogoff the previously used conn->server_info struct is kept around to be used for print debugging purposes (it won't be used to change to an invalid user context, as such calls need AS_USER set). This isn't strictly correct, as there's no association with the (now invalid) context being freed and the call that causes conn->server_info to be indirected, but it's good enough for most cases. The hard part was to ensure that once a valid context is used again (via new sessionsetupX calls, or new calls on a still valid vuid on this tid) that we don't leak memory by simply replacing the stored conn->server_info pointer. We would never actually leak the memory (as all conn->server_info pointers are talloc children of conn), but with the previous patch a malicious client could cause many server_info structs to be talloced by the right combination of SMB calls. This new patch introduces free_conn_server_info_if_unused(), which protects against the above. Jeremy. (cherry picked from commit 4b3bd6d0ba3348659615e69b3508969aa41e7de4)
* s3/docs: Fix typo.Karolin Seeger2009-05-261-1/+3
| | | | | Karolin (cherry picked from commit c2eb0d87a2436614741119ebd14fda05b42a2ddd)
* Do not crash in ctdbd_traverse if ctdbd is not aroundVolker Lendecke2009-05-261-0/+5
| | | | (cherry picked from commit 7ad42cc74322a1435c9cce9b286b13cd9b490ec6)
* Increase debug level of "create_connection_server_info failed" messageVolker Lendecke2009-05-261-1/+1
| | | | | | I don't think we should unconditionally send every refused connection attempt to a share to syslog, that's where all debug level 0 messages end up. (cherry picked from commit 8c7afce8bb86cda773c713459bb18233dc4848a3)
* Fix bug 6136: New AFS syscall conventionsGeza Gemes2009-05-263-4/+24
| | | | | | | | | Haven't checked this myself, but as I've already got several reports that Samba won't compile against current OpenAFS anymore, I just believe Geza Gemes. This patch only affects AFS code, so it should not hurt anything else. Volker (cherry picked from commit 70231f2d88b96da365e56c8d077749366509a4e1)
* s3/docs: Fix typos.Karolin Seeger2009-05-261-4/+5
| | | | | | | | | That fixes bug #4247. Thanks to David McNeill <davemc [at] mcpond.co.nz> for reporting! Karolin (cherry picked from commit eaf949947c2eb03363c4b6f588f87b70110d6ff7) (cherry picked from commit cea79d1fbf44b0d5bff5aa12962fb3d3cb61c367)
* s3/docs: Fix typo.Karolin Seeger2009-05-261-1/+1
| | | | | | | | | This fixes bug #4245. Thanks to David McNeill <davemc [at] mcpond.co.nz> for reporting! Karolin (cherry picked from commit 579c91581f5b6d5341a12923fe6cde377223caff) (cherry picked from commit 49caab4044e47236594c6688f202aed555b9da61)
* Fix bug #6291 - force user stop working.Jeremy Allison2009-05-261-1/+37
| | | | | | | | A previous fix broke the invariant that *uid is always initialized on return from create_token_from_username(). Restore it. Jeremy. (cherry picked from commit e178c02a216fefc8295a7fd2d623c888c81f8734)
* s3:config.sub: clean some space/tab mixup that git complains aboutMichael Adam2009-05-261-1/+1
| | | | | | Michael (cherry picked from commit 384c1aaa8ee8879b6cc4bc34dfc4d3c9fa11667b) (cherry picked from commit ec02a0c1ceea2afc9324f6f069941deaed38c22d)
* s3:config.sub: replace old FSF address by the web site url.Michael Adam2009-05-261-3/+1
| | | | | | Michael (cherry picked from commit f3308b91d75356a83e99aade7e88d2cd1edc2042) (cherry picked from commit c14f81738b64377e978a87681b5e687fa9d4d2a2)
* s3:config.sub: move to GPLv3Michael Adam2009-05-261-1/+1
| | | | | | Michael (cherry picked from commit 62a69994f252f7cc98ef12bc39a25a2ee25afb0a) (cherry picked from commit 1b4ab194a9f20ee1392bd54dbb82a6384c4b8b3d)
* s3:update config.sub from gnu.org (2009-04-17)Michael Adam2009-05-261-48/+157
| | | | | | | | | | | as requested in bug #6292. This is taken from http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.sub;hb=HEAD Michael (cherry picked from commit f81c02c3f31a4700d32aff884254fcd752797be7) (cherry picked from commit 09192e196bb20e7b8e4203debf9a7e4dc51e1c36)
* s3:config.guess: clean some whitespace/tab mixtures that git complains aboutMichael Adam2009-05-261-2/+2
| | | | | | Michael (cherry picked from commit faaa306c6ae7b00fa5e53321203f072776eefa0a) (cherry picked from commit c59d97195dc8002b6837e17f5e37be26c7ee5dd3)
* s3:config.guess: replace old FSF address by the web site url.Michael Adam2009-05-261-3/+1
| | | | | | Michael (cherry picked from commit d230ac7b322827930de2e1b922cd4b6a597c933f) (cherry picked from commit 198736e1f17c43853f200435f1c1969e13aed77d)
* s3:config.guess: move to GPLv3Michael Adam2009-05-261-1/+1
| | | | | (cherry picked from commit fee78294589a02090887233ad112c69d3a5bd383) (cherry picked from commit 76a8b17f4f2a48baa6d847648b2d7442b63888bc)
* s3:update config.guess form gnu.org (version 2009-04-27)Michael Adam2009-05-261-27/+125
| | | | | | | | | | | as requested in bug #6292. This is taken from http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.guess;hb=HEAD Michael (cherry picked from commit 1188c78f53fb7d56f4bf61c41fe635b639a311fd) (cherry picked from commit 20fcbc85ddb59c7972422471705841cb8595d7ec)
* s3-netapi: Fix Bug #6309: support remote unjoining of Windows 2003 or greater.Günther Deschner2009-05-262-2/+4
| | | | | | | | Found by David Markey <admin@dmarkey.com>. Thanks! Guenther (cherry picked from commit ab4b8c9c0438bc5afca17e3ebf05dde6f98bc0aa) (cherry picked from commit 942d47e5ed583e29afaa005f9ca6251373db8e2f)
* wkssvcs: add WKSSVC_JOIN_FLAGS_IGNORE_UNSUPPORTED_FLAGS join flag.Günther Deschner2009-05-263-0/+3
| | | | | | Guenther (cherry picked from commit 26b9c9370ce047ecc732082b2b554ffc295ae406) (cherry picked from commit d5c6ff96fd89b87c7331f264044e931b100b3a1a)
* s3-printing: rework move_driver_file_to_download_area() a bit for clarity.Günther Deschner2009-05-261-32/+40
| | | | | | Guenther (cherry picked from commit baf78506895b8bd50433058ba0f18e1aaf8aeee5) (cherry picked from commit 492b5cfea364c60376245962a8777e04e31e8392)
* s3-lsa: use LSA_POLICY_MODE flags in _lsa_GetSystemAccessAccount().Günther Deschner2009-05-262-7/+2
| | | | | | Guenther (cherry picked from commit af5a71d5280984a7d707e39fb522ecc7e1b71436) (cherry picked from commit c89fdbed5286806d9a9b0b4a5d35870f7989baf7)
* s3-nss_wins: Fix unresolved ldb symbols in libnss_wins.so.Günther Deschner2009-05-261-1/+1
| | | | | | | | The objects for this module should probably be cleaned up once. Guenther (cherry picked from commit eee446a94841a5df97b3a47c7076ef52fb5ccdcf) (cherry picked from commit d5da80b175b8e7e12070577abdab4f57917727a3)
* s3-spoolss: avoid referring to uid 0 in spoolss server (use ↵Günther Deschner2009-05-261-3/+3
| | | | | | | | sec_initial_uid() instead). Guenther (cherry picked from commit d22965e2e596c8ad78f5330398d43d96bf564773) (cherry picked from commit 6ca91ff2d56f33a96e013cc3ab796ba38aa10dcd)
* s3-printing: use move_driver_file_to_download_area() to avoid code duplication.Günther Deschner2009-05-261-144/+54
| | | | | | Guenther (cherry picked from commit 233bfb25c9443688f74c506348b0a7b34489e1d1) (cherry picked from commit bbeefe338e654cb0f43281d9dabe77b59fa931d6)
* s3-printing: add move_driver_file_to_download_area().Günther Deschner2009-05-261-0/+40
| | | | | | Guenther (cherry picked from commit a2a155bee59c7e849a492933d1ea5769e409bac5) (cherry picked from commit be680b2aae289cc7e173c4a76802fe09ff7882f6)
* Re-import the v3-3 version of str_list_make().Volker Lendecke2009-05-261-7/+59
| | | | | | | | | | | | | | | The merged version behaves differently: "Domain Users" is parsed into two values, as it does not look at quotes. Samba3 users depend on the ability do say for example valid users = "domain users" which would not work anymore with the merged version. Thanks to Björn Jacke for testing this! Volker (cherry picked from commit 5b9477f9930d0c6511c70409561c04c5729bcc05)
* WHATSNEW: Add new net service subcommands to the WHATSNEW.tdb-1.1.3talloc-1.3.0samba-3.4.0pre1Karolin Seeger2009-04-301-1/+7
| | | | | Karolin (cherry picked from commit b7c4a63d034f8c33b3a4857cae41270bd55e270f)
* WHATSNEW: Add some WHATSNEW improvements.Karolin Seeger2009-04-301-1/+61
| | | | | Karolin (cherry picked from commit b59f79fd262b9dbb97db90e8cafe7642fd6b6317)
* WHATSNEW: Correct WHATSNEW.Karolin Seeger2009-04-291-7/+6
| | | | | Karolin (cherry picked from commit 83c7d8697a8df92ff1592af9c382f483354eeb0f)
* s3-test: make it possible to find the built vlp in "make test".Günther Deschner2009-04-291-1/+9
| | | | | | Guenther (cherry picked from commit 3316ae9d75dfe6c7a960938c9503367880510079) (cherry picked from commit 0146649cf95ad27a583057df300fe5712b89e806)
* Specify explicit path to vlp, for those not having vlp in $PATH.Jelmer Vernooij2009-04-291-1/+9
| | | | | (cherry picked from commit 79177c1d36e125b08aa4d6e0e42e9a97f625b3c8) (cherry picked from commit f51a4b95b472496f58759dae75ff1369324c0a29)
* s3/docs: Fix serveral typos.Karolin Seeger2009-04-291-5/+5
| | | | | | | | | This fixes bug #4315. Thanks to Felipe Augusto van de Wiel <faw [at] cathedrallabs [dot] org>! Karolin (cherry picked from commit 3422b9c546cdd262bd747e1e737c2b6479b4d21e) (cherry picked from commit 3da62734fffa99cde1084beeb69e94a7bc623dde)
* WHATSNEW: Update WHATSNEW.Karolin Seeger2009-04-291-5/+51
| | | | | Karolin (cherry picked from commit 245b859dfb0e1de4c453cf9de97e6d50b163daa4)
* s3/docs: Remove documentation of "use kerberos keytab".Karolin Seeger2009-04-291-23/+0
| | | | | | | | This parameter has been removed with d96248a9b4655. Karolin (cherry picked from commit b6eab68c20f0914cb946f05ebae2faba67f32806) (cherry picked from commit 644d45ef4878e396fe62918e35e7103465eeb971)
* s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 6.Günther Deschner2009-04-291-1/+25
| | | | | | Guenther (cherry picked from commit 6900d61d369961e0c11e590ccdc102169f21cef3) (cherry picked from commit 41dae8256cdddd9557ae7a00b1282a0eb05d4f36)
* s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 5.Günther Deschner2009-04-291-0/+71
| | | | | | Guenther (cherry picked from commit 5e563ee508d0b3cc87d72ad52d777946ee0537b1) (cherry picked from commit c3f1cbd26792928970b6a60d82746719fea688d7)
* s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 4.Günther Deschner2009-04-291-0/+90
| | | | | | Guenther (cherry picked from commit d76837f6da2cf735d2b18c97f3b46ae2f04b750d) (cherry picked from commit d845a971ee32c8e9adb4717abe546355eb7153c9)
* s3-docs: document "net eventlog" in net manpage.Günther Deschner2009-04-291-0/+59
| | | | | | Guenther (cherry picked from commit 664ff081cadd29a1e750b349ecb23e8402d977cb) (cherry picked from commit 65d4acdb1b7f9cd78d38c23a00267688dc156da6)
* s3-net: make "net eventlog" help output a little more appropriate.Günther Deschner2009-04-291-1/+1
| | | | | | Guenther (cherry picked from commit e89cc775e660183e7126bcfa8fb37496074cf5a1) (cherry picked from commit e26efbd2c8a49012383032fef07cddec76561aa3)
* s3:smbd/service: switch load_registry_service/shares to use loadparm routinesMichael Adam2009-04-293-71/+5
| | | | | | | | | | | | | instead of reading the registry directly with tdb and activating the configure options by hand. This eliminates the need for repeating checks done in loadparm. For instance it disables registry shares without path in the server as is the case with text based shares. Michael (cherry picked from commit 077bcc11257697b243916fbb02cd72b3a122b9ba) (cherry picked from commit 502bfe9352d36ee909d7210a9d0ec0b6c7db5149)
* s3:loadparm: refactor process_registry_service out or process_registry_globalsMichael Adam2009-04-292-11/+26
| | | | | | Michael (cherry picked from commit fb3b6576127ce837ac711e87c293d1f4cf97473c) (cherry picked from commit 480af4e0ead10241aa94f4095c7fa580240fec00)
* samr: fix samr_ConnectVersion enum which is 32bit not 16bit.Günther Deschner2009-04-292-4/+4
| | | | | | | | | Volker, please check. Rafal, haven't we seen this in your tests at sambaxp as well ? Guenther (cherry picked from commit 67ca76c288eb095ae59e98927317d51c96c89551) (cherry picked from commit 59e75824e81ffb6d05e624a5344123c585998904)
* svcctl: Fix IDL for svcctl_StartServiceW().Günther Deschner2009-04-296-18/+119
| | | | | | Guenther (cherry picked from commit a23fb4663df11b237e94683510d282c286bbeed6) (cherry picked from commit d49e69d49a41d193d6e1dd342c653d9a8bc3b140)
* pm_process():raise level of debug messageMichael Adam2009-04-281-1/+1
| | | | | | Michael (cherry picked from commit 664da577f931dfd47573d3d77a95afb573fba855) (cherry picked from commit caa1f05420191d934c2ea1c2acaa75702c8e5c2e)
* s3:loadparm: prevent infinite include nesting.Michael Adam2009-04-281-2/+19
| | | | | | | | | | | | | | This introduces a hard coded MAX_INCLUDE_DEPTH of 100. When this is exceeded, handle_include (and hence lp_load) fails. One could of course implement a more intelligent loop detection in the include-tree, but this would require some restructuring of the internal loadparm housekeeping. Maybe as a second improvement step. Michael (cherry picked from commit d5f2bbdc489b751331e86afae58b0d80c5fedb9c) (cherry picked from commit bfd10fd322fe1721b8b45256cd988ed83b18a8a6)
* s3-net: make sure to call libnetapi init functions at the top of "net rpc" ↵Günther Deschner2009-04-281-0/+13
| | | | | | | | | | | | | | | | command. Without the initialization "net rpc password" will prompt twice for passwords and will not allow to define the name of the connection admin user. In the long run we should probably only have one place where to initialize libnetapi. Kai, please check. Guenther (cherry picked from commit 09ec85715b0e99740156ebb7213eddd1edfea631) (cherry picked from commit 0c5f19fbea7a6419a84ac0137a9a09995ef7a933)
* s3:mark registry shares without path unavailable just as with text configMichael Adam2009-04-281-0/+3
| | | | | | | | This prevents users from getting access to "/" in misconfigured setups. Michael (cherry picked from commit d16e40b5ef9add630d027ff92e440c44bfb88ef0) (cherry picked from commit 3bdb4342225444055b084908083e003e0e272e10)
* Fix annoying debug messages when no snapshots are usedVolker Lendecke2009-04-281-2/+3
| | | | | | | | Not being able to open the shadow copy directory is the same as having no shadow copy support at all. The VFS module should in this case not log with debug level 0 and set ENOSYS to indicate "no shadow copies used" to the higher levels. (cherry picked from commit 4982483cdd2a4d37f96574c19dd3aade236c1b93)
* s3-svcctl: Fix crash in _svcctl_EnumServicesStatusW().Günther Deschner2009-04-281-1/+3
| | | | | | | | The resume handle is a unique pointer, always check before dereference. Guenther (cherry picked from commit dd33abf649f4e1479365a2ccc2b41134270ff4ac) (cherry picked from commit 1e117c6ebc6322b7fac4928d84bc5e714e559ea5)
generated by cgit (git 2.34.1) at 2025-09-30 04:12:50 +0000