summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* r14451: In order to get pdb_ldap searching for SID_NAME_ALIASGerald Carter2007-10-102-43/+17
| | | | | | | | | | | | | | groups in the ${MACHINESID} and S_1-5-32 domains correctly, I had to add a substr search on sambaSID. * add substr matching rule to OpenLDAP schema (we need to update the other schema as will since this is a pretty important change). Sites will need to - install the new schema - add 'indea sambaSID sub' to slapd.conf - run slapindex * remove uses of SID_NAME_WKN_GRP in pdb_ldap.c
* r14450: Fix more get_md4pw() breakage caused by missing "breaks"Gerald Carter2007-10-101-0/+3
| | | | | in the switch statement which matched the schannel type against the account type.
* r14449: fix the build (sorry everyone)Gerald Carter2007-10-101-1/+2
|
* r14448: * protect against NULL cli_state* pointers in cli_rpc_pipe_open()Gerald Carter2007-10-102-3/+10
| | | | * Fix inverted logic check for machine accounts in get_md4pw()
* r14443: rework get_md4pw() to ease debugging. The only functional change is thatGünther Deschner2007-10-101-24/+69
| | | | | | we now check wheter the sec_channel_type matches the trust account type. Guenther
* r14432: Give in and grant BUILT\Administrators all privilegesGerald Carter2007-10-102-2/+25
|
* r14428: Call fill_share_mode_entry with NO_OPLOCK instead of 0.James Peach2007-10-101-3/+3
|
* r14421: This does two thingsGerald Carter2007-10-104-9/+86
| | | | | | | | | | | | | * Automatically creates the BUILTIN\Users group similar to how BUILTIN\Administrators is done. This code does need to be cleaned up considerably. I'll continue to work on this. * The important fix is for getusergroups() when dealing with a local user and nested groups. Now I can run the following successfully: $ su - jerry -c groups users BUILTIN\users
* r14418: Try and fix Coverity #39 and #40 by making theJeremy Allison2007-10-101-2/+10
| | | | | implicit function contract explicit. Jeremy.
* r14416: Remove deadcode. Coverity #198.Jeremy Allison2007-10-101-11/+1
| | | | Jeremy.
* r14408: More on fix for coverity #36. The previous fix would cause us toJim McDonough2007-10-101-0/+2
| | | | | | | marshall a buffer based on an unknown size. Zero out the sec_desc buffer to prevent this. This is still not getting proper results for a registry security descriptor (everything gets ACCESS DENIED), but at least we aren't blowing out memory now...
* r14406: Disable this call until we can sort out how thisJeremy Allison2007-10-101-0/+6
| | | | | should be done correctly. Fix coverity #37. Jeremy.
* r14405: Fix the build when nscd_flush_cache is detectedJeremy Allison2007-10-101-10/+12
| | | | | (variable definition was missing). Jeremy.
* r14403: * modifies create_local_nt_token() to create a BUILTIN\AdministratorsGerald Carter2007-10-1014-131/+253
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | group IFF sid_to_gid(S-1-5-32-544) fails and 'winbind nested groups = yes' * Add a SID domain to the group mapping enumeration passdb call to fix the checks for local and builtin groups. The SID can be NULL if you want the old semantics for internal maintenance. I only updated the tdb group mapping code. * remove any group mapping from the tdb that have a gid of -1 for better consistency with pdb_ldap.c. The fixes the problem with calling add_group_map() in the tdb code for unmapped groups which might have had a record present. * Ensure that we distinguish between groups in the BUILTIN and local machine domains via getgrnam() Other wise BUILTIN\Administrators & SERVER\Administrators would resolve to the same gid. * Doesn't strip the global_sam_name() from groups in the local machine's domain (this is required to work with 'winbind default domain' code) Still todo. * Fix fallback Administrators membership for root and domain Admins if nested groups = no or winbindd is not running * issues with "su - user -c 'groups'" command * There are a few outstanding issues with BUILTIN\Users that Windows apparently tends to assume. I worked around this presently with a manual group mapping but I do not think this is a good solution. So I'll probably add some similar as I did for Administrators.
* r14399: Fix deadcode coverity bug #3.Jeremy Allison2007-10-101-4/+1
| | | | Jeremy.
* r14397: Fix deadcode in coverity error #1.Jeremy Allison2007-10-101-7/+8
| | | | Jeremy.
* r14395: Fix coverity bug #55. Ensure no unsigned/signed comparisons.Jeremy Allison2007-10-101-3/+3
| | | | Jeremy.
* r14393: Fix a couple of AIX warnings.Jeremy Allison2007-10-102-1/+2
| | | | Jeremy.
* r14392: Use KRB5_TGS_NAME.Günther Deschner2007-10-101-1/+1
| | | | Guenther
* r14387: Try and fix the coverity issues (#53, #54) with negativeJeremy Allison2007-10-106-12/+11
| | | | | | sink by ensuring all uses of rpcstr_push are consistent with a size_t dest size arg. Jeremy.
* r14377: Fix coverity #4 for 3_0 tooSimo Sorce2007-10-101-1/+1
|
* r14368: Remove redundant set of logon flags (now in rpc_netlogon.h).Günther Deschner2007-10-101-2/+0
| | | | Guenther
* r14367: Not that I fully understand what's going on here, but the code as it ↵Volker Lendecke2007-10-101-4/+8
| | | | | | | | | | | was here was clearly buggy as Coverity showed with bug id #36. According to samba4 idl the sec_desc_buf is [in,out,ref], so we _have_ to ship it in the request. Volker
* r14365: As solaris nss includes includes.h, make sure we useJeremy Allison2007-10-101-3/+3
| | | | | the correct malloc-macros. Jeremy.
* r14359: Try and fix Coverity #176 by making the pointerJeremy Allison2007-10-101-7/+7
| | | | | | aliasing clearer. This isn't a bug but a code clarification. Jeremy.
* r14357: Try and fix Coverity #169 by making the pointerJeremy Allison2007-10-101-4/+6
| | | | | | | | | aliasing clearer. This isn't a bug but a code clarification. Jeremy. line, and those below, will be ignored-- M source/smbd/posix_acls.c
* r14355: Try and fix Coverity #158 by making the pointerJeremy Allison2007-10-101-6/+8
| | | | | | aliasing clearer. This isn't a bug but a code clarification. Jeremy.
* r14353: Fix coverity bugs #61 and #62. Remember to divide byJeremy Allison2007-10-102-26/+21
| | | | | the size of the data table. Clean up the struct a little. Jeremy.
* r14351: Ensure we use the minimum of PATH_MAX and sizeof(pstring).Jeremy Allison2007-10-101-5/+12
| | | | | Fix Coverity #59. Jeremy.
* r14345: Fix Coverity #71. We don't currently propagate *any*Jeremy Allison2007-10-101-10/+15
| | | | | | alloc error back up the stack from smbldap_set_mod() so ensure we abort correctly. Jeremy.
* r14342: Fix coverity #68, resource leak on error path.Jeremy Allison2007-10-101-22/+54
| | | | Jeremy.
* r14340: Fix coverity #78, resource leak in error path.Jeremy Allison2007-10-101-12/+20
| | | | Jeremy.
* r14338: Fix coverity #55 by explicit cast.Jeremy Allison2007-10-101-2/+5
| | | | Jeremy.
* r14336: Try and quieten coverity #53 and #54. Make it obviousJeremy Allison2007-10-101-2/+2
| | | | | we're using -1 as a special size_t case by casting. Jeremy.
* r14333: Fix coverity #77, ensure we can't exit after allocation.Jeremy Allison2007-10-101-0/+4
| | | | Jeremy.
* r14331: Add a comment on top of test_pam_modules about what we're testing.Lars Müller2007-10-101-0/+2
|
* r14329: Fix the build on systems without libcom_err.Günther Deschner2007-10-101-2/+2
| | | | Guenther
* r14326: First catch of make test_pam_modules.Lars Müller2007-10-101-1/+1
| | | | | | | | Testing pam_smbpass pam_winbind dlopen() of "./bin/pam_smbpass.so" succeeded. dlopen() of "./bin/pam_winbind.so" failed: ././bin/pam_winbind.so: undefined symbol: secrets_fetch_domain_sid make: *** [test_pam_modules] Error 1
* r14325: Add pam_modules rule which builds the configure(d) pam modules. This isLars Müller2007-10-103-4/+109
| | | | | | | | | | | | | | | called as part of the all rule (again only if pam modules are requested by configure). Add pam_winbind rule. Ensure proto_exists before we build the pam modules. Add test_pam_modules rule to test if the built pam modules have any unresolved symbols. For test_pam_modules we use script/tests/dlopen.sh which was written by Nalin Dahyabhai <nalin@redhat.com>. Thanks Nalin! RedHat and SuSE use this script to test nss and pam modules since several years.
* r14321: When we have libnscd and winbindd comes (back) online, try to flush theGünther Deschner2007-10-104-1/+25
| | | | | | nscd caches so that NSS-calls can deliver accurate information. Guenther
* r14317: Use source/bin as dir to link pam_winbind instead of source/nsswitch/Lars Müller2007-10-109-11/+11
| | | | | | | | | The intention is to have the resulting binaries at one place. This is also usefull for upcoming changes to provide a test_pammodules rule. With these changes I even got aware of testsuite/nsswitch/pam_winbind_syms.exp But this only covers pam_winbind.
* r14303: Fix coverity #223. In a loop we were forgetting to freeJeremy Allison2007-10-101-1/+3
| | | | | resources on error exit path. Jeremy.
* r14301: Fix coverity #224. In a loop we were forgetting to freeJeremy Allison2007-10-101-1/+3
| | | | | resources on error exit path. Jeremy.
* r14299: Fix coverity #225. In a loop we were forgetting to freeJeremy Allison2007-10-101-3/+6
| | | | | resources on error exit path. Jeremy.
* r14298: The other half of Coverity # 217Volker Lendecke2007-10-101-1/+1
|
* r14292: Janitor for tridge (samba3 talloc is almost identicalJeremy Allison2007-10-101-3/+19
| | | | | | | | | to Samba4 talloc). Jeremy - make the snprintf call in talloc portable to older solaris boxes - fixed an error found sing the beam analyser
* r14289: Fix coverity #101, resource leak on error code path.Jeremy Allison2007-10-101-2/+6
| | | | Jeremy.
* r14286: Similar clarifiction fix for coverity #102.Jeremy Allison2007-10-101-8/+10
| | | | Jeremy.
* r14284: Fix coverity bug #103. Make code clearer - probablyJeremy Allison2007-10-101-5/+9
| | | | | not a real issue but this code is easier to read. Jeremy.
* r14282: Change centry_string to only use talloc. ShouldJeremy Allison2007-10-101-16/+12
| | | | | | quieten coverity bug #194 (which I think is a false positive). Jeremy.
generated by cgit (git 2.34.1) at 2024-10-04 10:25:30 +0000