| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
uninitialized variable. (cherry picked from commit f92195e3a1baaddda47a5d496f9488c8445b41ad)
|
|
|
|
| |
Karolin
|
|
|
|
| |
Karolin
|
|
|
|
| |
Karolin
|
|
|
|
| |
This is the part of checkin cfee2025 that is relevant to this bug.
|
|
|
|
|
|
|
| |
Karolin
(cherry picked from commit 6e45c21384b8845422967ff1fa46e48de9fee1ab)
(cherry picked from commit aa97504f0358dcc23de7a65f39a1c4d24f0709b7)
(cherry picked from commit 57a019524d0d2bd434ac7382ed355f69c510ff14)
|
|
|
|
|
| |
Signed-off-by: Andreas Schneider <mail@cynapses.org>
(cherry picked from commit cce2cdf3041bedf14e08b1f839ab8ddfa88dd3d3)
|
|
|
|
|
|
|
|
| |
Signed-off-by: Andreas Schneider <mail@cynapses.org>
(cherry picked from commit 59ab1574e41993d24733affbca07d3f7da245fc7)
(cherry picked from commit d547aab1511c72e1cab034e2945f6ad63bda6659)
(cherry picked from commit c9b89676983c5fd0ec12df121fc5d9e06facdd80)
(cherry picked from commit f0d073d4e787516ae6e1a005e145ef2adf6a6e5d)
|
|
|
|
|
|
|
|
| |
Signed-off-by: Andreas Schneider <mail@cynapses.org>
(cherry picked from commit 1809ff4b2339bd3066532abccea0944da45edf64)
(cherry picked from commit 5d2dfba6d1699c6e417cc21233a1cc871f3c0ad1)
(cherry picked from commit 282682c989a8008de5f8d30c48c9a740b315a230)
(cherry picked from commit 15892ce595ea050b58756130b6bc6031ae0752ca)
|
|
|
|
|
|
|
|
| |
Signed-off-by: Andreas Schneider <mail@cynapses.org>
(cherry picked from commit 779eea49de3f53040fe792de4b74b73a0c51ecb3)
(cherry picked from commit 24d6f697844bc85a03c047e5470abcfdd53735a2)
(cherry picked from commit 2ed85b0ebfc50cad847050cc6b5269c470956ea3)
(cherry picked from commit 0619c29d3b0bb59cd31ed48df47878170d4cfd9b)
|
|
|
|
|
|
|
|
| |
Signed-off-by: Andreas Schneider <mail@cynapses.org>
(cherry picked from commit 24f9f32fedb92f881658db856db15173e57af0bd)
(cherry picked from commit 55df96313c5b966f41b0b5c426cf6a420cafa855)
(cherry picked from commit f738862d9f419fec27c9fb15c880a452aff333d9)
(cherry picked from commit 0669d66d81be3f265eab442c22b2881615d502db)
|
|
|
|
|
| |
Karolin
(cherry picked from commit 26b5cb2df0fbf2d0c004da4872c3733f3b75fd62)
|
|
|
|
|
| |
Karolin
(cherry picked from commit f2ae8244603a4232331b7c3128661aec08ecd977)
|
|
|
|
|
| |
Karolin
(cherry picked from commit fb5b65081ea2199e2c3b3a36acfe578b5c2f15d1)
|
|
|
|
|
| |
This fixes bug #5945.
(cherry picked from commit a7735416792f8156e53a04af98e7e2dff0b6707d)
|
|
|
|
|
|
| |
These were added between 3.2.4 and 3.2.5 that have caused users problems.
This fixes among others bug #6089 and #6112.
(cherry picked from commit f2a29585123e6072a75eb9abdd202f99f5a01e1e)
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is totally valid to have an alias with no members.
This fixes bug #6465.
Tridge, please check.
Found by RPC-SAMR torture test.
Guenther
(cherry picked from commit d27c4346397b828e3d7d01473f174577440d950a)
|
|
|
|
|
|
|
|
|
|
| |
users.
GUenther
(cherry picked from commit 3938d1e5fa1996f64e92d33d6893bab620d16b23)
(cherry picked from commit 0491f038403036814acf6eacc7bb742345bbe27b)
(cherry picked from commit d4b57dab0beada704fcbeae86ae5b5dd257030a0)
(cherry picked from commit 191f34654b653ed1f376c842d2d023c43eb866e0)
|
|
|
|
|
| |
Karolin
(cherry picked from commit cd837cfc8d60c6fdc3e8443f9545a1a69ed2a57b)
|
|
|
|
|
| |
Karolin
(cherry picked from commit 30fc90ffd82a4731e9c4014e28f08a5377b4a0ba)
|
|
|
|
|
|
|
|
|
|
|
| |
Fix typos reported by OPC oota <t-oota [at] dh.jp.nec.com>.
Thanks!
Karolin
(cherry picked from commit ad0d8032068fc9b920e205d3f5f923174101d777)
(cherry picked from commit b7d54f443ade79d3f2b71aa138fd5254754bb750)
(cherry picked from commit cec179962a833771b9fdba3ba747b571ef27ace6)
(cherry picked from commit 484c38b5529ca903dede7ed4770ba996be447dbf)
|
|
|
|
|
|
|
|
|
|
|
|
| |
The 'ldap suffix' is not added automatically to the 'ldap admin dn'.
This fixes bug #5584.
Thanks to Stefan Bauer <stefan.bauer [at] plzk.de> for reporting!
Karolin
(cherry picked from commit 0fee798552038b730b0107540d6cfeb475803555)
(cherry picked from commit 629e7aa91a33a5428676d8f6eeac19ea9fec14d6)
(cherry picked from commit 01acd8d9277362ae3c0e92963f66e7af3202b84d)
(cherry picked from commit 7d3936b788de16433fbaaf7fd015873df4edd605)
|
|
|
|
|
|
|
|
|
| |
This is aiming bug #6351.
Karolin
(cherry picked from commit c94d1cd7b1dc3ff99ae5a1eb9058ed6015fb9749)
(cherry picked from commit 11ed212591d612632fcb47f1eac10507b89ffdec)
(cherry picked from commit 28d4cd50d1a76bc374a8420c490411a52c32fdbb)
|
|
|
|
|
|
|
|
| |
This is now also verified with the RPC-SAMR-LARGE-DC test.
Guenther
(cherry picked from commit fca7dce1a908570e463ddcbd663955fcafd1d843)
(cherry picked from commit 6ad726f50ee10ac2a2f157906b3b3adb88bfea37)
|
|
|
|
|
|
|
|
| |
Karolin
(cherry picked from commit 613c8acbdd93210b40ec6fa48cbbf297a061b3cc)
(cherry picked from commit c84f1c7ac9da7e26f28cb233efe45614f0cedea3)
(cherry picked from commit 8878670414bd2607ad238b4fb61a109d5f430538)
(cherry picked from commit 6da23f8f0d4d045095d965ff62b7892c645fa139)
|
|
|
|
|
| |
Karolin
(cherry picked from commit 2fb6b4c592ae3e855019a604e0e7ada6ad816e00)
|
|
|
|
|
| |
Karolin
(cherry picked from commit a7fbd3ae42fd3849150da27c37405dbefb59f86e)
|
|
|
|
|
| |
Karolin
(cherry picked from commit 5493ea49b64029eee48d4c0128c5172ef24638a7)
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes bug #4341.
Thanks to Michael Cartmell <michael.cartmell [at] thomson.com> for reporting!
Karolin
(cherry picked from commit 2228cc6a0f942b774bef7fb0b99009897fa4dff4)
(cherry picked from commit e1b1f14e0260395a8d452ea0a129bcc9bb3f98cc)
(cherry picked from commit de156e6ee292ad7fc683d681d7c4b44edba67626)
(cherry picked from commit 58539095ee526a08234a4a3111d54af45a84e13a)
|
|
|
|
|
|
|
|
|
| |
Invalid pointers were being dereferenced in lookup_sids causing
occasional seg faults.
Signed-off-by: Tim Prouty <tprouty@samba.org>
(cherry picked from commit 34ca12c9396f7c8475cd1525bdbc40021b0e533f)
(cherry picked from commit 9f5f8278b905b38d288618916c23f85373919b83)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In winbind, we do multiple events in one select round. This needs fixing, but
as long as we're still using it, for efficiency reasons we need to do that.
What can happen is the following: We have outgoing data pending for a client,
thus
state->fd_event.flags == EVENT_FD_WRITE
Now a new client comes in, we go through the list of clients to find an idle
one. The detection for idle clients in remove_idle_client does not take the
pending data into account. We close the socket that has pending outgoing data,
the accept(2) one syscall later gives us the same socket.
In new_connection(), we do a setup_async_read, setting up a read fde. The
select from before however had found the socket (that we had already closed!!)
to be writable. In rw_callback we only want to see a readable flag, and we
panic in the SMB_ASSERT(flags == EVENT_FD_READ).
Found using
bin/smbtorture //127.0.0.1/tmp -U% -N 500 -o 2 local-wbclient
Volker
(commit 68c5c6df in master)
(cherry picked from commit d12681489f18df97b11c4ce6e069d6e2d006c184)
|
|
|
|
|
|
|
|
|
| |
Thanks to Oota Toshiya <t-oota at dh.jp.nec.com> for reporting!
Karolin
(cherry picked from commit f3df38362cc15211d9fca8229a0f9d9fc9c8e481)
(cherry picked from commit 7434898b10a5c5780bd015b7bdca3eaa7a2b5475)
(cherry picked from commit 58372ab5dccce60b40e29196767b29e81dfe9872)
|
|
|
|
| |
(cherry picked from commit fad2741ec79a34f25577d0a5d3c35a6455d3ce24)
|
|
|
|
|
|
|
|
| |
It is not technically an ldb bug, but apparently some callers try to access
res before checking the ldb_search() return code.
So make their attempt very evident (a NULL dereference will make it cristal
clear where the bug is).
(cherry picked from commit c60539f31f63bd65e5b0e3ee16365f036bef3d5b)
|
|
|
|
|
|
|
| |
Jeremy.
(cherry picked from commit 8d178837f259757340a09a688ed194e3e4a92c36)
(cherry picked from commit 6631ca4a51d4b13d2edd2dc899f7b76c233825b5)
(cherry picked from commit a7f96104b957ba0eb910f8c0073818f872345e3c)
|
|
|
|
|
|
|
|
|
|
| |
Was missing case of "If file exists open. If file doesn't exist error."
Damn damn damn. CIFSFS client will have to have fallback cases
for this error for a long time.
Jeremy.
(cherry picked from commit b652082648c49b525d2b2ce619b575ee75bc242e)
(cherry picked from commit 12cf12f10c1c6adad568daf6c16144a99b0f822e)
(cherry picked from commit 2050a239a5fee6cfd17d083619cc4a03a3a6dd6d)
|
|
|
|
| |
(cherry picked from commit cdc93a7edc6798078a7b21b1728a844437b6522b)
|
|
|
|
|
|
|
|
|
|
| |
This fixes bug #5897. Thanks to TAKAHASHI Motonobu
<monyo [at] samba.gr.jp> for reporting and providing the example!
Karolin
(cherry picked from commit f741b90ee8f74077871a0b5d1df55c0dd34a313f)
(cherry picked from commit 1653bbf50b02e4f4dc2f01c5dab32c1cc4894582)
(cherry picked from commit 3f45721216cc6144784c28b82a594f25ebdb1608)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from Jeremy.
With this patch, I was able to join Windows 7 RC to a Samba3 DC, and login into a
Samba 3 Domain.
There are still two registry settings required:
HKLM\System\CCS\Services\LanmanWorkstation\Parameters
DWORD DomainCompatibilityMode = 1
DWORD DNSNameResolutionRequired = 0
Do *not* modify the other netlogon registry parameters that were passed around,
they weaken security.
Guenther / Jeremy.
(cherry picked from commit 43bab13d00fa073acf709ac9a66cb2782694811b)
|
|
|
|
|
|
|
| |
Found by SCHANNEL torture tests.
Guenther
(cherry picked from commit c578c66569eed3ae19b42c9787399eb70b935e0a)
|
|
|
|
|
|
| |
need to fix bug #6099 Samba returns incurrate capabilities list. 1). Add a comment to point out that r->in.negotiate_flags is an aliased pointer to r->out.negotiate_flags. 2). Ensure we return NETLOGON_NEG_STRONG_KEYS in our flags return if the client requested it. 3). Clean up the error exits so we always return the same way. Signed off by Guenther. Jeremy.
(cherry picked from commit 59ee131464636d3363bc7ee398ba6390a6333558)
|
|
|
|
|
|
|
| |
negotiate flags (which are a pointer to the out negotiate flags assigned in the generated netlogon server code). So, while you wanted to just set the *out* negflags, you did in fact reset the *in* negflags, effectively eliminating the NETLOGON_NEG_STRONG_KEYS bit (formerly known as NETLOGON_NEG_128BIT) which then caused creds_server_init() to generate 64bit creds instead of 128bit, causing the whole chain to break. *Please* check.
Guenther
(cherry picked from commit 853bbc0d3920654aa7401fa5d6fcba7ff86e1a21)
|
|
|
|
|
|
| |
this is a backport of f238809d236443b8968e1b4b197a55935c7c7e85 from master
(cherry picked from commit 1b040289f14bb22d3b6ab07a452236549d6c9bf6)
(cherry picked from commit 7f1771f26dcc334c32df332545d33937f8602bd6)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
owner (bug#2346)
The problem of bug #2346 remains for users exported by
winbindd, because create_token_from_username() just fakes
the token when the user is not in the local sam domain. This causes
user_in_group_sid() to give totally wrong results.
In uid_entry_in_group() we need to check if we already
have the full unix token in the current_user struct.
If so we should use the current_user unix token,
instead of doing a very complex user_in_group_sid()
which doesn't give reliable results anyway.
metze
(cherry picked from commit b79eff843be392f3065e912edca1434081d93c44)
(cherry picked from commit cb5c72c0a05a78ff1b86eb02cf5ecd3d7d69623d)
(cherry picked from commit ef0d72513b5404f176186632aab67d7b87039ba2)
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes bug #5832.
Patch was provided by D.L. Meyer <dlmeyer [at] uiuc.edu>.
Thanks for reporting and providing the patch!
Karolin
(cherry picked from commit 42e0cb8c0a1b8470ac8e9ad1c5a741e299debb8f)
(cherry picked from commit b2205a7697598729f85cb767621b8c610654053c)
(cherry picked from commit 07d40da10ac9aab58cb7684dc39f6c1ffeb2d020)
|
|
|
|
|
|
|
|
| |
picked from 9097a67de
Volker
(cherry picked from commit 9ffb1e6f0ded2647efe567912873a1a63e2ffed1)
(cherry picked from commit d3f39da433c22632007a9300d4dab4cda0dfd43e)
|
|
|
|
|
|
|
| |
that *uid is always initialized on return from create_token_from_username(). Restore it. Jeremy.
(cherry picked from commit 09b76c57098ed4d11855000ae31cd346cb9a765d)
(cherry picked from commit 191e4c415e7008070110970ba51f3f82dc493a8b)
|
|
|
|
|
|
|
|
| |
Karolin
(cherry picked from commit 4a4dc776b2f0ca813abcf4f47f0d5721f75f3e6a)
(cherry picked from commit 6a617a9677da9df8f70cf2039245cfb5ce3d94c3)
(cherry picked from commit 8c5771422bf25dba0638c3419ac14f0841b94293)
(cherry picked from commit fe7c528089815a533402b5a3b247db94a2c70d6d)
|
|
|
|
|
|
|
| |
Guenther
(cherry picked from commit e398f1e91575909d2a90fab1e6f00804815a0b2f)
(cherry picked from commit e19dddb2b438b75dcd995aaa763fcbe55d7de5cc)
(cherry picked from commit 457313c37904246fb0628ab0f2ef207dc38b2f85)
|
|
|
|
|
|
|
|
|
|
| |
This should fiy bug #5853. Thanks to D.L. Meyer <dlmeyer [at] uiuc.edu>
for reporting.
Karolin
(cherry picked from commit d8de7e3193143ec50d86adc704123ca240a8f549)
(cherry picked from commit c89c2db8c51bd3cede2e2e8fb58214971eda4129)
(cherry picked from commit 437136465e52a893a3f866bda40d4c9d812693d9)
|