| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
| |
Windows Explorer doesn't complain about the order (and so that they get
interpreted properly).
Derrell
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Win2000 ignored
the request, presumably due to the PROTECTED flag not being set. Setting
that flag (in make_sec_desc()) has much wider implications than just to
libsmbclient, so instead of modifying that, we'll remove security
descriptors by setting the number of ACEs to zero. At some point, we might
want to look into whether we should actually be setting the PROTECTED flag
in the DACL.
Reference http://www.microsoft.com/technet/prodtechnol/windows2000serv/reskit/distrib/dsce_ctl_qxju.mspx?mfr=true
Derrell
|
|
|
|
|
|
| |
fixes winreg_EnumValues()
metze
|
|
|
|
| |
metze
|
|
|
|
|
|
|
|
|
|
| |
length_is() isn't supported without size_is().
I assume what we need is an array of strings,
so the code isn't used and broken anyway without
a testsuite...just get rid of the pidl warning
metze
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
|
|
| |
functions.
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to me,
prs_mem_free() is not the function to be called to free memory allocated by
prs_alloc_mem(). I've added a comment so others may not get bitten too.
- Remove incorrect memory free calls added yesterday to replace SAFE_FREE.
The memory is actually now on a talloc context, so gets freed by the caller
when that context is freed. We don't need to free it iternally.
Derrell
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pointer was
incremented too far in some circumstances. In these cases, only the first
of multiple concatenated strings would be seen.
- Working on bug 4649 pertaining to delete an ACL, this fixes the reported
crash. It appears to have been an incomplete switchover from malloc to
talloc, as the memory was still being freed with SAFE_FREE.
Deleting ACLs still doesn't work. Although a valid request is sent to the
server and a SUCCESS response is returned, the method that's used in
libsmbclient for deleting ACLs seems to be incorrect. In looking at the
samba4 torture tests, it appears that we should be turning on the INHERIT
flag if we want to delete the ACL. (I could use some assistance on the
proper flags to send, from anyone familiar with this stuff.)
- Apply patch from SATOH Fumiyasu to fix bug 4750. smbc_telldir_ctx() was not
returning a value useful to smbc_lseekdir_ctx().
Derrell
|
|
|
|
| |
Guenther
|
|
|
|
|
| |
Merged from my Samba4 GSoC branch.
Volker, can you check if that's done the way you thought?
|
|
|
|
| |
Thanks to Kai Blin <kai@samba.org> for reporting this
|
| |
|
| |
|
|
|
|
|
|
| |
enums are not necessarily represented as 32-bit uints. On assignment
(see line 1029) implicit conversion happens, but not when pointers are
taken.
|
|
|
|
|
|
|
|
| |
Jerry, please check this!
Thanks,
Volker
|
| |
|
|
|
|
|
|
|
|
|
| |
patch from Bjoern JAcke <bj@SerNet.DE>:
attached patches add EA support for Solaris. If no one disagrees, can
someone check this in please?
metze
|
|
|
|
|
|
|
|
|
|
|
|
| |
and alters the device id depending on the configured algorithm.
The algorithm is configured via "fileid:algorithm":
- "fsname" (default) uses a uint64 hash over the mount point
- "fsid" uses the fsid returned from statfs()
This is needed for "clustering = yes" on some clusterfilesystems
metze
|
|
|
|
| |
We've checked num_rids != 0 above.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
left as nonzero as returned by the failed cli_session_setup_spnego. When we then try
to authenticate as the user in cli_session_setup this returns an
error "Bad userid" (as seen in wireshark).
"We should only leave cli->vuid != 0 on success. Looks like it's
getting set in the cli_session_setup_blob_receive() call and not
cleared again on error."
Jeremy.
|
| |
|
|
|
|
| |
strlcpy does not like a NULL source. Fix a use-after-free.
|
|
|
|
|
| |
I had only tested with "net getlocalsid". posix_locking_init() calls this
with a NULL name...
|
|
|
|
| |
This has been superseded by the "tdb_hashsize:<tdbname>" parameter
|
|
|
|
|
|
|
|
|
|
| |
This makes it possible to set the default hashsize for any tdb. I would
like to remove the "open files database hash size" in favor of this one.
I'll check that removal in with the next commit, please complain/revert
if it's not ok.
Volker
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
----------------------------------------------------------
In rare cases, Samba 3.0.25b shows directory contents at the wrong
position in the file tree when displaying a subdirectory of a DFS link.
The problem occurs whenever Windows XP asks for a DFS referral for a
subdirectory of a DFS link with a trailing backslash.
Windows does not do this very often, but we saw it several times per day
on our central DFS server.
smbd/msdfs.c, dfs_path_lookup() does the following with the requested
path:
- in line 390, the local copy 'localpath' is 'unix_convert'ed; the
trailing backslash is removed inside unix_convert
- in lines 417-20, 'dfspath' (another copy of the requested path) is
mangled another way without removing trailing backslashes
That's why the following loop (lines 435-461) that is meant to
synchronously cut off the last path component from both strings until it
comes to a DFS link, does not handle both strings the same. When the
original path ended with a backslash, 'canon_dfspath' has always one
component more than 'localpath', so that *consumedcntp gets too big in
line 446. This value is reported to the client.
----------------------------------------------------------
Bug #4860.
Jeremy.
|
|
|
|
| |
Guenther
|
|
|
|
|
|
|
|
| |
Heimdal doesn't accept all OIDs and gss_import_name() fails with
GSS_S_BAD_NAMETYPE using this one. Use the GSS_KRB5_NT_PRINCIPAL_NAME OID
instead (which works with at least MIT 1.6.1 and Heimdal 1.0.1).
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
We checked argc>=3 some lines above
|
| |
|
|
|
|
|
| |
This was not really a bug I think, but this change cleans up the code a
bit.
|
|
|
|
|
|
|
| |
Panisset <panisset@A52.com>.
Awaiting confirmation from reporter.
Jeremy.
|
|
|
|
|
|
| |
domain local group.
Fix a typo in the PAC debugging routine
|
|
|
|
|
|
|
|
|
|
| |
- make it more clear what the different min and max fields mean
- with the "GSSAPI" sasl mech the plain, sign or seal negotiation
is independed from the req_flags and ret_flags
- verify the server supports the wrapping type we want
- better handling on negotiated buffer sizes
metze
|
|
|
|
|
|
| |
fix double free in error path
metze
|
|
|
|
|
|
| |
use TALLOC_FREE()
metze
|
|
|
|
|
|
| |
add file_id_create() to some vfs modules
metze
|