summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * r20720: Fix the chkpath problem, still looking at findfirst.Jeremy Allison2007-01-132-1/+13
| | | | | | | | Jeremy.
| * r20719: Sync up the changes in the fileserver code between SAMBA_3_0.Jeremy Allison2007-01-125-54/+99
| | | | | | | | | | copy now returns NTSTATUS, part of close does the same. Jeremy.
| * r20717: Merge sharemode patch from Mathias Dietz <MDIETZ@de.ibm.com>.Jim McDonough2007-01-121-4/+9
| | | | | | | | | | The patch fixes the behaviour of GPFS sharemodes when the access mask is no_access.
| * r20711: Merge Volker's fix for bug 4326.James Peach2007-01-121-1/+2
| | | | | | | | svn merge -r 20698:20699 branches/SAMBA_3_0
| * r20695: Remove duplication of constants.Jeremy Allison2007-01-121-11/+2
| | | | | | | | Jeremy.
| * r20694: To get this right we need to do signed 64-bitJeremy Allison2007-01-121-7/+7
| | | | | | | | | | | | | | comparisons here, not unsigned as we're eventually casting into what it normall a signed 32 bit value. Guenther please check (but I think I'm right here). Jeremy.
| * r20692: Fix bug found by Guenther -Jeremy Allison2007-01-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Just try to log on in offline mode without the fix: all accounts are expired, although they are set to never expire in the PAC/info3. NTTIME "Never" needs to get (time_t) -1. We were casting a uint64 to time_t before comparing, and we should have been doing it the other way around. Guenther please check this fixes things. Jeremy.
| * r20691: As discussed with tridge, merge the following fix :Jeremy Allison2007-01-121-32/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Jeremy. fix a bug that causes smbd to 'hang' intermittently. The problem occurs like this: 1) running smbd as a domain member without winbindd 2) client1 connects, during auth smbd-1 calls update_trustdom_cache() 3) smbd-1 takes the trustdom cache timestamp lock, then starts enumerate_domain_trusts 4) enumerate_domain_trusts hangs for some unknown reason 5) other clients connect, all block waiting for read lock on trustdom cache 6) samba is now hung The problem is the lock, and really its just trying to avoid a race where the cure is worse than the problem. A race in updating the trutdom cache is not a big issue. So I've just removed the lock. It is still an open question why enumerate_domain_trusts() can hang. Unfortunately I've not in a position to get a sniff at the site that is affected. I suspect a full fix will involve ensuring that all the rpc code paths have appropriate timeouts.
| * r20687: Implement grace logons for offline authentications in pam_winbind.Günther Deschner2007-01-113-21/+45
| | | | | | | | | | | | | | | | | | In case a user authenticated sucessfully and his password just expired while beeing disconnected, we should allow a user to logon (given a clear warning). We currently forced the user into a password change dialogue in that scenario; this did not make much sense while offline. Guenther
| * r20673: Add in the wdel smbclient command that allows meJeremy Allison2007-01-111-8/+12
| | | | | | | | | | | | to hand test attribute and wildcard delete strings to try and understand the underlying method in w2k3. Jeremy.
| * r20672: Start working on the wildcard cases - put back thisJeremy Allison2007-01-111-0/+19
| | | | | | | | | | exception case. Jeremy.
| * r20671: This version of the pathname code passes volkersJeremy Allison2007-01-117-74/+61
| | | | | | | | | | modified gentest to 1000 iterations. Jeremy.
| * r20662: Strange semantics for normalizing non-wildcardJeremy Allison2007-01-101-0/+3
| | | | | | | | | | deletes. Jeremy.
| * r20660: 126 operations - getting close now....Jeremy Allison2007-01-101-1/+1
| | | | | | | | Jeremy.
| * r20658: Now up to passing 108 operations on gentest.....Jeremy Allison2007-01-101-5/+6
| | | | | | | | Jeremy.
| * r20655: After consulting with Volker, fix our pathnameJeremy Allison2007-01-1013-657/+450
| | | | | | | | | | | | | | | | | | | | handling. Gets rid of more code than it adds. I will port this to SAMBA_3_0 next. There are still some wrinkles with wildcard delete I am working on - for example a dirtype pattern of 0x8aa4 isn't handled correctly yet.... still looking at this. Jeremy.
| * r20654: Fix from Karolin Seeger <ks@sernet.de>: Accept "forever", "off" and ↵Volker Lendecke2007-01-101-7/+15
| | | | | | | | | | | | | | | | "never" as key words for -1 as policy values for net sam policy. Volker
| * r20651: Fix "password expires soon" warning message for pam_winbind.Günther Deschner2007-01-101-12/+67
| | | | | | | | | | | | | | | | We were incorrectly calculating the days until the password expires and we also need to look at the info3 pass_must_change_time for expiry calculation. Guenther
| * r20644: Make some functions static, thanks to Michael Adam <ma@sernet.de> ↵Volker Lendecke2007-01-101-3/+3
| | | | | | | | for the hint.
| * r20635: Add placeholder to ensure we don't go into theJeremy Allison2007-01-091-0/+11
| | | | | | | | | | | | | | | | | | wcard unlink if bad_path was set. The error returned here is almost certainly incorrect and will need testing properly with smbtorture, but I don't want to forget about this path (yes Volker I know this is currently incorrect :-). Jeremy.
| * r20632: The extended RAW-SAMBA3BADPATH test led me to some wrong assumptions, inVolker Lendecke2007-01-091-5/+0
| | | | | | | | | | | | | | | | particular the NT_STATUS_INVALID_PARAMETER thing was badly wrong. Remove the changes based on it. Using gentest is much more effective in this respect, but it will take a while to figure out the wildcard error handling of W2k3. Volker
| * r20630: Fix some trivial memleaks.Günther Deschner2007-01-091-0/+3
| | | | | | | | Guenther
| * r20620: This is definately needed - not sure about mapping toJeremy Allison2007-01-081-0/+5
| | | | | | | | | | | | | | | | | | BAD_PARAMETER if unlink is a wildcard but wildcard unlinks are so rare in modern clients that doing what W2K3 does is probably ok. OS/2 is the only client that may care about this and hopefully we will get test coverage from our wonderful OS/2 test team on this ! :-). Jeremy.
| * r20615: Janitor for vl.... Please ensure all obvious fixesJeremy Allison2007-01-081-1/+1
| | | | | | | | | | go in both branches. Jeremy.
| * r20604: Fix two memleaks, Coverity ID 337, merge to 3_0_24Volker Lendecke2007-01-081-7/+9
| |
| * r20589: Re-add lost bad_path handling, sorry.Volker Lendecke2007-01-061-0/+4
| |
| * r20584: - allocate an OID range for LDB/LDAP extended operationsStefan Metzmacher2007-01-061-0/+1
| | | | | | | | metze
| * r20579: - allocate an OID range for samba4 LDB/LDAP ControlsStefan Metzmacher2007-01-061-0/+2
| | | | | | | | | | | | - allocate an OID range for conflicting attributes/classes metze
| * r20558: Refactor rmdir_internals to use early termination ratherJeremy Allison2007-01-051-56/+57
| | | | | | | | | | | | | | than lots of indented code. Change recursive_rmdir() to return the smbd standards of True on success, False on fail (it was doing the reverse, which was very confusing). Jeremy.
| * r20546: Fix some IBM checker errorsVolker Lendecke2007-01-051-0/+4
| |
| * r20541: Fix some obvious glitches in wait_for_aio_completion. Hmmm. It seemsVolker Lendecke2007-01-051-6/+5
| | | | | | | | | | | | reply_close() at its heart is going to be an async call :-) Volker
| * r20537: Missed one of Vl's fixes :Jeremy Allison2007-01-042-2/+2
| | | | | | | | | | | | "Make us survive and activate RAW-CLOSE" Jeremy.
| * r20536: In the offline PAM session close case the attempt to delete aGünther Deschner2007-01-042-1/+7
| | | | | | | | | | | | non-existing krb5 credential cache should not generate an error. Guenther
| * r20535: Fix make install to work when root doesn't haveJeremy Allison2007-01-041-3/+7
| | | | | | | | | | | | write access into the source tree (like when your directory is nfs mounted for example....). Jeremy.
| * r20534: Final merge of Volker's work - we should be in syncJeremy Allison2007-01-041-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | on the file server code now except for the change notify code. "Closing a dir with del-on-close set requires the same as files: Don't actually unlink/rmdir if another process still has it open. Jeremy, this is a potential merger to 3.0.24." Jeremy.
| * r20533: Adopt Volker's "Simplify logic of close_remove_share_mode()".Jeremy Allison2007-01-041-51/+67
| | | | | | | | Jeremy.
| * r20532: From Volker...Jeremy Allison2007-01-041-0/+9
| | | | | | | | | | | | | | | | | | | | "smbcli_setattr("") always returns ACCESS_DENIED, test extension to follow. Merge to 3.0.24?" Yep (with slight optimization). Jeremy.
| * r20530: Don't want this call to get inadvertently re-added :-).Jeremy Allison2007-01-041-3/+0
| | | | | | | | Jeremy.
| * r20528: This fix now naturally follows : (from VL).Jeremy Allison2007-01-041-26/+19
| | | | | | | | | | | | | | "Both remaining calls of can_delete called it with check_is_at_open==False, remove that parameter." Jeremy.
| * r20527: Reviewed Volker's unlink change :Jeremy Allison2007-01-043-2/+5
| | | | | | | | | | | | "Make us survive & activate RAW-UNLINK" Jeremy.
| * r20526: Working through code review of Volker's changes slowly....Jeremy Allison2007-01-042-23/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I agree with this one : "Jeremy, another one to check: The only error path of can_delete() that we're interested in ntcreate&x is the one of can_delete_file_in_directory(), so call that directly. The only other one where we might get a NT_STATUS_ACCESS_DENIED is from the lstat in can_delete, but this is covered later in the open_directory and open_file_ntcreate calls. open_directory does a stat() in the open case which also covers the (potential) symlink, and open_file_ntcreate does the open(2) itself, so this should also work. This makes can_delete() static to reply.c. Volker" Jeremy.
| * r20512: Fix typo.Günther Deschner2007-01-031-1/+1
| | | | | | | | Guenther
| * r20503: And one more 64-bit warningVolker Lendecke2007-01-031-1/+1
| |
| * r20501: Check in config.h fix from Michael Adam <ma@sernet.de>Volker Lendecke2007-01-032-0/+9
| |
| * r20498: Two 64-bit warningsVolker Lendecke2007-01-031-2/+4
| |
| * r20496: Some changes to make Samba3 the RAW-OPEN test. Checking in to both ↵Volker Lendecke2007-01-032-7/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3_0 and 3_0_24 because I was explicitly asked to, although this needs close review. Jeremy, I'm sure you will check this thoroughly :-) In reply_open_and_X the separate "size" variable kills the calculation of the SPARSE flag returned to the client in the attrib field. In getpathinfo we do it correctly, and RAW-OPEN (correctly) complains about the difference. Add the "set the write time" to mknew and create. For trans2open we were missing the "ofun == 0" -> NT_STATUS_OBJECT_NAME_COLLISION case, and we dropped the status returned in favor of ACCESS_DENIED once too many. Last change is a fix to trans2open: We were returning the attributes given by the client, not the attributes of the new file. Volker
| * r20491: Janitor for Volker :Jeremy Allison2007-01-021-4/+4
| | | | | | | | | | "Get rid of a redundant !NT_STATUS_IS_OK(status)" Jeremy.
| * r20490: Janitor for Volker - Jeremy Allison2007-01-021-4/+0
| | | | | | | | | | | | "Get rid of a bogus variable that was only assigned but never read." Was used but is not now. Jeremy.
| * r20489: Missed patch ofthe forest_name patch for lookupnameGerald Carter2007-01-021-4/+8
| |
| * r20488: When joined to a child domain in a multi-domain/single domain tree,Gerald Carter2007-01-023-6/+89
| | | | | | | | | | | | | | the child domain cannot always resolve SIDs in sibling domains. Windows tries to contact a DC in its own domain and then the root domain in the forest. This async changes makes winbindd's name2sid() call do the same.