| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| | |
Jeremy.
|
| |
| |
| |
| |
| | |
copy now returns NTSTATUS, part of close does the same.
Jeremy.
|
| |
| |
| |
| |
| | |
The patch fixes the behaviour of GPFS sharemodes when
the access mask is no_access.
|
| |
| |
| |
| | |
svn merge -r 20698:20699 branches/SAMBA_3_0
|
| |
| |
| |
| | |
Jeremy.
|
| |
| |
| |
| |
| |
| |
| | |
comparisons here, not unsigned as we're eventually
casting into what it normall a signed 32 bit
value. Guenther please check (but I think I'm right here).
Jeremy.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Just try to log on in offline mode without the fix: all accounts are expired,
although they are set to never expire in the PAC/info3.
NTTIME "Never" needs to get (time_t) -1.
We were casting a uint64 to time_t before
comparing, and we should have been doing it
the other way around.
Guenther please check this fixes things.
Jeremy.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Jeremy.
fix a bug that causes smbd to 'hang' intermittently.
The problem occurs like this:
1) running smbd as a domain member without winbindd
2) client1 connects, during auth smbd-1 calls update_trustdom_cache()
3) smbd-1 takes the trustdom cache timestamp lock, then starts
enumerate_domain_trusts
4) enumerate_domain_trusts hangs for some unknown reason
5) other clients connect, all block waiting for read lock on trustdom
cache
6) samba is now hung
The problem is the lock, and really its just trying to avoid a race
where the cure is worse than the problem. A race in updating the
trutdom cache is not a big issue. So I've just removed the lock.
It is still an open question why enumerate_domain_trusts() can
hang. Unfortunately I've not in a position to get a sniff at the site
that is affected. I suspect a full fix will involve ensuring that all
the rpc code paths have appropriate timeouts.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In case a user authenticated sucessfully and his password just expired
while beeing disconnected, we should allow a user to logon (given a
clear warning). We currently forced the user into a password change
dialogue in that scenario; this did not make much sense while offline.
Guenther
|
| |
| |
| |
| |
| |
| | |
to hand test attribute and wildcard delete strings
to try and understand the underlying method in w2k3.
Jeremy.
|
| |
| |
| |
| |
| | |
exception case.
Jeremy.
|
| |
| |
| |
| |
| | |
modified gentest to 1000 iterations.
Jeremy.
|
| |
| |
| |
| |
| | |
deletes.
Jeremy.
|
| |
| |
| |
| | |
Jeremy.
|
| |
| |
| |
| | |
Jeremy.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
handling. Gets rid of more code than it adds.
I will port this to SAMBA_3_0 next. There are
still some wrinkles with wildcard delete I am
working on - for example a dirtype pattern of
0x8aa4 isn't handled correctly yet.... still
looking at this.
Jeremy.
|
| |
| |
| |
| |
| |
| |
| |
| | |
"never" as
key words for -1 as policy values for net sam policy.
Volker
|
| |
| |
| |
| |
| |
| |
| |
| | |
We were incorrectly calculating the days until the password expires and
we also need to look at the info3 pass_must_change_time for expiry
calculation.
Guenther
|
| |
| |
| |
| | |
for the hint.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
wcard unlink if bad_path was set. The error
returned here is almost certainly incorrect
and will need testing properly with smbtorture,
but I don't want to forget about this path
(yes Volker I know this is currently incorrect :-).
Jeremy.
|
| |
| |
| |
| |
| |
| |
| |
| | |
particular the NT_STATUS_INVALID_PARAMETER thing was badly wrong. Remove the
changes based on it. Using gentest is much more effective in this respect, but
it will take a while to figure out the wildcard error handling of W2k3.
Volker
|
| |
| |
| |
| | |
Guenther
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
BAD_PARAMETER if unlink is a wildcard but wildcard
unlinks are so rare in modern clients that doing what
W2K3 does is probably ok. OS/2 is the only client that
may care about this and hopefully we will get test coverage
from our wonderful OS/2 test team on this ! :-).
Jeremy.
|
| |
| |
| |
| |
| | |
go in both branches.
Jeremy.
|
| | |
|
| | |
|
| |
| |
| |
| | |
metze
|
| |
| |
| |
| |
| |
| | |
- allocate an OID range for conflicting attributes/classes
metze
|
| |
| |
| |
| |
| |
| |
| | |
than lots of indented code. Change recursive_rmdir()
to return the smbd standards of True on success, False
on fail (it was doing the reverse, which was very confusing).
Jeremy.
|
| | |
|
| |
| |
| |
| |
| |
| | |
reply_close() at its heart is going to be an async call :-)
Volker
|
| |
| |
| |
| |
| |
| | |
"Make us survive and activate RAW-CLOSE"
Jeremy.
|
| |
| |
| |
| |
| |
| | |
non-existing krb5 credential cache should not generate an error.
Guenther
|
| |
| |
| |
| |
| |
| | |
write access into the source tree (like when your
directory is nfs mounted for example....).
Jeremy.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
on the file server code now except for the change
notify code.
"Closing a dir with del-on-close set requires the same as files: Don't actually
unlink/rmdir if another process still has it open.
Jeremy, this is a potential merger to 3.0.24."
Jeremy.
|
| |
| |
| |
| | |
Jeremy.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
"smbcli_setattr("") always returns ACCESS_DENIED, test extension to follow.
Merge to 3.0.24?"
Yep (with slight optimization).
Jeremy.
|
| |
| |
| |
| | |
Jeremy.
|
| |
| |
| |
| |
| |
| |
| | |
"Both remaining calls of can_delete called it with check_is_at_open==False,
remove that parameter."
Jeremy.
|
| |
| |
| |
| |
| |
| | |
"Make us survive & activate RAW-UNLINK"
Jeremy.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I agree with this one :
"Jeremy, another one to check:
The only error path of can_delete() that we're interested in ntcreate&x is the
one of can_delete_file_in_directory(), so call that directly.
The only other one where we might get a NT_STATUS_ACCESS_DENIED is from the
lstat in can_delete, but this is covered later in the open_directory and
open_file_ntcreate calls. open_directory does a stat() in the open case which
also covers the (potential) symlink, and open_file_ntcreate does the open(2)
itself, so this should also work.
This makes can_delete() static to reply.c.
Volker"
Jeremy.
|
| |
| |
| |
| | |
Guenther
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
3_0 and
3_0_24 because I was explicitly asked to, although this needs close
review. Jeremy, I'm sure you will check this thoroughly :-)
In reply_open_and_X the separate "size" variable kills the calculation of the
SPARSE flag returned to the client in the attrib field. In getpathinfo we do
it correctly, and RAW-OPEN (correctly) complains about the difference.
Add the "set the write time" to mknew and create.
For trans2open we were missing the "ofun == 0" ->
NT_STATUS_OBJECT_NAME_COLLISION case, and we dropped the status returned in
favor of ACCESS_DENIED once too many.
Last change is a fix to trans2open: We were returning the attributes given by
the client, not the attributes of the new file.
Volker
|
| |
| |
| |
| |
| | |
"Get rid of a redundant !NT_STATUS_IS_OK(status)"
Jeremy.
|
| |
| |
| |
| |
| |
| | |
"Get rid of a bogus variable that was only assigned but never read."
Was used but is not now.
Jeremy.
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
the child domain cannot always resolve SIDs in sibling domains.
Windows tries to contact a DC in its own domain and then the root
domain in the forest. This async changes makes winbindd's name2sid()
call do the same.
|