diff options
| author | Andrew Tridgell <tridge@samba.org> | 1998-05-11 06:35:45 +0000 |
|---|---|---|
| committer | Andrew Tridgell <tridge@samba.org> | 1998-05-11 06:35:45 +0000 |
| commit | 6b0c1733d2ebf3b8f09f3bf88b8648d8b371bb1f (patch) | |
| tree | b3c8e8945e8f93a65d307caf7d2357e392d8cae2 /source | |
| parent | 29462c8d7a241eb462b1583170a0b5f16096ea3f (diff) | |
| download | samba-6b0c1733d2ebf3b8f09f3bf88b8648d8b371bb1f.tar.gz samba-6b0c1733d2ebf3b8f09f3bf88b8648d8b371bb1f.tar.xz samba-6b0c1733d2ebf3b8f09f3bf88b8648d8b371bb1f.zip | |
changed to use slprintf() instead of sprintf() just about
everywhere. I've implemented slprintf() as a bounds checked sprintf()
using mprotect() and a non-writeable page.
This should prevent any sprintf based security holes.
Diffstat (limited to 'source')
| -rw-r--r-- | source/web/swat.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source/web/swat.c b/source/web/swat.c index b96c7d0ec79..78c1fa4f198 100644 --- a/source/web/swat.c +++ b/source/web/swat.c @@ -329,7 +329,7 @@ static void commit_parameters(int snum) char *v; while ((parm = lp_next_parameter(snum, &i, 1))) { - sprintf(label, "parm_%s", make_parm_name(parm->label)); + slprintf(label, sizeof(label)-1, "parm_%s", make_parm_name(parm->label)); if ((v = cgi_variable(label))) { if (parm->flags & FLAG_HIDE) continue; commit_parameter(snum, parm, v); |