diff options
author | Gerald Carter <jerry@samba.org> | 2007-05-21 20:36:22 +0000 |
---|---|---|
committer | Gerald Carter <jerry@samba.org> | 2007-05-21 20:36:22 +0000 |
commit | a67e916bdf30e2eeee516234601370b6d594608f (patch) | |
tree | c96c57e5098c2d7b952d6a7b79d18f1f956ca551 /source | |
parent | bb54d7f722544a1b2de2deef0ce8c336361396d4 (diff) | |
download | samba-a67e916bdf30e2eeee516234601370b6d594608f.tar.gz samba-a67e916bdf30e2eeee516234601370b6d594608f.tar.xz samba-a67e916bdf30e2eeee516234601370b6d594608f.zip |
r23048: Simo is correct in that winbind_lookup{sid,name}_async() needs
to be able to handle SIDs in the S-1-22-{1,2} domain in order
for winbindd_sid_to_uid(), et. al. to succeed. For 3.0.25a,
we will short circuit in the sid_to_uid() family of functions
so that smbd is ok.
For 3.0.26, we need to allow winbindd to handle all types of SIDs.
Diffstat (limited to 'source')
-rw-r--r-- | source/nsswitch/idmap.c | 5 | ||||
-rw-r--r-- | source/nsswitch/winbindd_passdb.c | 7 | ||||
-rw-r--r-- | source/nsswitch/winbindd_util.c | 19 |
3 files changed, 29 insertions, 2 deletions
diff --git a/source/nsswitch/idmap.c b/source/nsswitch/idmap.c index babd5645aaf..8f3e7c465e4 100644 --- a/source/nsswitch/idmap.c +++ b/source/nsswitch/idmap.c @@ -821,7 +821,10 @@ static NTSTATUS idmap_can_map(const struct id_map *map, struct idmap_domain **re /* Check we do not create mappings for our own local domain, or BUILTIN or special SIDs */ if ((sid_compare_domain(map->sid, get_global_sam_sid()) == 0) || sid_check_is_in_builtin(map->sid) || - sid_check_is_in_wellknown_domain(map->sid)) { + sid_check_is_in_wellknown_domain(map->sid) || + sid_check_is_in_unix_users(map->sid) || + sid_check_is_in_unix_groups(map->sid) ) + { DEBUG(10, ("We are not supposed to create mappings for our own domains (local, builtin, specials)\n")); return NT_STATUS_UNSUCCESSFUL; } diff --git a/source/nsswitch/winbindd_passdb.c b/source/nsswitch/winbindd_passdb.c index 56166be7d31..ed01346df67 100644 --- a/source/nsswitch/winbindd_passdb.c +++ b/source/nsswitch/winbindd_passdb.c @@ -125,7 +125,12 @@ static NTSTATUS sid_to_name(struct winbindd_domain *domain, /* Paranoia check */ if (!sid_check_is_in_builtin(sid) && - !sid_check_is_in_our_domain(sid)) { + !sid_check_is_in_our_domain(sid) && + !sid_check_is_in_unix_users(sid) && + !sid_check_is_unix_users(sid) && + !sid_check_is_in_unix_groups(sid) && + !sid_check_is_unix_groups(sid) ) + { DEBUG(0, ("Possible deadlock: Trying to lookup SID %s with " "passdb backend\n", sid_string_static(sid))); return NT_STATUS_NONE_MAPPED; diff --git a/source/nsswitch/winbindd_util.c b/source/nsswitch/winbindd_util.c index 2d744ebcd8b..326fb64a2f7 100644 --- a/source/nsswitch/winbindd_util.c +++ b/source/nsswitch/winbindd_util.c @@ -923,6 +923,17 @@ struct winbindd_domain *find_lookup_domain_from_sid(const DOM_SID *sid) return find_domain_from_sid(sid); } + /* SIDs in the S-1-22-{1,2} domain should be handled by our passdb */ + + if ( sid_check_is_in_unix_groups(sid) || + sid_check_is_unix_groups(sid) || + sid_check_is_in_unix_users(sid) || + sid_check_is_unix_users(sid) ) + { + return find_domain_from_sid(get_global_sam_sid()); + } + + /* On a member server a query for SID or name can always go to our * primary DC. */ @@ -936,6 +947,14 @@ struct winbindd_domain *find_lookup_domain_from_name(const char *domain_name) strequal(domain_name, get_global_sam_name())) return find_domain_from_name_noinit(domain_name); + /* The "Unix User" and "Unix Group" domain our handled by passdb */ + + if ( strequal(domain_name, unix_users_domain_name() ) || + strequal(domain_name, unix_groups_domain_name() ) ) + { + return find_domain_from_name_noinit( get_global_sam_name() ); + } + return find_our_domain(); } |