summaryrefslogtreecommitdiffstats
path: root/source3/python
diff options
context:
space:
mode:
authorMartin Pool <mbp@samba.org>2003-02-18 01:09:19 +0000
committerMartin Pool <mbp@samba.org>2003-02-18 01:09:19 +0000
commit5511347b8d5a974d5cd0536eded92c4b77c1091d (patch)
treecaf68b84519307d7fe8d8651389ad0c01e95445d /source3/python
parent335fbbfbc957dea02c37152ec690cdcf54040ae1 (diff)
downloadsamba-5511347b8d5a974d5cd0536eded92c4b77c1091d.tar.gz
samba-5511347b8d5a974d5cd0536eded92c4b77c1091d.tar.xz
samba-5511347b8d5a974d5cd0536eded92c4b77c1091d.zip
Check return code from string_to_sid.
(This used to be commit fe449328b226a33ad1c64e087fe63e79f90ab4ac)
Diffstat (limited to 'source3/python')
-rw-r--r--source3/python/py_lsa.c10
1 files changed, 8 insertions, 2 deletions
diff --git a/source3/python/py_lsa.c b/source3/python/py_lsa.c
index 31706af6840..22db29665a0 100644
--- a/source3/python/py_lsa.c
+++ b/source3/python/py_lsa.c
@@ -235,7 +235,10 @@ static PyObject *lsa_lookup_sids(PyObject *self, PyObject *args,
for (i = 0; i < num_sids; i++) {
PyObject *obj = PyList_GetItem(py_sids, i);
- string_to_sid(&sids[i], PyString_AsString(obj));
+ if (!string_to_sid(&sids[i], PyString_AsString(obj))) {
+ PyErr_SetString(PyExc_ValueError, "string_to_sid failed");
+ return NULL;
+ }
}
} else {
@@ -245,7 +248,10 @@ static PyObject *lsa_lookup_sids(PyObject *self, PyObject *args,
num_sids = 1;
sids = (DOM_SID *)talloc(hnd->mem_ctx, sizeof(DOM_SID));
- string_to_sid(&sids[0], PyString_AsString(py_sids));
+ if (!string_to_sid(&sids[0], PyString_AsString(py_sids))) {
+ PyErr_SetString(PyExc_ValueError, "string_to_sid failed");
+ return NULL;
+ }
}
ntstatus = cli_lsa_lookup_sids(hnd->cli, hnd->mem_ctx, &hnd->pol,