summaryrefslogtreecommitdiffstats
path: root/source/winbindd/winbindd_dual.c
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2008-08-31 11:34:01 +0200
committerKarolin Seeger <kseeger@samba.org>2008-09-01 17:35:43 +0200
commitb120493a2c0c6c321d95546e13e6e1c4d44b40bb (patch)
tree1830d9f5458aa1aed0f62fecccc2e54dc0b29ede /source/winbindd/winbindd_dual.c
parent5310a93b09a9f63b4aea4e864d143cf2ecb62e82 (diff)
downloadsamba-b120493a2c0c6c321d95546e13e6e1c4d44b40bb.tar.gz
samba-b120493a2c0c6c321d95546e13e6e1c4d44b40bb.tar.xz
samba-b120493a2c0c6c321d95546e13e6e1c4d44b40bb.zip
Fix Coverity ID 592
The scanner did not figure out that we always have a primary domain, so it complained about us potentially passing a NULL pointer down to set_domain_online_request() where it is dereferenced. Make the code a bit clearer. (cherry picked from commit e6e8d108f95ed974f98f3f57adcfbbde4e00fad9) (cherry picked from commit 70dbc13aaef893b25e3164fdcf187a01ec27b392)
Diffstat (limited to 'source/winbindd/winbindd_dual.c')
-rw-r--r--source/winbindd/winbindd_dual.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/source/winbindd/winbindd_dual.c b/source/winbindd/winbindd_dual.c
index 1e8325f9833..f3b277cc84e 100644
--- a/source/winbindd/winbindd_dual.c
+++ b/source/winbindd/winbindd_dual.c
@@ -1107,6 +1107,10 @@ static bool fork_domain_child(struct winbindd_child *child)
}
}
+ if (primary_domain == NULL) {
+ smb_panic("no primary domain found");
+ }
+
/* Ensure we're not handling an event inherited from
our parent. */