diff options
| author | Jeremy Allison <jra@samba.org> | 2004-01-07 19:55:01 +0000 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2004-01-07 19:55:01 +0000 |
| commit | 8e20c06ed31d9ec10ff0155b1624eee3d60cd006 (patch) | |
| tree | c2e61b0733c44b73891b49c44a9067da6c2d2fe2 /source/smbd/sesssetup.c | |
| parent | 85da181e8a0ade839f6d595fabdf4cea606f82e1 (diff) | |
| download | samba-8e20c06ed31d9ec10ff0155b1624eee3d60cd006.tar.gz samba-8e20c06ed31d9ec10ff0155b1624eee3d60cd006.tar.xz samba-8e20c06ed31d9ec10ff0155b1624eee3d60cd006.zip | |
Fix from Luke Howard <lukeh@PADL.COM> for incorrect early free().
Jeremy.
Diffstat (limited to 'source/smbd/sesssetup.c')
| -rw-r--r-- | source/smbd/sesssetup.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/source/smbd/sesssetup.c b/source/smbd/sesssetup.c index 2c38cd3eb3a..80be9da53bf 100644 --- a/source/smbd/sesssetup.c +++ b/source/smbd/sesssetup.c @@ -241,11 +241,10 @@ static int reply_spnego_kerberos(connection_struct *conn, pw = smb_getpwnam( user ); - SAFE_FREE(user); - SAFE_FREE(client); - if (!pw) { DEBUG(1,("Username %s is invalid on this system\n",user)); + SAFE_FREE(user); + SAFE_FREE(client); data_blob_free(&ap_rep); return ERROR_NT(NT_STATUS_LOGON_FAILURE); } @@ -257,14 +256,17 @@ static int reply_spnego_kerberos(connection_struct *conn, if (!NT_STATUS_IS_OK(ret = make_server_info_pw(&server_info,pw))) { DEBUG(1,("make_server_info_from_pw failed!\n")); + SAFE_FREE(user); + SAFE_FREE(client); data_blob_free(&ap_rep); return ERROR_NT(ret); } /* register_vuid keeps the server info */ - sess_vuid = register_vuid(server_info, session_key, nullblob, user); + sess_vuid = register_vuid(server_info, session_key, nullblob, client); - free(user); + SAFE_FREE(user); + SAFE_FREE(client); if (sess_vuid == -1) { ret = NT_STATUS_LOGON_FAILURE; |