diff options
| author | Stefan Metzmacher <metze@samba.org> | 2007-08-21 14:22:16 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 12:30:09 -0500 |
| commit | 8532e3182ab44d4ac84823e9798293f156192aaf (patch) | |
| tree | eb0a0c87a357978ba3306156dcf1633f77bcebb0 /source/smbd/server.c | |
| parent | 5c4d998300d0c9836eb3cc6c3cd8ee4f262396b8 (diff) | |
| download | samba-8532e3182ab44d4ac84823e9798293f156192aaf.tar.gz samba-8532e3182ab44d4ac84823e9798293f156192aaf.tar.xz samba-8532e3182ab44d4ac84823e9798293f156192aaf.zip | |
r24599: patch from Karolin Seeger <ks@sernet.de>:
smbd, nmbd and winbindd can be started with invalid options currently.
The first patch attached would be a possible solution.
It contains an exit if an invalid option has been used. The main problem
is, that existing setups with wrong options or missing arguments in start
scripts will break (which is the right behaviour from my point of view).
metze
Diffstat (limited to 'source/smbd/server.c')
| -rw-r--r-- | source/smbd/server.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/source/smbd/server.c b/source/smbd/server.c index 491482eea62..3bb60058acb 100644 --- a/source/smbd/server.c +++ b/source/smbd/server.c @@ -855,7 +855,10 @@ extern void build_options(BOOL screen); case 'b': build_options(True); /* Display output to screen as well as debug */ exit(0); - break; + default: + d_fprintf(stderr, "\nInvalid option %s: %s\n", + poptBadOption(pc, 0), poptStrerror(opt)); + exit(1); } } |