diff options
author | Volker Lendecke <vlendec@samba.org> | 2007-08-04 10:32:54 +0000 |
---|---|---|
committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 12:29:17 -0500 |
commit | fa385e9f3c980756e428d89e73012cce895c3bf6 (patch) | |
tree | 01e319dbee3ca35e75673452d0da0aa9f890ce5b /source/rpcclient | |
parent | 461974d2cc18c729f152356a9c30cc776f288906 (diff) | |
download | samba-fa385e9f3c980756e428d89e73012cce895c3bf6.tar.gz samba-fa385e9f3c980756e428d89e73012cce895c3bf6.tar.xz samba-fa385e9f3c980756e428d89e73012cce895c3bf6.zip |
r24167: Fix Coverity ID 365
We checked argc>=3 some lines above
Diffstat (limited to 'source/rpcclient')
-rw-r--r-- | source/rpcclient/cmd_samr.c | 17 |
1 files changed, 7 insertions, 10 deletions
diff --git a/source/rpcclient/cmd_samr.c b/source/rpcclient/cmd_samr.c index b5ccab88863..d8528339fe9 100644 --- a/source/rpcclient/cmd_samr.c +++ b/source/rpcclient/cmd_samr.c @@ -1798,18 +1798,15 @@ static NTSTATUS cmd_samr_lookup_names(struct rpc_pipe_client *cli, /* Look up names */ num_names = argc - 2; - if (num_names) { - if ((names = TALLOC_ARRAY(mem_ctx, const char *, num_names)) == NULL) { - rpccli_samr_close(cli, mem_ctx, &domain_pol); - rpccli_samr_close(cli, mem_ctx, &connect_pol); - result = NT_STATUS_NO_MEMORY; - goto done; - } - } else { - names = NULL; + + if ((names = TALLOC_ARRAY(mem_ctx, const char *, num_names)) == NULL) { + rpccli_samr_close(cli, mem_ctx, &domain_pol); + rpccli_samr_close(cli, mem_ctx, &connect_pol); + result = NT_STATUS_NO_MEMORY; + goto done; } - for (i = 0; i < argc - 2; i++) + for (i = 0; i < num_names; i++) names[i] = argv[i + 2]; result = rpccli_samr_lookup_names(cli, mem_ctx, &domain_pol, |