diff options
| author | Simo Sorce <idra@samba.org> | 2003-06-22 10:09:52 +0000 |
|---|---|---|
| committer | Simo Sorce <idra@samba.org> | 2003-06-22 10:09:52 +0000 |
| commit | c501e84d412563eb3f674f76038ec48c2b458687 (patch) | |
| tree | 50bab35223837e8be991daaba0adfd7b5539a3fe /source/pam_smbpass | |
| parent | b7760faedc2181538ffc325e727808e6df8f943f (diff) | |
| download | samba-c501e84d412563eb3f674f76038ec48c2b458687.tar.gz samba-c501e84d412563eb3f674f76038ec48c2b458687.tar.xz samba-c501e84d412563eb3f674f76038ec48c2b458687.zip | |
Found out a good number of NT_STATUS_IS_ERR used the wrong way.
As abartlet rememberd me NT_STATUS_IS_ERR != !NT_STATUS_IS_OK
This patch will cure the problem.
Working on this one I found 16 functions where I think NT_STATUS_IS_ERR() is
used correctly, but I'm not 100% sure, coders should check the use of
NT_STATUS_IS_ERR() in samba is ok now.
Simo.
Diffstat (limited to 'source/pam_smbpass')
| -rw-r--r-- | source/pam_smbpass/pam_smb_passwd.c | 2 | ||||
| -rw-r--r-- | source/pam_smbpass/support.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/source/pam_smbpass/pam_smb_passwd.c b/source/pam_smbpass/pam_smb_passwd.c index 78b89c60b76..bef587a916c 100644 --- a/source/pam_smbpass/pam_smb_passwd.c +++ b/source/pam_smbpass/pam_smb_passwd.c @@ -298,7 +298,7 @@ int pam_sm_chauthtok(pam_handle_t *pamh, int flags, uid_t uid; /* password updated */ - if (NT_STATUS_IS_ERR(sid_to_uid(pdb_get_user_sid(sampass), &uid))) { + if (!NT_STATUS_IS_OK(sid_to_uid(pdb_get_user_sid(sampass), &uid))) { _log_err( LOG_NOTICE, "Unable to get uid for user %s", pdb_get_username(sampass)); _log_err( LOG_NOTICE, "password for (%s) changed by (%s/%d)", diff --git a/source/pam_smbpass/support.c b/source/pam_smbpass/support.c index 62cc866fae0..8a0432c8550 100644 --- a/source/pam_smbpass/support.c +++ b/source/pam_smbpass/support.c @@ -399,7 +399,7 @@ int _smb_verify_password( pam_handle_t * pamh, SAM_ACCOUNT *sampass, service ? service : "**unknown**", name); new->count = 1; } - if (NT_STATUS_IS_ERR(sid_to_uid(pdb_get_user_sid(sampass), &(new->id)))) { + if (!NT_STATUS_IS_OK(sid_to_uid(pdb_get_user_sid(sampass), &(new->id)))) { _log_err(LOG_NOTICE, "failed auth request by %s for service %s as %s", uidtoname(getuid()), |