diff options
| author | Jeremy Allison <jra@samba.org> | 2006-06-28 04:43:19 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 11:19:03 -0500 |
| commit | 4e7262c81ad2945048cb8d0789af032a05008988 (patch) | |
| tree | c36a893f544ea9707da68a3d7a8551ba6a966222 /source/nsswitch | |
| parent | 7d7a98208b1b514da60486fcbbb7b6d04df4ffac (diff) | |
| download | samba-4e7262c81ad2945048cb8d0789af032a05008988.tar.gz samba-4e7262c81ad2945048cb8d0789af032a05008988.tar.xz samba-4e7262c81ad2945048cb8d0789af032a05008988.zip | |
r16610: Subtle one from Klocwork #2076. If multiple flags
are set in a winbindd request it might overwrite existing
state->response.extra_data.data values without freeing.
Jeremy.
Diffstat (limited to 'source/nsswitch')
| -rw-r--r-- | source/nsswitch/winbindd_pam.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/source/nsswitch/winbindd_pam.c b/source/nsswitch/winbindd_pam.c index 1eb2659905b..34d23ebf8fa 100644 --- a/source/nsswitch/winbindd_pam.c +++ b/source/nsswitch/winbindd_pam.c @@ -97,6 +97,7 @@ static NTSTATUS append_info3_as_ndr(TALLOC_CTX *mem_ctx, } size = prs_data_size(&ps); + SAFE_FREE(state->response.extra_data.data); state->response.extra_data.data = SMB_MALLOC(size); if (!state->response.extra_data.data) { prs_mem_free(&ps); @@ -1365,6 +1366,7 @@ done: cell += 1; /* Append an AFS token string */ + SAFE_FREE(state->response.extra_data.data); state->response.extra_data.data = afs_createtoken_str(afsname, cell); @@ -1614,6 +1616,7 @@ enum winbindd_result winbindd_dual_pam_auth_crap(struct winbindd_domain *domain, DEBUG(5, ("Setting unix username to [%s]\n", username_out)); + SAFE_FREE(state->response.extra_data.data); state->response.extra_data.data = SMB_STRDUP(username_out); if (!state->response.extra_data.data) { result = NT_STATUS_NO_MEMORY; |