diff options
| author | Jelmer Vernooij <jelmer@samba.org> | 2003-08-14 19:57:23 +0000 |
|---|---|---|
| committer | Jelmer Vernooij <jelmer@samba.org> | 2003-08-14 19:57:23 +0000 |
| commit | 8625f0e015481a79b0a7dedb77c60ce7b2cb7b84 (patch) | |
| tree | 25934a2170075de57a626aecde725da182cbe3e4 /source/modules | |
| parent | c8f4d7952ffbe0438e33c37ae1365e5dd4f1734a (diff) | |
| download | samba-8625f0e015481a79b0a7dedb77c60ce7b2cb7b84.tar.gz samba-8625f0e015481a79b0a7dedb77c60ce7b2cb7b84.tar.xz samba-8625f0e015481a79b0a7dedb77c60ce7b2cb7b84.zip | |
Fix overflow in vfs_recycle module (and hopefully also bug #291)
Diffstat (limited to 'source/modules')
| -rw-r--r-- | source/modules/vfs_recycle.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/source/modules/vfs_recycle.c b/source/modules/vfs_recycle.c index e725daedba4..c0b331b8621 100644 --- a/source/modules/vfs_recycle.c +++ b/source/modules/vfs_recycle.c @@ -455,7 +455,8 @@ static int recycle_unlink(vfs_handle_struct *handle, connection_struct *conn, co /* rename file we move to recycle bin */ i = 1; while (recycle_file_exist(handle, final_name)) { - snprintf(final_name, PATH_MAX -1, "%s/Copy #%d of %s", temp_name, i++, base); + SAFE_FREE(final_name); + asprintf(&final_name, "%s/Copy #%d of %s", temp_name, i++, base); } DEBUG(10, ("recycle: Moving %s to %s\n", file_name, final_name)); |