Ok - this is more subtle than it looks :-).

When a file is being closed, once it passes the fnum and tid tests then
the locking context should be ignored when removing all locks. This is
what is done in the brl close case, but when you have outstanding
POSIX locks, then you cannot remove all the brl locks in one go, you
have to get the lock list and call do_unlock individually. As this
uses global_smbpid as the locking context, you need to make sure
that this is set correctly for the specific lock being removed. I
now do this by storing the smbpid in each entry in the unlock list returned from
the query call. I removed the smbpid from fsp (not needed) and
things seem ok (even with the stupid smbpid tricks that smbtorture plays :-).

Jeremy.

1 files changed, 2 insertions, 0 deletions

diff --git a/source/locking/brlock.c b/source/locking/brlock.c
index ed1f73df5ed..410fb3fc0bd 100644
--- a/source/locking/brlock.c
+++ b/source/locking/brlock.c
@@ -367,6 +367,7 @@ BECOMES.....
 				ZERO_STRUCTP(ul_new);
 				ul_new->start = lock->start + lock->size;
 				ul_new->size = ul_curr->start + ul_curr->size - ul_new->start;
+				ul_new->smbpid = ul_curr->smbpid;
 
 				/* Add into the dlink list after the ul_curr point - NOT at ulhead. */
 				DLIST_ADD(ul_curr, ul_new);
@@ -638,6 +639,7 @@ struct unlock_list *brl_getlocklist( TALLOC_CTX *ctx, SMB_DEV_T dev, SMB_INO_T i
 				ZERO_STRUCTP(ul_new);
 				ul_new->start = lock->start;
 				ul_new->size = lock->size;
+				ul_new->smbpid = lock->context.smbpid;
 
 				DLIST_ADD(ulist, ul_new);
 		}