diff options
| author | Jeremy Allison <jra@samba.org> | 1998-05-12 00:55:32 +0000 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 1998-05-12 00:55:32 +0000 |
| commit | 2d774454005f0b54e5684cf618da7060594dfcbb (patch) | |
| tree | d3e7831d1d5eb0cc21a78dadb51d63a82c269d2d /source/libsmb/credentials.c | |
| parent | c760ebbf127796427c4602aae61952df938c6def (diff) | |
| download | samba-2d774454005f0b54e5684cf618da7060594dfcbb.tar.gz samba-2d774454005f0b54e5684cf618da7060594dfcbb.tar.xz samba-2d774454005f0b54e5684cf618da7060594dfcbb.zip | |
This is a security audit change of the main source.
It removed all ocurrences of the following functions :
sprintf
strcpy
strcat
The replacements are slprintf, safe_strcpy and safe_strcat.
It should not be possible to use code in Samba that uses
sprintf, strcpy or strcat, only the safe_equivalents.
Once Andrew has fixed the slprintf implementation then
this code will be moved back to the 1.9.18 code stream.
Jeremy.
Diffstat (limited to 'source/libsmb/credentials.c')
| -rw-r--r-- | source/libsmb/credentials.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source/libsmb/credentials.c b/source/libsmb/credentials.c index 9f5c70e5e4a..c9f7ee429ba 100644 --- a/source/libsmb/credentials.c +++ b/source/libsmb/credentials.c @@ -31,7 +31,7 @@ represent a credential as a string char *credstr(uchar *cred) { static fstring buf; - sprintf(buf,"%02X%02X%02X%02X%02X%02X%02X%02X", + slprintf(buf, sizeof(buf) - 1, "%02X%02X%02X%02X%02X%02X%02X%02X", cred[0], cred[1], cred[2], cred[3], cred[4], cred[5], cred[6], cred[7]); return buf; |