diff options
| author | Jeremy Allison <jra@samba.org> | 2007-11-19 17:43:28 -0800 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2007-11-19 17:43:28 -0800 |
| commit | 9c3d10521e691169cfbb8b728f123911c3c970ae (patch) | |
| tree | 4e8ef5757a203e7e844e0daa55f40ec607458025 /source/libsmb/clirap.c | |
| parent | db9fa472a89eb78a7b1f7cabcf195331c3b448d9 (diff) | |
| download | samba-9c3d10521e691169cfbb8b728f123911c3c970ae.tar.gz samba-9c3d10521e691169cfbb8b728f123911c3c970ae.tar.xz samba-9c3d10521e691169cfbb8b728f123911c3c970ae.zip | |
Always check return from push_ascii.
Jeremy.
Diffstat (limited to 'source/libsmb/clirap.c')
| -rw-r--r-- | source/libsmb/clirap.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/source/libsmb/clirap.c b/source/libsmb/clirap.c index 9d106d0394d..848a8d54822 100644 --- a/source/libsmb/clirap.c +++ b/source/libsmb/clirap.c @@ -216,6 +216,7 @@ bool cli_NetServerEnum(struct cli_state *cli, char *workgroup, uint32 stype, pstring param; int uLevel = 1; int count = -1; + size_t len; errno = 0; /* reset */ @@ -235,7 +236,11 @@ bool cli_NetServerEnum(struct cli_state *cli, char *workgroup, uint32 stype, SIVAL(p,0,stype); p += 4; - p += push_ascii(p, workgroup, sizeof(pstring)-PTR_DIFF(p,param)-1, STR_TERMINATE|STR_UPPER); + len = push_ascii(p, workgroup, sizeof(pstring)-PTR_DIFF(p,param)-1, STR_TERMINATE|STR_UPPER); + if (len == (size_t)-1) { + return false; + } + p += len; if (cli_api(cli, param, PTR_DIFF(p,param), 8, /* params, length, max */ |