summaryrefslogtreecommitdiffstats
path: root/source/libmsrpc
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2006-03-14 17:21:30 +0000
committerJeremy Allison <jra@samba.org>2006-03-14 17:21:30 +0000
commit8cdc60f3607387846c411ef53d508abfc97c9a9e (patch)
tree2038316a9a1d7cb46327f973aaa129326356f53f /source/libmsrpc
parent5a0326dbd9bd80d76845ffe956f48e92c286d677 (diff)
downloadsamba-8cdc60f3607387846c411ef53d508abfc97c9a9e.tar.gz
samba-8cdc60f3607387846c411ef53d508abfc97c9a9e.tar.xz
samba-8cdc60f3607387846c411ef53d508abfc97c9a9e.zip
r14387: Try and fix the coverity issues (#53, #54) with negative
sink by ensuring all uses of rpcstr_push are consistent with a size_t dest size arg. Jeremy.
Diffstat (limited to 'source/libmsrpc')
-rw-r--r--source/libmsrpc/libmsrpc_internal.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/source/libmsrpc/libmsrpc_internal.c b/source/libmsrpc/libmsrpc_internal.c
index ac61424e70b..f57063dc42e 100644
--- a/source/libmsrpc/libmsrpc_internal.c
+++ b/source/libmsrpc/libmsrpc_internal.c
@@ -100,7 +100,6 @@ RPC_DATA_BLOB *cac_MakeRpcDataBlob(TALLOC_CTX *mem_ctx, uint32 data_type, REG_VA
RPC_DATA_BLOB *blob = NULL;
int i;
uint32 size = 0;
- uint32 len = 0;
uint8 *multi = NULL;
uint32 multi_idx = 0;
@@ -149,7 +148,7 @@ RPC_DATA_BLOB *cac_MakeRpcDataBlob(TALLOC_CTX *mem_ctx, uint32 data_type, REG_VA
/*do it using rpcstr_push()*/
multi_idx = 0;
for(i = 0; i < data.reg_multi_sz.num_strings; i++) {
- len = strlen(data.reg_multi_sz.strings[i]) + 1;
+ size_t len = strlen(data.reg_multi_sz.strings[i]) + 1;
rpcstr_push((multi + multi_idx), data.reg_multi_sz.strings[i], len * 2, STR_TERMINATE);