diff options
| author | Volker Lendecke <vlendec@samba.org> | 2006-08-25 18:24:43 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 11:38:52 -0500 |
| commit | d727fc681c073a1b09accd31a07341b58e10eebb (patch) | |
| tree | 0e233ddfc0c05203ccda47c2f48bc66f8a6f744f /source/libaddns | |
| parent | 63b13d28795bbce6d9fe9e0aa4f518ef94c44f18 (diff) | |
| download | samba-d727fc681c073a1b09accd31a07341b58e10eebb.tar.gz samba-d727fc681c073a1b09accd31a07341b58e10eebb.tar.xz samba-d727fc681c073a1b09accd31a07341b58e10eebb.zip | |
r17835: Fix Coverity bugs 306, 309, 310.
Jeremy, you might want to look at the trans2 one.
Volker
Diffstat (limited to 'source/libaddns')
| -rw-r--r-- | source/libaddns/dnssock.c | 2 | ||||
| -rw-r--r-- | source/libaddns/dnsupdate.c | 5 |
2 files changed, 1 insertions, 6 deletions
diff --git a/source/libaddns/dnssock.c b/source/libaddns/dnssock.c index 3d0991a1aae..d3223b9bd89 100644 --- a/source/libaddns/dnssock.c +++ b/source/libaddns/dnssock.c @@ -732,7 +732,7 @@ void DNSFreeSendBufferContext( HANDLE hSendBuffer ) pSendBufferContext = ( DNS_SENDBUFFER_CONTEXT * ) hSendBuffer; - if ( pSendBufferContext->pSendBuffer ) { + if ( pSendBufferContext && pSendBufferContext->pSendBuffer ) { DNSFreeMemory( pSendBufferContext->pSendBuffer ); } if ( pSendBufferContext ) { diff --git a/source/libaddns/dnsupdate.c b/source/libaddns/dnsupdate.c index 36c5cbb13ad..503316d3058 100644 --- a/source/libaddns/dnsupdate.c +++ b/source/libaddns/dnsupdate.c @@ -431,7 +431,6 @@ int32 DNSUpdateGenerateSignature( gss_ctx_id_t * pGSSContext, { int32 dwError = 0; int32 dwMinorStatus = 0; - HANDLE hSendBuffer = ( HANDLE ) NULL; uint8 *pMessageBuffer = NULL; int32 dwMessageSize = 0; int32 dwMaxSignatureSize = 0; @@ -477,10 +476,6 @@ int32 DNSUpdateGenerateSignature( gss_ctx_id_t * pGSSContext, error: - if ( hSendBuffer ) { - DNSFreeSendBufferContext( hSendBuffer ); - } - if ( pMessageBuffer ) { DNSFreeMemory( pMessageBuffer ); } |