diff options
| author | Jeremy Allison <jra@samba.org> | 1998-05-12 00:55:32 +0000 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 1998-05-12 00:55:32 +0000 |
| commit | 2d774454005f0b54e5684cf618da7060594dfcbb (patch) | |
| tree | d3e7831d1d5eb0cc21a78dadb51d63a82c269d2d /source/lib/pidfile.c | |
| parent | c760ebbf127796427c4602aae61952df938c6def (diff) | |
| download | samba-2d774454005f0b54e5684cf618da7060594dfcbb.tar.gz samba-2d774454005f0b54e5684cf618da7060594dfcbb.tar.xz samba-2d774454005f0b54e5684cf618da7060594dfcbb.zip | |
This is a security audit change of the main source.
It removed all ocurrences of the following functions :
sprintf
strcpy
strcat
The replacements are slprintf, safe_strcpy and safe_strcat.
It should not be possible to use code in Samba that uses
sprintf, strcpy or strcat, only the safe_equivalents.
Once Andrew has fixed the slprintf implementation then
this code will be moved back to the 1.9.18 code stream.
Jeremy.
Diffstat (limited to 'source/lib/pidfile.c')
| -rw-r--r-- | source/lib/pidfile.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source/lib/pidfile.c b/source/lib/pidfile.c index 46d6a9d5b8c..9cb3f5afef4 100644 --- a/source/lib/pidfile.c +++ b/source/lib/pidfile.c @@ -58,7 +58,7 @@ void pidfile_create(char *name) } memset(buf, 0, sizeof(buf)); - sprintf(buf, "%u\n", (unsigned int) getpid()); + slprintf(buf, sizeof(buf) - 1, "%u\n", (unsigned int) getpid()); if (write(fd, buf, sizeof(buf)) != sizeof(buf)) { DEBUG(0,("ERROR: can't write to %s: %s\n", pidFile, strerror(errno))); |