diff options
author | Andrew Tridgell <tridge@samba.org> | 1998-09-05 05:07:05 +0000 |
---|---|---|
committer | Andrew Tridgell <tridge@samba.org> | 1998-09-05 05:07:05 +0000 |
commit | 2204475c87f3024ea8fd1fbd7385b2def617a46f (patch) | |
tree | 7ee33f6880d60f973dc592e718765f4ddab0c950 /source/client/clitar.c | |
parent | 94d63cc382ac0d8a523db98b93750225082b09b1 (diff) | |
download | samba-2204475c87f3024ea8fd1fbd7385b2def617a46f.tar.gz samba-2204475c87f3024ea8fd1fbd7385b2def617a46f.tar.xz samba-2204475c87f3024ea8fd1fbd7385b2def617a46f.zip |
tridge the destroyer returns!
prompted by the interpret_security() dead code that Jean-Francois
pointed out I added a make target "finddead" that finds potentially
dead (ie. unused) code. It spat out 304 function names ...
I went through these are deleted many of them, making others static
(finddead also reports functions that are used only in the local
file).
in doing this I have almost certainly deleted some useful code. I may
have even prevented compilation with some compile options. I
apologise. I decided it was better to get rid of this code now and add
back the one or two functions that are needed than to keep all this
baggage.
So, if I have done a bit too much "destroying" then let me know. Keep
the swearing to a minimum :)
One bit I didn't do is the ubibt code. Chris, can you look at that?
Heaps of unused functions there. Can they be made static?
Diffstat (limited to 'source/client/clitar.c')
-rw-r--r-- | source/client/clitar.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/source/client/clitar.c b/source/client/clitar.c index 502a867f60a..376d3aeac69 100644 --- a/source/client/clitar.c +++ b/source/client/clitar.c @@ -39,6 +39,8 @@ #include "includes.h" #include "clitar.h" +static int clipfind(char **aret, int ret, char *tok); + typedef struct file_info_struct file_info2; struct file_info_struct @@ -973,7 +975,7 @@ static BOOL ensurepath(char *fname, char *inbuf, char *outbuf) return True; } -int padit(char *buf, int bufsize, int padsize) +static int padit(char *buf, int bufsize, int padsize) { int berr= 0; int bytestowrite; @@ -2294,7 +2296,7 @@ int process_tar(char *inbuf, char *outbuf) /**************************************************************************** Find a token (filename) in a clip list ***************************************************************************/ -int clipfind(char **aret, int ret, char *tok) +static int clipfind(char **aret, int ret, char *tok) { if (aret==NULL) return 0; |