diff options
author | Stefan Metzmacher <metze@samba.org> | 2009-03-18 07:56:51 +0100 |
---|---|---|
committer | Karolin Seeger <kseeger@samba.org> | 2009-03-27 13:06:54 +0100 |
commit | 7301736f82de4e48fe2ca1491631c12ab4099db6 (patch) | |
tree | 15868a704d274d4340b69319f58778caf77305b0 /release-scripts | |
parent | 6d743ddcaf9876f5f43feb402c782ea7a47ee411 (diff) | |
download | samba-7301736f82de4e48fe2ca1491631c12ab4099db6.tar.gz samba-7301736f82de4e48fe2ca1491631c12ab4099db6.tar.xz samba-7301736f82de4e48fe2ca1491631c12ab4099db6.zip |
s3:libsmb: fix smb signing for fragmented trans/trans2/nttrans requests
Before we send the secondary requests we need to remove the
old mid=>seqnum mapping and reset cli->mid and make the new
mid=>seqnum mapping "persistent".
The bug we had in cli_send_trans was this:
The first cli_send_smb() incremented cli->mid
and the secondary requests used the incremented mid,
but as cli->outbuf still had the correct mid,
we send the correct mid to the server. The real problem
was that the cli_send_smb() function stored the seqnum
under the wrong mid.
cli_send_nttrans() was totally broken and now follows the
same logic as cli_send_trans().
The good thing is that in practice the problem is unlikely to happen,
because max_xmit is large enough to avoid secondary requests.
metze
(cherry picked from commit 880fbc4e8cd67de73c4bcda94489eb1e1422a04b)
(cherry picked from commit 70466990b4b7c68ae95dbbcf741cd3f41f2dd0b3)
(cherry picked from commit d01cca5e3ddb925696d49a1ea728013ec1032372)
(cherry picked from commit 6c13360e195189f7afc70c5fda6ef27f46145b0b)
Diffstat (limited to 'release-scripts')
0 files changed, 0 insertions, 0 deletions